Repository navigation
Conversation
Owner
|
Thanks for this, @LILQK, and for the clear write-up of the silent Before merging, two things need a real Mac, as you noted:
Also, CI hasn't run here yet: workflows on PRs from forks wait for maintainer approval. Generated by Claude Code |
Author
|
Thanks @karem505! Tested on macOS 26 / Apple Silicon with the release build:
Ready for CI whenever you can approve the workflows. |
Owner
|
Thanks for testing, @LILQK. That's exactly what was needed, and good news that drags out of Photos now attach too. Once the CI workflows are approved and green, this is ready to merge. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a Finder file onto an open WhatsApp conversation can do nothing on macOS: Tauri consumes the native drop, then the streaming bridge tries to locate WhatsApp's attachment controls. A
QUEUED:1acknowledgement only confirms that the page received the bytes; if those controls cannot be found, no attachment preview opens and the failure remains silent.Disable Tauri's drag-drop handler on macOS so WKWebView delivers the original drag events and files directly to WhatsApp's drop zone. This uses the same native-drop approach already enabled on Windows and avoids depending on WhatsApp's changing attachment-menu selectors. Update the comments and README to describe the platform-specific paths and Linux-only streaming limits.
Validation on macOS 26 / Apple Silicon:
.appbundle with Tauri CLI.cargo test --locked --release --manifest-path src-tauri/Cargo.toml— 96 tests passed.node src-tauri/resources/bridge.test.mjs— passed.node settings-ui/comboToAccelerator.test.mjs— passed.node settings-ui/dialog.test.mjs— passed.QUEUED:1, zero attachments, and no failure notification.Manual validation still needed: drag a file from Finder onto an open, logged-in WhatsApp conversation and confirm that the attachment preview appears. The build and unit tests do not verify that end-to-end flow.