Repository navigation
Linux calling FAQ; Windows Display size list and toast logo (#39, #40) - #43
Merged
Merged
Conversation
The AppImage bundles its own WebKitGTK, built without WebRTC, so the distro's WebKitGTK doesn't matter there; and even with WebRTC, the Chrome user agent on Linux sends WhatsApp down a calling path WebKit can't run (as on macOS in #15). Drop the claim that calls light up automatically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8dUghRiNrKrHHR5BNMSSD
- settings: the open <select> list is drawn by the engine; on WebView2 in dark mode it stayed white while the option text followed the theme. Give the options the page's background and text colours explicitly. - notifications: register an IconUri next to the AUMID's DisplayName so the toast header shows the whatRust logo instead of a generic window icon. The bundled 128px PNG is written to the local app data dir (only when it differs) because IconUri must name a file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8dUghRiNrKrHHR5BNMSSD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<select>list is drawn by the engine, not by the select's transparent box. On WebView2 in dark mode it stayed white whilecolor: initialfollowed the dark theme. The options now get the page's--bg/--fgexplicitly.IconUrinext to the AUMID'sDisplayName, so the toast header shows the whatRust logo instead of the generic window icon.IconUrimust name an image file, so the bundledicons/128x128.pngis written to the local app data dir asnotification-logo.png, and only rewritten when its bytes differ. If writing the file fails, this is logged and onlyDisplayNameis registered, as before.Testing
cargo test --locked: 106 passed.node src-tauri/resources/bridge.test.mjs: passed.cargo fmt --check: clean.cargo clippy --target x86_64-pc-windows-msvc: builds, with no new warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01L8dUghRiNrKrHHR5BNMSSD
Generated by Claude Code