Repository navigation
add AZT007: acceptance test names must not carry a second Acc - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new rule, AZT007, that reports a
TestAccname carryingAccagain as a word of its own.Why:
Accis the marker that makes a function an acceptance test. A second one, as inTestAccMsSqlServerExtendedAuditingPolicy_storageAccBehindFireWall, reads as a mistake, and as an abbreviation of account it is unclear. azurerm has five of these today, across the MsSQL and Synapse auditing policy tests.A second Acc in the name.
Acccounts when it is a whole camel-case word, followed by an upper-case letter, an underscore or the end of the name, soAccount,Accessandacceleratedare left alone. BothTestAccfunctions and the lowercasetestAcchelpers that sequential tests use are checked, in_test.gofiles only.Things that are fine as they are. A plain
Testname withAccin the wrong place, likeTestWebAppAccActiveSlot_basic, is AZT004's report (#67) when it runs an acceptance test, and is not repeated here. The rule only reports: whetherAccmeant account, access or something else is the author's call.