Repository navigation
move scripts to .scripts - #76
Merged
Merged
Conversation
Matches the layout the other projects now use. The coverage workflow and the script's usage line point at the new folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts folder is now
.scripts.Why: my other projects keep their scripts in
.scripts, and this repo should match so there is one place to look in all of them.The folder. Its one script, the coverage badge publisher, moves across unchanged apart from its usage line.
The coverage workflow. It names the script twice: once to decide whether a change should trigger it, and once to run it. Both now point at the new folder.
Things that are fine as they are. The shellcheck make target and its workflow look for shell scripts anywhere in the repo, so they still find this one; I ran the target's search and it lists the script at its new path. Nothing else in the repo names the folder. The script kept its executable bit. No changelog entry, as nothing changes for anyone using the linter.
Not yet proven. The badge is only published from main, so the step that runs the script from its new path first runs for real after this merges.