Repository navigation
prs: add Last Reviewer field - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Last Reviewertext field to the board, the login of whoever left the most recent review on the PR.Why:
Reviewed At(#25) says when a PR was last looked at but not by whom. Together they answer "who has the ball" without opening the PR.It records the author of the same review that stamps
Reviewed At. Both sync paths already find the newest submitted review, in any state except a pending draft, so the reviewer is captured in that step. The two fields always describe one review.if review.State != string(githubv4.PullRequestReviewStatePending) && review.SubmittedAt.After(pr.ReviewedAt) { pr.ReviewedAt = review.SubmittedAt + pr.LastReviewer = review.Author.Login }Unset when there are no reviews. Same as
Merged By: nothing is written for an unreviewed PR.Refresh updates it on open PRs too. It joins the refresh defaults and the
--include-opensafe list, since it needs only the review list refresh already fetches.Things that are fine as they are. A board without a
Last Reviewerfield logs a warning and skips it, like any other missing field. Build, vet and lint pass; the repo has no tests.