Repository navigation
ci: run tests under the race detector - #135
Merged
Merged
Conversation
Add -race to both go test invocations in `make test`, which CI runs on every push and PR, and build the integration harness's tctest binary with -race so a data race in the CLI itself surfaces as a test failure via the exit-code and output assertions. The race-instrumented run immediately flagged a race in the harness: the azurerm tests set `gh.conflicted` / `gh.openPRs` on the mock GitHub after httptest.NewServer had already spawned the handler goroutines that read those fields. The subprocess had not connected yet, so it never misbehaved, but there is no happens-before edge through exec + TCP that the detector can see. Replace the post-construction writes with `withConflicted` / `withOpenPRs` options applied before the server starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testnow passes-raceto bothgo testinvocations. CI runsmake teston every push and PR, so the race detector runs on every change.tctestbinary with-race, so a data race in the CLI itself surfaces as an integration test failure (the race runtime prints a report and exits non-zero, which the existing exit-code and output assertions catch).gh.conflicted/gh.openPRson the mock GitHub afterhttptest.NewServerhad already spawned the handler goroutines that read them. The binary under test had not connected yet so it never misbehaved, but there is no happens-before edge throughexec+ TCP that the detector can see. Replaced withwithConflicted/withOpenPRsconstructor options applied before the server starts.This is for the OpenSSF Best Practices badge
dynamic_analysiscriterion, which explicitly accepts race detectors.Test plan
make testpasses locally under-race(unit + integration,-count=1)make lintreports 0 issues