Repository navigation
ci: after a release, rerun the failed binary scan in place - #149
Merged
Merged
Conversation
… a new one The workflow_run rescan from #147 attached to the same commit but as its own check runs, so the original push failure stayed and the commit kept its red X. Only a rerun replaces a check run in place. The release workflow now reruns the failed jobs of any binary scan on main's head, which needs actions: write on that one job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a release, rerun the failed binary scan jobs in place instead of starting a new scan.
Why: the rescan from #147 fired correctly after v1.3.4 and passed, but the commit stayed red. GitHub attached it as new check runs beside the original push failure, so main showed 1 failing and 21 successful. Only a rerun of the failed run replaces its check run, which is what I did by hand to clear it.
The release workflow reruns the scan. A last job with
actions: writefinds every binary scan run on main's head that failed and reruns its failed jobs. The rerun re-downloads the latest release, which is now the one just published. If nothing is red it does nothing.The workflow_run trigger is removed along with its success gate and the zizmor suppression. The scan keeps push, schedule and manual dispatch.
Things that are fine as they are. Every failed run on the head commit is rerun, not just the latest, so a red push run and a red Monday run on the same commit both clear. The
actions: writepermission is scoped to the one job; the rest of the release workflow is unchanged. Could not be exercised before merge since it only runs on a tag; yamllint, actionlint and zizmor pass on both files.