Repository navigation
ci: run build and tests when .tools changes, bump gofumpt to 0.12.0 - #151
Merged
Merged
Conversation
build and test are required checks on main but skipped changes that only touch .tools/, so a dev tool bump like #142 waited forever for checks that never started. Both now run on .tools/** changes, like lint and depscheck already do. Also bumps mvdan.cc/gofumpt from 0.11.0 to 0.12.0 in .tools, replacing #142. It wants no formatting changes to the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the required build and test checks on changes to
.tools/, and bump gofumpt to 0.12.0 there, replacing #142.Why: main requires lint, build and test to pass before merging, but build and test only start when certain files change, and
.tools/was not one of them. #142, a dependabot bump that only touches.tools/go.modandgo.sum, has been blocked since 7 October waiting for two checks that would never report. #124 got through on 5 September only because build and test were not yet required.Build and tests now run when the dev tools change. This is the same line #131 added for depscheck; lint already had it.
- 'vendor/**' + - '.tools/**' - '.github/workflows/**'gofumpt 0.12.0. The same change dependabot made in #142, applied here so it isn't lost when that PR closes.
Things that are fine as they are. gofumpt 0.12.0 was built from this branch and run over every Go file outside vendor; it wants no changes. depscheck, lint (on Go 1.26.6, as CI uses), build, actionlint, yamllint and typos pass locally. A PR that only touches docs such as the README would still be blocked the same way, since none of the three required checks run for those files; that is left for another change.