Repository navigation
fix(sefariasqlite): drop translator footnotes from Noda BiYehudah I, Orach Chaim - #100
Merged
Merged
Conversation
…Orach Chaim
Sefaria takes this section from Harold Landa's edition, whose 60 footnotes
are a translator's apparatus: English notes ("See note 47") and Hebrew
sources followed by Sefaria's English translations. They were inlined as
text, so the reader saw long English passages inside the sefer.
Strip footnote markers and bodies (nested <i> tags handled) for refs under
"Noda BiYehudah I, Orach Chaim". Footnotes elsewhere are kept: the author's
own הגה״ה in the introduction, and the English bibliography of other books.
Fixes kdroidFilter/Zayit#439
Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Noda BiYehudah I, Orach Chaim, the reader shows long English passages inside the Hebrew text.
Cause
Sefaria takes this section from Harold Landa's edition. Its 60 footnotes are a translator's apparatus, not part of the printed sefer: English notes ("See note 47") and Hebrew sources followed by Sefaria's English translations. The importer inlined them as text.
Fix
stripSefariaFootnotes: removes footnote markers and bodies, matching nested<i>tags by depth.Noda BiYehudah I, Orach Chaim,(TRANSLATOR_FOOTNOTE_REF_PREFIXES).Tests
SefariaCleanSefariaLineTest;:sefariasqlite:jvmTestpasses.Fixes kdroidFilter/Zayit#439