Repository navigation
fix(sefariasqlite): link the whole Darkhei Moshe to the Tur through the Beit Yosef - #101
Merged
Merged
Conversation
…he Beit Yosef The Darkhei Moshe glosses the Beit Yosef and follows its seif numbering. Sefaria links a Darkhei Moshe seif to the Tur only when the Tur carries its own marker for it (about 2,000 of 6,000 seifim); the others are linked to the Beit Yosef seif they gloss. So studying the Tur with its commentaries showed only part of the Darkhei Moshe. After the links import, anchor each Darkhei Moshe line without a Tur link to the Tur lines its Beit Yosef seif is linked to, keeping only Tur lines of its own siman so lateral citations are not followed. Lines linked to neither book stay unlinked. On the current corpus: 3,889 lines anchored, 177 left unlinked. Fixes kdroidFilter/Zayit#462 Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When studying the Tur with its commentaries, only part of the Darkhei Moshe shows up (kdroidFilter/Zayit#462).
The Darkhei Moshe glosses the Beit Yosef and follows its seif numbering. Sefaria links a Darkhei Moshe seif to the Tur only when the Tur carries its own marker for it (about 2,000 of 6,000 seifim). The others are linked to the Beit Yosef seif they gloss. Checked against the live API:
Darkhei Moshe, Orach Chayim 1:2→Beit Yosef, Orach Chayim 1:2:1only, and Tur OC 1 has Darkhei Moshe markers for 1.1 and 3.1 only.Fix
After the links import, each Darkhei Moshe line without a Tur link gets a COMMENTARY link from the Tur lines its Beit Yosef seif is linked to (Darkhei Moshe → Beit Yosef → Tur).
The commentary/intermediate/base triple is configured in
SefariaSparseCommentaryLinks.kt.Impact (simulated on the current DB)
Tests
SefariaSparseCommentaryLinksTest; the full:sefariasqlite:jvmTestsuite passes.Fixes kdroidFilter/Zayit#462