Repository navigation
fix(sefariasqlite): number and index Midrash Rabbah paragraphs - #103
Merged
Merged
Conversation
The Midrash Rabbah's paragraphs (אותיות) are Sefaria "Integer" segments,
which the importer leaves unlabelled and keeps out of the TOC, so the
books could only be navigated by parasha.
For the ten Midrash Rabbah books, prefix each paragraph with its printed
number ("(א) ") and give it a TOC entry ("אות א") under its parasha. The
entry points at the paragraph line itself, so no heading line is added.
Line ids are unaffected: Sefaria lines are keyed on their heRef, which is
unchanged.
Fixes kdroidFilter/Zayit#509
Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integersegments, which the importer leaves unlabelled and keeps out of the TOC, so the books could only be navigated by parasha.NUMBERED_PARAGRAPH_BOOKS), each paragraph now starts with its printed number ((א) …) and gets a TOC entryאות אunder its parasha (or under the פתיחתא).Fixes kdroidFilter/Zayit#509
Test plan
./gradlew :sefariasqlite:jvmTest(newSefariaNumberedParagraphsTest: labels, TOC levels/line indexes, unchanged heRefs, other books untouched)./gradlew generateSeforimDb) and check the בראשית רבה TOC in the app