Repository navigation
feat(search): find-in-page candidates over a whole book - #104
Merged
Merged
Conversation
findInBookCandidates returns the lines of a book that may contain a literal substring (nikud, final letters and case ignored), for the app to confirm. Null when the index can't answer: book not indexed, or a query too short to filter on. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SearchEngine.findInBookCandidates(query, bookId)(defaultnull) and its Lucene implementation, used by Zayit's find-in-page to search a whole book, not only its loaded pages.nullwhen the index can't answer (book not indexed, or a query too short to filter on): the caller scans the book from the DB.Tests in
LuceneSearchEngineTest.