Repository navigation
fix(generator): skip zero-width chars in countVisibleChars - #105
Merged
Merged
Conversation
Nikud, teamim, other combining marks and bidi controls take no horizontal space but were counted, nearly doubling charCount on vocalized text. The app's content-aware scrollbar models line heights from charCount, so it overestimated vocalized books. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nikud, teamim, other combining marks (
NON_SPACING_MARK,ENCLOSING_MARK) and bidi controls (FORMAT) take no horizontal space but were counted bycountVisibleChars, nearly doublingcharCounton vocalized text.Zayit's content-aware scrollbar models each line's height as
ceil(charCount / capacity), with a capacity measured on unvocalized Hebrew, so vocalized books were overestimated (wrong thumb size, and the thumb stopped short of the end on short books).Visible Hebrew punctuation (maqaf, sof pasuq, paseq) is still counted. Takes effect on the next DB generation; no schema change, ID hash inputs untouched.
Tests added for nikud/teamim, visible punctuation and bidi controls.