Repository navigation
feat(authors): aliases, life years and era from Sefaria author topics - #107
Merged
Merged
Conversation
Read authors.json (SefariaExport PR #7): for each Sefaria author slug, store the other Hebrew titles in author_alias and the birth/death years (+ approx flags) and era on author. author.name stays the raw name, the natural key of its id. author_alias is tracked by the patch producer and the logical content hash. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
authorgainsbirthYear,birthYearApprox,deathYear,deathYearApprox,era(Sefaria era code); newauthor_alias(authorId, alias).author.nameis untouched (id natural key).authors.jsonfrom the export (feat: export authors.json with author topics SefariaExport#7) and fills the life data and aliases (the topic's Hebrew titles other than the name).author_aliasadded to the patch tables and the logical content hash.Verification
./gradlew :generator-common:jvmTest :sefariasqlite:jvmTest :dao:jvmTest :delta-updater:jvmTestNotes
authors.json: merge after the SefariaExport release that includes PR Add source tracking for books from manifest #7.missingHebrewAuthorNames.🤖 Generated with Claude Code