Repository navigation
feat(authors): import author biographies into author_bio - #108
Merged
Merged
Conversation
New :generator-common:importAuthorBios step, run by generateSeforimDb once every author exists (after Otzaria, before the catalog). It reads the kdroidFilter/seforim-author-bio biographies (main branch archive, or -PauthorBioDir= for a local checkout), joins each one to its author by name ignoring bidi marks, and stores the תקציר summary, the full markdown body and the confidence, under the CC-BY-SA license row. Biographies without a matching author are reported and skipped. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
author_bio(authorId, summary, bodyMd, confidence, licenseId); tracked by the patch tables and the logical content hash.:generator-common:importAuthorBios(AuthorBioFileparser +ImportAuthorBiosCli): downloads themainarchive of kdroidFilter/seforim-author-bio (now public), or reads-PauthorBioDir=. Joins by author name (the id's natural key) ignoring LRM/RLM marks, stores the תקציר summary, the markdown body (sections, zayit:// links, sources) and the confidence, pointing at theCC-BY-SAlicense. Unmatched biographies are logged and skipped.generateSeforimDbruns it aftergenerateHavroutaLinksand beforebuildCatalog.Verification
./gradlew :generator-common:jvmTest :sefariasqlite:jvmTest :dao:jvmTest :delta-updater:jvmTestNotes
🤖 Generated with Claude Code