Skip to content

fix(sefariasqlite): name the Maharsha in his Talmud commentaries' titles - #99

Merged
kdroidFilter merged 1 commit into
masterfrom
fix/maharsha-book-titles-440
Oct 8, 2026
Merged

kdroidFilter merged 1 commit into
masterfrom
fix/maharsha-book-titles-440

Conversation

@kdroidFilter

Copy link
Copy Markdown
Owner

Fixes kdroidFilter/Zayit#440

Problem

Sefaria titles the Maharsha's commentaries חידושי הלכות על <מסכת> / חידושי אגדות על <מסכת>. The app lists a commentary by its title without על <base book>, so the reader saw only חידושי הלכות / חידושי אגדות, without knowing it is the Maharsha. 45 books are affected (37 Agadot, 8 Halachot).

Fix

sefariaDisplayTitle prefixes the title with the author for collections whose Hebrew title doesn't name him, keyed by Sefaria's English collective title (Chidushei Agadot, Chidushei Halachot → מהרש"א). The list now shows מהרש"א - חידושי הלכות and מהרש"א - חידושי אגדות.

Only book.title changes: heTitle stays the natural key (canonicalHeTitle) and heRef, so book ids, lines and links are unchanged. The delta ships 45 upsert_book rows, and the "upsert_book without upsert_line" path re-indexes the new titles in Lucene.

Tests

SefariaBookTitlesTest covers the prefixed collections and untouched titles.

Sefaria titles the Maharsha's commentaries "חידושי הלכות/אגדות על <מסכת>",
and the app lists a commentary by its title without " על <base book>",
so the reader saw "חידושי אגדות" with no hint it is the Maharsha.

Prefix the display title with "מהרש\"א - " for the Chidushei Halachot and
Chidushei Agadot collections (45 books). heTitle stays the natural key,
so book ids are unchanged and the delta ships plain upsert_book rows.

Fixes kdroidFilter/Zayit#440

Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
@kdroidFilter
kdroidFilter merged commit 4d72acd into master Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maharsha on Shas: rename the book

1 participant