Repository navigation
fix(sefariasqlite): name the Maharsha in his Talmud commentaries' titles - #99
Merged
Merged
Conversation
Sefaria titles the Maharsha's commentaries "חידושי הלכות/אגדות על <מסכת>", and the app lists a commentary by its title without " על <base book>", so the reader saw "חידושי אגדות" with no hint it is the Maharsha. Prefix the display title with "מהרש\"א - " for the Chidushei Halachot and Chidushei Agadot collections (45 books). heTitle stays the natural key, so book ids are unchanged and the delta ships plain upsert_book rows. Fixes kdroidFilter/Zayit#440 Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes kdroidFilter/Zayit#440
Problem
Sefaria titles the Maharsha's commentaries
חידושי הלכות על <מסכת>/חידושי אגדות על <מסכת>. The app lists a commentary by its title withoutעל <base book>, so the reader saw onlyחידושי הלכות/חידושי אגדות, without knowing it is the Maharsha. 45 books are affected (37 Agadot, 8 Halachot).Fix
sefariaDisplayTitleprefixes the title with the author for collections whose Hebrew title doesn't name him, keyed by Sefaria's English collective title (Chidushei Agadot,Chidushei Halachot→מהרש"א). The list now showsמהרש"א - חידושי הלכותandמהרש"א - חידושי אגדות.Only
book.titlechanges:heTitlestays the natural key (canonicalHeTitle) andheRef, so book ids, lines and links are unchanged. The delta ships 45upsert_bookrows, and the "upsert_book without upsert_line" path re-indexes the new titles in Lucene.Tests
SefariaBookTitlesTestcovers the prefixed collections and untouched titles.