security(deps-dev): override undici to 7.29.0 and bump brace-expansion - #248
Merged
Conversation
Resolves five open Dependabot alerts on undici (GHSA-4cwx-7wf7-3272, GHSA-8xcm-r25x-g524, GHSA-m8rv-5g2x-5cg5, GHSA-jr45-8vmc-qm54, GHSA-v3r7-h72x-cjcm) and GHSA-rgw5-rvv9-x895 on brace-expansion, which were failing the Dependency Audit job on main. miniflare pins undici to exactly 7.28.0 (including its latest release), so neither npm audit fix nor Dependabot can bump it transitively; the override is scoped under miniflare so jsdom's undici 8.x is unaffected. Drop the override once wrangler ships a miniflare that requires undici >= 7.29.0.
kellenmurphy
enabled auto-merge
August 3, 2026 22:29
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dependency Audit job on
mainis failing on six advisories, none of which Dependabot can fix on its own:npm audit fixcan only propose downgrading wrangler to 4.35.0 and Dependabot's security-update job errors out.What
undici: ^7.29.0(the first patched version). Scoping matters: jsdom resolves undici 8.9.0, a different major, and a global override would downgrade it.npm update brace-expansion→ 5.0.9.The override should be dropped once wrangler ships a miniflare requiring undici >= 7.29.0.
Verification
npm audit: 0 vulnerabilitiesnpx tsc --noEmit,npx eslint . --quiet: cleannpm run coverage: 100% statements/branches/functions/lines