Skip to content

fix(luo_lakeside): rename .PNG files to lower case .png - #4136

Merged
LornaSIL merged 2 commits into
masterfrom
fix/4135-luo_lakeside-png-case
Sep 22, 2026
Merged

LornaSIL merged 2 commits into
masterfrom
fix/4135-luo_lakeside-png-case

Conversation

@mcdurdin

Copy link
Copy Markdown
Member

Fixes: #4135

@mcdurdin

Copy link
Copy Markdown
Member Author

"Ready for review" 😁

@LornaSIL

LornaSIL commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

The .kps will also need the filenames updating. Should I do it for you?
I'm kind of surprised there wasn't a warning about that.

@mcdurdin

Copy link
Copy Markdown
Member Author

Good catch. Yes please, I am afk

Change PNG to png in kps.

@LornaSIL LornaSIL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyousuf please note the update.

@LornaSIL
LornaSIL merged commit 40b59a6 into master Sep 22, 2026
2 checks passed
@LornaSIL
LornaSIL deleted the fix/4135-luo_lakeside-png-case branch September 22, 2026 16:33
@keyman-server

Copy link
Copy Markdown
Collaborator

Thank you for your contribution!

This keyboard has now been published and will shortly be available at: https://keyman.com/keyboards/luo_lakeside.

(There may be a delay of a few minutes for deployment of the keyboard to run across multiple services.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(luo_lakeside): welcome.htm references .png files but files have .PNG extension

3 participants