Conversation
Consolidate references to downloads across various pages and DRY out repeated content. Add support for .pkg downloads when they become available (will be automatic based on content from download server). Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
commented
Sep 23, 2026
Member
Author
There was a problem hiding this comment.
This file was never used
rc-swag
reviewed
Sep 23, 2026
rc-swag
left a comment
rc-swag
left a comment
Contributor
There was a problem hiding this comment.
a query about kmcomp-$version.zip vs exeotherwise
| switch($target) { | ||
| case 'android': return 'keyman-$version.apk'; | ||
| case 'android-engine': return 'keyman-engine-android-$version.zip'; | ||
| case 'developer': return ['keymandeveloper-$version.exe', 'kmcomp-$version.exe']; |
Contributor
There was a problem hiding this comment.
In the old index.php this was kmcomp-$version.zip not exe
Member
Author
There was a problem hiding this comment.
Well spotted. Thank you!
Co-authored-by: Ross Cruickshank <rc-swag@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate references to downloads across various pages and DRY out repeated content. Add support for .pkg downloads when they become available (will be automatic based on content from download server).
Test-bot: skip
Relates-to: keymanapp/keyman#16573