Skip to content

feat: support .pkg extension in /go/download #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcdurdin merged 2 commits into from
Sep 24, 2026
Merged

feat: support .pkg extension in /go/download #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a854461
feat: support .pkg extension in /go/download
mcdurdin Sep 23, 2026
c23229e
chore: use 19.0.291-alpha as changeover to .pkg for mac builds
mcdurdin Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion go/download/_download.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
<?php
/**
*
* Provide static links to executable downloads of Keyman products on various
* platforms.
*
* Usage:
* https://keyman.com/go/download/<PRODUCT>[?tier=<TIER>][&version=<VERSION>]
*
* PRODUCT: kmcomp|keyman-developer|keyman-windows|keyman-mac
* TIER: alpha|beta|stable (default 'stable')
* VERSION: any valid version number (default to latest for tier)
*
* Redirects to the referenced executable, e.g. keyman-18.0.252.dmg for Mac.
*
* This page is referenced by Keyman Developer Server, e.g.
* /go/download/keyman-mac and by Keyman Developer kmc documentation
* /go/download/kmcomp. These paths are rewritten by .htaccess to call into
* _download.php.
*/

require_once _KEYMANCOM_INCLUDES . '/autoload.php';
use Keyman\Site\com\keyman\KeymanComSentry;
use Keyman\Site\Common\KeymanHosts;
Expand Down Expand Up @@ -34,11 +54,14 @@
$MAC_VERSION = $versions->mac->$TIER->version;
}

// epic/mac-config changes the mac installer from a .dmg to .pkg, in version 19.0.291-alpha
$MAC_FILENAME = version_compare($MAC_VERSION, "19.0.291") >= 0 ? "keyman-$MAC_VERSION.pkg" : "keyman-$MAC_VERSION.dmg";

$packages = [
"kmcomp" => ["developer", $DEVELOPER_VERSION, "kmcomp-$DEVELOPER_VERSION.zip"],
"keyman-developer" => ["developer", $DEVELOPER_VERSION, "keymandeveloper-$DEVELOPER_VERSION.exe"],
"keyman-windows" => ["windows", $WINDOWS_VERSION, "keyman-$WINDOWS_VERSION.exe"],
"keyman-mac" => ["mac", $MAC_VERSION, "keyman-$MAC_VERSION.dmg"]
"keyman-mac" => ["mac", $MAC_VERSION, $MAC_FILENAME],
];

if(!isset($packages[$object])) {
Expand Down
Loading