fix(windows): add manual check arg to handlecheck

[rc-swag]

Adds a manual check argument to handlecheck which is now also added to RemoteUpdateCheck. Previously a HandleCheck event in the statemachine was considered to be a manual check, versus via HandleKmShell were auto checks via boot or via kmshell starting Keyman for the first time in a session. However, the HandleCheck event is called when kmshell is run using the -buc command line switch which is used by an external time scheduled event. In the current case it is a timer in the main Keyman app.

Fixes: #15419

@mcdurdin is there a way to have manual test case for this. e.g. finding the request on the server side. Or setting up a local server?

[keymanapp-test-bot]

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

Test Artifacts

• Windows (no artifacts on BuildLevel "build")
  • Keyman for Windows - build : ✅ all tests passed
  • FirstVoices Keyboards for Windows - build : ✅ all tests passed
  • Text Editor (ARM64) - build : ✅ all tests passed
  • Text Editor (x64) - build : ✅ all tests passed
  • Text Editor (x86) - build : ✅ all tests passed

[mcdurdin]

@mcdurdin is there a way to have manual test case for this. e.g. finding the request on the server side. Or setting up a local server?

Yes, we could test this with a local api.keyman.com with a minor tweak to /script/windows/14.0/update/index.php to log the request to a temp file on the server, something like:

  file_put_contents('/tmp/req', print_r($_REQUEST, true));

Run the test, then check the temp file through Docker to see if the right parameters were passed in. This may be outside a normal user test scope though!