Skip to content

fix(developer): address crashes in touch layout editor - #16572

Merged
mcdurdin merged 2 commits into
masterfrom
fix/developer/touch-editor-crashes
Sep 24, 2026
Merged

mcdurdin merged 2 commits into
masterfrom
fix/developer/touch-editor-crashes

Conversation

@mcdurdin

@mcdurdin mcdurdin commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Crashes reported in user testing on #16520.

See-also: #16509
See-also: #16520
Cherry-picked-from: 099d039

User Testing

TEST_DELETE_LAYER: In the touch layout editor, press F12 to open the Developre Console. Add a key with a flick and set the flick's 'next layer' to Shift. Then delete the Shift layer. Verify that no crashes are reported.

.

Crashes reported in user testing on #16520.

* Fix crash selecting layer after deleting a layer (from #16509)
* Fix crash resetting 'next layer' for flicks after layer deletion
  (long-standing issue)

See-also: #16509
See-also: #16520
Cherry-picked-from: 099d039952260e069f61954fc6b29b51b1036960
@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

User Test Results

Test specification and instructions

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot Bot added this to the B19S2 milestone Sep 16, 2026

@rc-swag rc-swag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Meng-Heng

Copy link
Copy Markdown
Contributor

Test Results

  • TEST_DELETE_LAYER (PASSED):
  1. Launch Keyman Developer 19.0.289-alpha-test-16572
  2. In the touch layout editor
  3. Press F12 to open the Developer Console
  4. Add a flick to a key and set the flick's 'next layer' to Shift
  5. Delete the Shift layer
  6. VERIFIED: No crashes reported. The flick's next layer return to (none)

@keymanapp-test-bot keymanapp-test-bot Bot removed the user-test-required User tests have not been completed label Sep 21, 2026
@mcdurdin
mcdurdin merged commit 7f07d42 into master Sep 24, 2026
9 checks passed
@mcdurdin
mcdurdin deleted the fix/developer/touch-editor-crashes branch September 24, 2026 07:03
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.291-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants