Skip to content

fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models 🏠 - #16604

Merged
mcdurdin merged 2 commits into
stable-18.0from
fix/web/13862-retry-networkerror-on-importScripts
Sep 21, 2026
Merged

mcdurdin merged 2 commits into
stable-18.0from
fix/web/13862-retry-networkerror-on-importScripts

Conversation

@mcdurdin

Copy link
Copy Markdown
Member

A deeper workaround is applied in 19.0 (see for example #16565, #16586) but for 18.0, this is an attempt to bypass the constant issue of models failing to load with Chrome 152 and later versions, by retrying on failure.

Relates-to: #13862 (may fix)

User Testing

  • TEST_MODELS_ANDROID: On Keyman for Android, verify that text input and predictive text is working as normal.
  • TEST_MODELS_IOS: On Keyman for iOS, verify that text input and predictive text is working as normal.

…rors loading models

A deeper workaround is applied in 19.0 (see for example #16565, #16586)
but for 18.0, this is an attempt to bypass the constant issue of models
failing to load with Chrome 152 and later versions, by retrying on
failure.

Relates-to: #13862 (may fix)
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added the user-test-required User tests have not been completed label Sep 18, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot added web/ and removed stable labels Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot changed the title fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models 🏠 Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the B19S2 milestone Sep 18, 2026

@jahorton jahorton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible issue - didn't we set Android to auto-reload its host WebView when encountering Web engine errors? Wouldn't that trigger on the first error output below if so?

I should probably double-check whether or not that's still in place.

@jahorton

Copy link
Copy Markdown
Contributor

I'll put together a 🍒 for #16548 to go alongside this; it'll cut off the highly-correlated paired error we've been getting.

@mcdurdin

Copy link
Copy Markdown
Member Author

Possible issue - didn't we set Android to auto-reload its host WebView when encountering Web engine errors? Wouldn't that trigger on the first error output below if so?

I should probably double-check whether or not that's still in place.

Just tested: console.warn is reported through to sentry as a warning but doesn't reload the page.

@Meng-Heng

Copy link
Copy Markdown
Contributor

Test Specs

  1. Keyman 18.0.250-test-16604
  2. XCode iPad Air 11-inch (M3)
  3. Samsung Galaxy A06, Android v15.0

Test Results

  • TEST_MODELS_ANDROID (PASSED):
  1. Launch Keyman with the default EuroLatin (SIL), check to see "Prediction with corrections" is enabled
  2. Start typing and applying predictive text
  3. Apply reversion and using backspace
  4. VERIFIED: No error indications, and work as expected.
  • TEST_MODELS_IOS (PASSED):
  1. Launch Keyman with the default EuroLatin (SIL), check to see "Prediction" & "Corrections" are enabled
  2. Start typing and applying predictive text
  3. Apply reversion and using backspace
  4. VERIFIED: No error indications, and work as expected.

@keymanapp-test-bot keymanapp-test-bot Bot removed the user-test-required User tests have not been completed label Sep 21, 2026
@mcdurdin
mcdurdin merged commit 87e87e1 into stable-18.0 Sep 21, 2026
18 checks passed
@mcdurdin
mcdurdin deleted the fix/web/13862-retry-networkerror-on-importScripts branch September 21, 2026 08:02
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Sep 21, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants