maint: rework PHP error reporting for link tester - #104
Merged
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
commented
Sep 11, 2026
| return "$LINK_RESULT" | ||
| } | ||
|
|
||
| # |
Member
Author
There was a problem hiding this comment.
These could be split into a separate PR if you think that is warranted.
mcdurdin
force-pushed
the
maint/improve-php-tests-add-composer-setup
branch
6 times, most recently
from
September 11, 2026 08:17
510c1ad to
fd8b2ab
Compare
ermshiperete
approved these changes
Sep 11, 2026
| function docker_stop_and_cleanup_composer_container() { | ||
| local COMPOSER_ID=composer-temp | ||
| # copy modified files to mounted volume: | ||
| docker exec $COMPOSER_ID cp composer.lock //var/www/html/ |
Contributor
There was a problem hiding this comment.
Are the double slash required?
Member
Author
There was a problem hiding this comment.
It's a cygwin thing. Needed on Windows, otherwise it prepends a Windows path. Works without issue on other platforms as far as I have tested (might be worth testing on your Linux setup)
Setup a more reliable PHP error reporting mechanism when running link test. This helps to capture PHP error messages as the link checker hits each page, providing some basic runtime validation of the site. KeymanSentry.php: With this new test setup, we no longer force pages to exit with 500 errors if any PHP warning or message is encountered (serious errors will still cause a 500 error as is the default). This makes the link checker faster (no retries needed), as all the messages are reported in the do_test_print_container_error_logs function afterwards anyway. Also add composer setup and teardown functions for manual maintenance of composer packages; these can be run through build.sh on the various sites. Test-bot: skip
mcdurdin
force-pushed
the
maint/improve-php-tests-add-composer-setup
branch
from
September 12, 2026 06:02
fd8b2ab to
7b0361f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup a more reliable PHP error reporting mechanism when running link test. This helps to capture PHP error messages as the link checker hits each page, providing some basic runtime validation of the site.
KeymanSentry.php: With this new test setup, we no longer force pages to exit with 500 errors if any PHP warning or message is encountered (serious errors will still cause a 500 error as is the default). This makes the link checker faster (no retries needed), as all the messages are reported in the do_test_print_container_error_logs function afterwards anyway.
Also add composer setup and teardown functions for manual maintenance of composer packages; these can be run through build.sh on the various sites.
Test-bot: skip
Relates-to: keymanapp/keymanweb.com#209