Skip to content

bug: Displayed contributions don't match calculated contributions #449

Description

@ermshiperete

The contributions displayed on the status site don't always match the calculated contributions (notice the red 1 after "Contributions", but nothing showing up below):

image

This is on a machine with the time zone set to Germany (UTC+2). On a machine with Phnom Penh time zone (UTC+7) one review shows up:

image

The comment in #11535 was made on Friday at 19:03 German time (Saturday 0:03 Phnom Penh).

It looks like contributions are calculated based on Phnom Penh time, but displayed in local time.

It would be good if server and client would agree, i.e. if the client would always display contributions based on the same time zone as the server. This might lead to some contributions showing up on the "wrong" day. The reasoning behind this would be that the days displayed would be Phnom Penh time.

Another solution would be to show the days in local time but for the full sprint (starting at 0:00 Phnom Penh on Saturday and ending 23:59 Phnom Penh on Friday). This would lead to showing 15 days for a sprint for non-Phnom Penh time zones.

Activity

  1. ermshiperete commented on May 27, 2024

    @ermshiperete
    ContributorAuthor

    That might not be the only thing going on. It doesn't explain why PR #11536 isn't considered as contribution which was created on Friday 19:14 UTC+2 (Saturday 0:14 UTC+7). Or maybe that is because it was labeled as A18S2 (previous sprint) when it was created?

  2. added this to the A18S3 milestone on May 29, 2024
  3. self-assigned this
    on May 29, 2024
  4. modified the milestones: A18S3, A18S4 on Jun 7, 2024
  5. modified the milestones: A18S4, A18S5 on Jun 21, 2024
  6. modified the milestones: A18S5, A18S7 on Jul 5, 2024
  7. modified the milestones: A18S7, A18S8 on Aug 2, 2024
  8. modified the milestones: A18S8, A18S9 on Aug 17, 2024
  9. modified the milestones: A18S9, A18S10 on Aug 31, 2024
  10. modified the milestones: A18S10, A18S11 on Sep 14, 2024
  11. modified the milestones: A18S11, A18S12 on Sep 28, 2024
  12. modified the milestones: A18S12, A18S13 on Oct 11, 2024
  13. modified the milestones: A18S13, A18S14 on Oct 26, 2024
  14. modified the milestones: A18S14, A18S19 on Nov 7, 2024
  15. modified the milestones: A18S19, Future on Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    No status

Relationships

None yet

Development

No branches or pull requests

Issue actions