Skip to content

refactor: rename ColorPanel to ColorPanelController #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esphynox merged 1 commit into from
Oct 15, 2026
Merged

refactor: rename ColorPanel to ColorPanelController #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Apps/Keyty/Sources/Keyty/Features/Settings/Keyboard/KeyboardSettingsPane.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import SwiftUI

struct KeyboardSettingsPane: View {
@StateObject private var model: KeyboardSettingsPaneViewModel
@State private var legendColorPanel = ColorPanel()
@State private var legendColorPanel = ColorPanelController()

init(settings: KeyboardVisualizerSettings) {
self._model = StateObject(wrappedValue: KeyboardSettingsPaneViewModel(settings: settings))
Expand Down
6 changes: 3 additions & 3 deletions Apps/Keyty/Sources/Keyty/Features/Settings/Mouse/MouseSettingsPane.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import SwiftUI

struct MouseSettingsPane: View {
@StateObject var model: MouseSettingsPaneViewModel
@State var ringColorPanel = ColorPanel()
@State var iconBackgroundColorPanel = ColorPanel()
@State var iconTintColorPanel = ColorPanel()
@State var ringColorPanel = ColorPanelController()
@State var iconBackgroundColorPanel = ColorPanelController()
@State var iconTintColorPanel = ColorPanelController()

init(
pointerRingVisualizer: PointerRingVisualizer,
Expand Down
5 changes: 3 additions & 2 deletions ...y/Support/Bridges/AppKit/ColorPanel.swift → ...Bridges/AppKit/ColorPanelController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// ColorPanel.swift
// ColorPanelController.swift
// Keyty
//
// SPDX-FileCopyrightText: 2026 Serhii Bykov
Expand All @@ -8,8 +8,9 @@

import AppKit

/// Bridges the shared `NSColorPanel` target-action callbacks to closure-based color-change handling.
@MainActor
final class ColorPanel: NSObject {
final class ColorPanelController: NSObject {
var onColorChange: ((NSColor) -> Void)?

func present(initialColor: NSColor) {
Expand Down
Loading