Repository navigation
fix(plugins): deduplicate recovery warnings and restore baseline coverage - #217
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ZCODE_BUILTIN_PROVIDER_CONFIG_FILEpoints to an unavailable file,zcode plugins validate <name>@<marketplace>starts two app-server processes and prints the same recovery warning twice. Deduplicate identical recovery warnings within each CLI invocation, with regression coverage for both normal and JSON output.The runtime test also skipped its failure control after every normal sync because the recovery patch is required. Generate a temporary baseline with only that patch removed, verify that reapplying it restores the patched runtime, and run the unavailable-override failure assertion unconditionally.
Addresses the two follow-up findings in #207 after #213.
Validation:
bun test test/launcher.test.ts test/app-server-client.test.ts test/plugin-cli.test.ts test/runtime-provider-env-patches.test.ts test/runtime/builtin-provider-env.test.ts— 65 passed, using the locally synced 3.15.1 runtime.bun run typecheck— passed.bun run build:launcher— passed.git diff --check— passed.