Repository navigation
fix(tui): restore slash suggestions from deferred runtime startup - #219
Merged
Merged
Conversation
Contributor
|
pkg-pr-new preview for commit npx --yes https://pkg.pr.new/zcode-app-cli@e92e6b3This preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mcp,/help,/model, and custom-command suggestions with current upstream runtimes: they return commands fromloadStartupOptions()rather than top-level options./mccompletion smoke assertion, and local validation documentation.Validation
bun run typecheck— passedenv -u KITTY_WINDOW_ID TERM=xterm bun run test:unit— 852 passed, 2 skippedbun run test:tui— 31 component + 34 PTY tests passed; the final startup tests also rerun separately (5 passed)bun run test:runtime— 62 passedbun run test:node— 20 passedbun run sync:localandbun scripts/check-runtime.ts— passed against installed Desktop 3.15.3 / runtime 0.16.9env -u KITTY_WINDOW_ID TERM=xterm-256color bun run check:tui— all smoke checks passed, including real-runtime slash completion and built-TUI focus checksgit diff --check— passedEnvironment notes
KITTY_WINDOW_IDremoved; unrelated notification code/tests were not changed.zcode-runtime.lock.jsonpins the Linux release artifact. The lock is unchanged; CI usessync:lockedfor release validation.Manual verification
bun run sync:localon macOS with/Applications/ZCode.appinstalled (otherwisebun run sync:locked).zcode; type/mc,/he, and/modwithout submitting and verify runtime command suggestions appear./mcpand verify the configured server picker opens (or the empty configuration notice appears).bun test test/tui/startup.test.tsandbun scripts/smoke-tui.tsfor isolated and real-runtime regression checks. These use temporary homes and do not make model API calls.