Repository navigation
chore(runtime): adopt ZCode 3.16.2 / runtime 0.17.0 - #225
Merged
Merged
Conversation
- sync zcode-runtime.lock.json to the 3.16.2 linux-x64 deb - re-anchor session model recovery, login defaults, prompt model and SQLite recovery to 0.17.0 - route --model overrides through CliDefaultSelection without persisting a session change - install SQLite write recovery on the single async open path and include softDeleteSession - update tests and docs for the 3.16.2 runtime
Contributor
|
pkg-pr-new preview for commit npx --yes https://pkg.pr.new/zcode-app-cli@2b0be57This preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with |
There was a problem hiding this comment.
🔵 Needs a closer look
Cold-resume model selection needs correction, and the newly pinned binary’s patch integration remains unverified in this review.
1 open issue
What changed in this PR
Updates the CLI to ZCode Desktop 3.16.2 / runtime 0.17.0 and adapts its compatibility patches.
Changes:
- Updates the runtime artifact pin and package version.
- Adapts model selection and SQLite patches to the new runtime.
- Refreshes regression tests and runtime documentation.
| File | Description |
|---|---|
| zcode-runtime.lock.json | Pins the new artifact and checksum. |
| test/sync-runtime.test.ts | Updates model and SQLite patch coverage. |
| test/runtime-sqlite-patches.test.ts | Tests the single store-open path. |
| test/prompt-model.test.ts | Tests transient CLI-default overrides. |
| test/node/sqlite-session-store.test.cjs | Updates initial store-open coverage. |
| src/runtime-sqlite-recovery.ts | Adds soft-delete write recovery. |
| scripts/sync-runtime.ts | Updates model-selection patch anchors. |
| scripts/runtime-sqlite-patches.ts | Adapts timeout and recovery installation. |
| scripts/runtime-shared-oauth-patches.ts | Updates a version comment only. |
| README.md | Documents tool-search modes. |
| package.json | Bumps the package version. |
| LICENSES/README.md | Updates artifact attribution context. |
| docs/THIRD_PARTY_CONTENT.md | Updates artifact references. |
| docs/SQLITE_CONCURRENCY.md | Documents revised SQLite initialization. |
| docs/DEVELOPMENT.md | Updates verification and version guidance. |
| docs/CONFIGURATION.zh-CN.md | Refreshes runtime and audit references. |
| docs/CONFIGURATION.md | Refreshes runtime and audit references. |
Review effort: Balanced
| // persisting a session model change. | ||
| const switchAnchor = /([A-Za-z_$][\w$]*)\.cliDefaultSelection&&!([A-Za-z_$][\w$]*)\?\.transient\?/u.exec(runtime); | ||
| if (!switchAnchor) throw new Error("ZCode runtime is incompatible with the prompt model patch (cli-default selection anchor missing)."); | ||
| const insertion = `let ${marker}=process.env.ZCODE_CLI_PROMPT_MODEL;if(${marker})await ${anchor[1]}.setModel(${marker},{transient:true,cliDefault:true});`; |
Contributor
|
pkg-pr-new preview for commit npx --yes https://pkg.pr.new/zcode-app-cli@1053f22This preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the ZCode Desktop 3.16.2 stable artifact (runtime CLI 0.17.0) and aligns the compatibility patches with the new runtime. This targets 3.16.2 only; the previous dual-path/legacy anchors were removed.
Release info:
Release v3.16.2(2026-10-19). Lock artifact:ZCode-3.16.2-linux-x64.deb;bun run syncverified its SHA-512 against the stable manifest.Runtime changes handled
runtime 0.17.0adds--toolsearch-mode(auto|native|local|off, defaultoff).SqliteSessionStorenow exposes a singlestatic open()path; the synchronous constructor and the separate migration path are gone. Migrations are checksum-validated and create a backup.CliDefaultSelectionforcli-defaultprompt/TUI admission.setModel/setThoughtLevelroute non-transient changes there.softDeleteSessionstore method.restorePersistedModelSelectionnow mirrors the saved selection into the CLI default.Patch updates (no legacy fallback)
session-model-recovery: re-anchored the restore tail; the prompt boundary now readscliDefaultSelectionfirst, so a replacement model chosen in the TUI clears a broken saved selection.login-model-defaults: re-anchored thecliDefaultSelectionswitch ternary.prompt-model:--modelnow callssetModel(model, {transient:true, cliDefault:true})and the session facade routes it toCliDefaultSelection, so the override applies without persisting a session model change.sqlite-busy-timeout/sqlite-write-recovery: singleopen()anchors; 10 s steady-state timeout after migration; write recovery installed on the constructed store.softDeleteSessionadded to the SQLite replayable-write allowlist.http-no-content,bigmodel-oauthandcli-help-contractremain required verification points and reportalready_presenton 3.16.2.Version
package.json:3.16.2-37zcode-runtime.lock.json: 3.16.2 linux-x64 debvendor/extraction.json(gitignored, rebuilt bysync): app 3.16.2 / runtime 0.17.0, 29 applied + 3 already-present patchesValidation
bun run sync->zcode-app-cli@3.16.2-37with runtime0.17.0bun run typecheck-> passbun run check-> passbun run test:unit-> 876 pass, 2 skipbun run test:runtime-> 74 passbun run test:tui-> 35 passbun run test:node-> 20 pass (Node 26.4.0,busy_timeout=10000)bun run test:all-> passbun run check:tui-> all PTY smoke checks passpkg-pr-new
CI runs on this PR. After it succeeds, the preview workflow can publish the package; you can also comment
/pkg-pr-newon this PR to publish the preview explicitly.