Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Reviewed and merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Resolve migrated workbook display names from the existing workbook metadata catalog when the source Notebook has no explicit metadata.name. Precedence is explicit embedded name, exact matching catalog title, then filename stem. Missing catalogs/entries retain fallback behavior; malformed or ambiguous catalogs fail explicitly. Native reviewed display names, workbook IDs, filenames, queries and release versions are unchanged.
Reason
Prevent filename-style names such as MicrosoftDefenderForIdentity appearing in Defender when a readable catalog title already exists. Packaging continues to consume xdrMetadata.displayName without changing its contract.
Testing
Eight focused tests passed, including filename-only catalog paths. Broader packaging tests encountered the existing clean-publication gate; no live deployment claimed.
Dependency
Stacked on kingwil/toolkit-reviewed-workbook-updates (upstream oferInbar#9). This PR contains only title-resolution changes and focused tests/docs.