Skip to content

chore(deps): remove the unused npm devDependency - #1618

Merged
hakshu25 merged 1 commit into
mainfrom
chore/remove-npm-devdependency
Oct 21, 2026
Merged

hakshu25 merged 1 commit into
mainfrom
chore/remove-npm-devdependency

Conversation

@hakshu25

@hakshu25 hakshu25 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Why

The npm devDependency was added in #1170 so that publishing would run with npm 11.5.1 or later, which trusted publishing requires. pnpm publish runs npm from a temporary directory and does not pick up the copy in node_modules, so since #1177 the release workflow installs npm globally and publishes with that one.

No script uses the devDependency anymore. It is still installed on every pnpm install, and Renovate keeps opening update PRs for it (for example #1543) that have no effect on the release.

What

Removes npm from the devDependencies. The release workflow keeps publishing with the npm 11 it installs globally, so the published package and the release process do not change. Also removes the license check exception that only covered npm, because no package named npm remains in the dependency tree.

Implementation decisions
  • The npm@11 pin in the release workflow stays as it is. Whether to move publishing to npm 12 is a separate decision from removing an unused dependency.

How to test

pnpm install --frozen-lockfile
pnpm why npm          # prints nothing
pnpm license:analyze
pnpm build
pnpm lint
pnpm typecheck
pnpm test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

🤖 Generated with Claude Code

The npm devDependency was added in #1170 so that `pnpm publish` would
run with npm >= 11.5.1 for trusted publishing. `pnpm publish` spawns
npm from a temporary directory and does not pick up
`node_modules/.bin/npm`, so the release workflow has installed npm
globally since #1177. No script references the devDependency anymore.

Also drop the license-manager exception that only covered npm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hakshu25
hakshu25 requested a review from a team as a code owner October 20, 2026 09:21
@hakshu25
hakshu25 requested review from chihiro-adachi and withfuturesky09-ui and removed request for a team October 20, 2026 09:21
@hakshu25 hakshu25 self-assigned this Oct 20, 2026
@hakshu25
hakshu25 requested a review from shabaraba October 20, 2026 09:28
@hakshu25
hakshu25 merged commit 99c36e4 into main Oct 21, 2026
59 of 60 checks passed
@hakshu25
hakshu25 deleted the chore/remove-npm-devdependency branch October 21, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants