Repository navigation
chore(deps): remove the unused npm devDependency - #1618
Merged
Merged
Conversation
The npm devDependency was added in #1170 so that `pnpm publish` would run with npm >= 11.5.1 for trusted publishing. `pnpm publish` spawns npm from a temporary directory and does not pick up `node_modules/.bin/npm`, so the release workflow has installed npm globally since #1177. No script references the devDependency anymore. Also drop the license-manager exception that only covered npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hakshu25
requested review from
chihiro-adachi and
withfuturesky09-ui
and removed request for
a team
October 20, 2026 09:21
shabaraba
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The npm devDependency was added in #1170 so that publishing would run with npm 11.5.1 or later, which trusted publishing requires.
pnpm publishruns npm from a temporary directory and does not pick up the copy innode_modules, so since #1177 the release workflow installs npm globally and publishes with that one.No script uses the devDependency anymore. It is still installed on every
pnpm install, and Renovate keeps opening update PRs for it (for example #1543) that have no effect on the release.What
Removes npm from the devDependencies. The release workflow keeps publishing with the npm 11 it installs globally, so the published package and the release process do not change. Also removes the license check exception that only covered npm, because no package named npm remains in the dependency tree.
Implementation decisions
npm@11pin in the release workflow stays as it is. Whether to move publishing to npm 12 is a separate decision from removing an unused dependency.How to test
Checklist
pnpm lintandpnpm teston the root directory.🤖 Generated with Claude Code