Repository navigation
fix: restrict form layout field types to the API contract - #584
Draft
owenshen0907 wants to merge 1 commit into
Draft
owenshen0907 wants to merge 1 commit into
owenshen0907 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #552. Form layout validation currently accepts
GROUP,SUBTABLE,STATUS,STATUS_ASSIGNEE, andCATEGORYas fields inside a row. Invalid layouts reach kintone and produce an opaqueCB_VA01error.What
Restrict the shared field schema to the 26 types documented for Update Form Layout and Get Form Layout. Top-level group and subtable layouts remain supported.
Regressions cover the documented types, invalid types in nested layouts, group-content stripping, and the update input/get output schemas.
How to test
pnpm test --run: 826 tests pass.pnpm typecheck,pnpm lint,pnpm build,pnpm check:mcpb, andpnpm license:analyzepass.Checklist
pnpm lintandpnpm teston the root directory.AI assistance was used for this contribution.