Skip to content

main red: test_bare_session_handle_guard flags test_kas_token_refresh_recovery.py:245 #39261

Closed

Description

@iamwhatever

Main is red on every PR's Backend Tests shard that runs test/test_bare_session_handle_guard.py::test_no_test_builds_a_bare_session_handle_directly.

Failing node id: test/test_bare_session_handle_guard.py::test_no_test_builds_a_bare_session_handle_directly

Log excerpt (main 12d8a9c, seen on PR #36630):

AssertionError: Build a constructor-less AcpSessionHandle with `from session_handle_helpers import bare_session_handle`, not __new__:
    test_kas_token_refresh_recovery.py:245

Cause: #38996 added the guard and moved every bare handle onto bare_session_handle. #38978 landed afterwards with a new AcpSessionHandle.__new__(AcpSessionHandle) in _governance_off_handle in test/test_kas_token_refresh_recovery.py. Each PR passed on its own; together they fail.

Fix: build that handle with bare_session_handle(_SID).

Activity

  1. added
    tier:T1Bug: behaviour does not match intent; fix keeps the design
    on Nov 18, 2026
  2. iamwhatever commented on Nov 18, 2026

    @iamwhatever
    ContributorAuthor

    Fix in #39262 (one-line test change: bare_session_handle(_SID)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tier:T1Bug: behaviour does not match intent; fix keeps the design

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions