Repository navigation
Conversation
A malformed command or script selector was silently erased during manifest parsing, changing the cron into a default-agent job. Record the type violation so validation rejects the manifest while preserving null as the supported absent spelling. Refs kirodotdev#9895
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound fix mirroring the established Watch
[DESIGN-REVIEWED] 2baef83 |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of All lenses check out on the base code: the fix reuses the existing First-Principles-Verdict: CONCERNS The new tests splice into an existing test: Not justified as shipped
What this change shipsInventory (5 items) — 4 justifiedIntent: stop a non-string cron
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 2baef83 |
|
Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with failing CI. I assessed the blockers and they are resolvable. I will push fixes directly to this branch as a co-author. Assessment: move the new selector tests outside the existing enabled test, retain its absent-key assertions, rebase, and re-run focused manifest tests. If you prefer no automated changes, add the pr-no-autofix label. |
|
Thank you for this fix, @leonlaiyc! 🙏 Your change has landed as an in-repo replacement PR, #16420, which is now fully green and ready to merge. The original PR was branched from a fork, which blocked the merge path, so we re-opened the identical change on a branch in this repository and resolved a small docs conflict with current Your commit keeps its original authorship — your name stays in the git history on #16420 ( Closing this one in favour of #16420. Thanks again for the contribution! |
Problem / Motivation
An app manifest cron with a present non-string command or script selector is currently coerced to an empty string. The manifest then validates and the scheduler sees neither execution selector, so the job falls through to the default-agent mode and runs its message instead of rejecting corrupted input.
Why it matters
A malformed non-string cron
commandorscriptis currently accepted and coerced into absence. The scheduler can then silently run the job in default-agent mode instead of rejecting corrupted manifest input, changing execution semantics rather than merely emitting a validation warning.What changed
Tests
Collision check
No open PR addresses cron selector typing or issue #9895. PR #9907 also edits apps/manifest.py, but only adds the unrelated append-only event-log contribution schema in distant sections; it does not touch CronEntry parsing or validation.
Manual verification
N/A — manifest parsing and the admission error are deterministic unit-level contracts.
Related Issues
Closes #9895.
Pattern harvest
Rule candidate: manifest execution selectors that are present and non-null must be type-checked before any normalization that can turn them into absence. The focused cron tests pin both command and script.
Checklist
Contribution License Agreement
Generated with Codex.