Repository navigation
Conversation
|
Intent: Make one session’s Set a goal draft converge to the latest user edit across desktop and mobile while preserving the existing offline local fallback. |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The server-side compare-and-set with tombstones is the right shape, and the only reader of the removed Notes
[DESIGN-REVIEWED] 7e75a24 Description read[DESCRIPTION-READ] fb928d645ecfc3c79d797d9267e109ee2af208b43fb9a4b4848dd97d6092dcc9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 3 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/dashboard/handlers/autonudge.py:683 -- Draft snapshots expose credentials to Shared Crew teammates
BLOCKING -- src/kiro_crew/dashboard/handlers/autonudge.py:1298 -- Start’s draft fence releases before the loop commits
BLOCKING -- website/src/components/AutoNudgePopover.tsx:510 -- A lost Clear response lets the cleared goal return after reload
[BLOCK-MERGE] 7e75a24 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F3: Low-harm, visible, and needs a user action to cause damage, so it's downgraded. The real fix needs new server-side state and coordination between modules.
[ADJUDICATION] 7e75a24 total=1 uphold=0 downgrade=1 [ADJUDICATION-FENCED] 7e75a24 fenced=2 flagged=0 |
First Principles Review (Opus 5.5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: Start on the goal form now waits for a server-confirmed save, and the form is read-only on open. The description itself says "Maintainers may prefer otherwise". Notes
What this change shipsInventory (8 items) — 5 justifiedIntent: a person editing a goal on desktop and mobile always starts the latest confirmed text, and doesn't lose an edit when sync fails. ADDITION.
Blockersproduct-shape change without accepted RFC: default gating of goal Start and of goal-form editing — items 3, 4 [FIRST-PRINCIPLES-REVIEWED] 7e75a24 Description read[DESCRIPTION-READ] 2147e7db19276e49555228c50075a3d49d12b06ed16b6459a7d6665249dd4d84 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
6fe8200 to
f5ccc36
Compare
|
self-added: yes
Fixed in |
|
self-added: yes
Fixed in |
|
self-added: yes
Fixed in |
Security Scope Review (fork) — ✅ PASSWhich legitimate operations does adjudicated, zero confirmed regressions Scope-Verdict: PASS Reason: The tightening adds one new directory, TIGHTENING: ADJUDICATED: 14 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix and windows, plus one UNADJUDICATED: The tightening is in the agent file-tool path gate. A tool's resolved path goes through
Neither [SCOPE-REVIEWED] 7e75a24Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. |
f5ccc36 to
d7369c8
Compare
|
Disposition for an earlier head, kept for the record (no longer a ledger record):
|
|
Disposition for an earlier head, kept for the record (no longer a ledger record):
|
|
Disposition for an earlier head, kept for the record (no longer a ledger record):
|
|
Disposition for an earlier head, kept for the record (no longer a ledger record):
|
|
Disposition for an earlier head, kept for the record (no longer a ledger record):
|
|
d7369c8 to
03b45aa
Compare
|
|
|
|
Rebased onto main
|
|
self-added: yes
|
|
self-added: yes
|
|
Pushed f467651, rebased onto main
|
|
self-added: yes
|
|
Pushed be5528c, rebased onto main
|
|
Pushed 1f3c6bc, rebased onto main What users will notice:
What changed:
Size, counted the way Every invariant the retrospective kept has a test: the server compare-and-set, content compare, tombstones and Start check; the open check that never writes; the conflict notice and its actions; the Clear deadline; the error notice with Retry; the shared message limit, body parser and sandbox fence; and every catalog string. The full frontend suite passed on the narrowed code, apart from 10 files that fail the same way on main on this host. After the rebase, the affected frontend tests, docs lint, feature map, i18n check and goal-draft server tests pass again. |
|
self-added: yes
|
|
Pushed 2070b29, rebased onto main Known edge, unchanged: an unconfirmed Clear is held in memory only, so a reload, or reopening a paused loop's popover, shows the server's current state again. |
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
|
Pushed f2ec672, rebased onto main
Two decisions for the maintainers:
|
|
self-added: yes
|
|
Pushed e7b249e, rebased onto main
The two decisions asked of the maintainers in the earlier note still stand. |
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
|
Pushed 0387bc5 for GPT's upheld finding on e7b249e ( The E2E (stub ACP backend) failure on e7b249e was the suite reaching its 1,200 s bound with every test passing; it matches the CI runner slowdown other PRs have shown since 2026-11-04 23:05Z, docs-only ones included. The maintainer questions in the f2ec672f note still stand. |
|
Pushed 3cefeb8, rebased onto main |
|
self-added: yes
|
|
GPT's review of 3cefeb8 (the rebase) raised two new findings, both in code that has not changed since earlier rounds:
Both are small. The fix for the first is ready on a local branch: the old copy is deleted only after the new one is stored, with a test that fails on 3cefeb8. Both go into the next round once the questions in this earlier note are answered, or now if a maintainer prefers. |
|
Pushed 67f388e, a conflict-only rebase onto main
No other code, test or description changed. The two fixes described in the earlier note are not in this push. |
Code change approver recommendation: A person should decideWhy: the decider raised 1 possible problem and estimates a 60% chance that this change introduces a defect; a person should check it. The server design is sound. The store is owner-only, compare-and-set under a file lock, uses tombstones, prunes without evicting the record just written, and adds a version fence on Start. The client is complex and well tested. But the PR ties Start on every inactive goal form to the new draft store: any store failure (including the reachable 1 MiB cap, which pruning never reduces) disables Start, where main always allowed it. That, plus the 5 s read-only open, changes the defaults of a first-class loop. The PR says maintainers may prefer otherwise, and the decision the repo's lens-9 rule requires has not been recorded (First Principles BLOCK, needs-author-decision label). The head also had merge conflicts and no CI test runs at decision time. I recommend requesting changes: record the decision, or fail toward Start with the server fence when the store is unavailable and prune by size. Things to check (possible problems the decider raised; at this confidence many turn out to be fine):
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Pushed db21ad0, a conflict-only rebase onto main
No other code, test or description changed. The two fixes described in the earlier note are not in this push. |
|
Pushed c8b380e, rebased onto main
No other code, test or description changed. |
The inactive Set a goal form kept its draft only in browser storage, so
desktop and mobile could show different executable goal text for the
same session. Add an owner-only canonical goal-draft store behind
GET/PUT /api/autonudge/draft/slot/{slot_key}, masked from every agent
sandbox and refused by the file tools, and check the popover against it
on open with a five-second bound, the form read-only meanwhile.
Start runs only the text the store confirmed: it stays disabled during
that check, while a save is pending or in flight, and whenever the form
differs from the last confirmed answer. A draft the check shows becomes
the form's pristine baseline. Start's create request keeps the existing
goal fencing unchanged. Clear writes a timestamped tombstone after the
loop record is gone and closes once it is canonical. Pause, Play, the
cycle count, the Done state and changed-field saves keep their current
behaviour; loop writes still send the typed values and adopt what the
loop service stored, while a saved draft is held to the store's bounds.
GoalDraftStore._read_unlocked joins the link-screen baseline as a site
that refuses every link: it reads a gateway-owned file in a directory
no sandboxed process can see, and it never traverses a link it found.
|
Pushed 7e75a24, rebased onto main
No other code, test or description changed. |
Problem / Motivation
Goal: Keep inactive Set a goal drafts consistent across devices so only the latest confirmed text can start autonomous work and failures remain recoverable.
The form stored executable goal instructions only in browser-local storage. The same session could show different drafts on desktop and mobile, and a stale copy could overwrite the latest edit.
Why it matters
Pressing Start turns this text into unattended agent instructions. A stale or silently lost draft can launch the wrong goal, while a sync or clear failure must leave the latest local edit recoverable.
Not a goal
What changed (motivation → approach → change)
Inactive goal forms share an owner-only canonical server record behind
GETandPUT /api/autonudge/draft/slot/{slot_key}. Every write carriesbase_updated_at, the version its edit was made on; the store compares it under the write lock and returns409 goal_draft_conflictif another write won. A re-sent save whose content the record already holds answers that record, so a save whose answer was lost is not a conflict. A Clear is a tombstone, so a stale device cannot bring the goal back. Capacity pruning never evicts the record a write just stored. On a conflict, Use newer goal (Keep it cleared after a Clear) shows the stored record and writes nothing; only Replace with my text replaces it, on a freshly read base.The browser keeps one record per slot: the latest edit (or Clear) the server has not confirmed, and the version it was made on. A confirmed save drops it. There is no server migration route: a draft from before this change uploads once into an empty server slot as a normal save, then is deleted.
What users notice:
Both defaults are deliberate: Start waits for the confirmed save so unsaved text can never start, and the form is read-only during the bounded open check so typing cannot race it. Maintainers may prefer otherwise.
The create names the version the form shows; the server answers the same 409 if another device saved other text since. Clear reads the canonical stamp before removing the loop, so a second device's tombstone is accepted. It registers before its DELETE; an editor the
removedframe remounts first waits for it, for at most 5 s. A DELETE with no answer, timed out or dropped, leaves the failed Clear with Retry, which re-sends it; until one is answered, the cleared goal is never restored and cannot start. Goal text is clamped toMAX_NUDGE_MESSAGE_CHARS. Sync failures show localizedErrorNoticecopy beside Retry, and Start's description names that notice.docs/feature-map/README.mdanddocs/system-specs/modules/learn-cron-dashboard.mdsrc/kiro_crew/dashboard/handlers/autonudge.py,server_runtime/mcp_routes.py, andsrc/kiro_crew/goal_drafts.pysrc/kiro_crew/constants.pyandsrc/kiro_crew/autonudge_authz.pysrc/kiro_crew/sandbox_leaves.py,src/kiro_crew/sandbox_precreate.py, andsrc/kiro_crew/security/paths_lists.pytest/link_screen_sites.pyandtest/test_*.py_MCP_TABLE_ROWS332 to 335: aiohttp'sHEAD, two lazy imports), security counters and sandbox behavior.website/src/components/AutoNudgePopover.tsx,website/src/utils/goalDrafts.tsanduseGoalDraftSync.ts(its sync hook)website/src/i18n/locales/website/src/test/Backwards compatibility
Compatible: a browser draft from before this change fills an empty server slot once (a slot that already holds a record keeps it), live loops keep current-main behavior, and an unavailable server leaves the local edit visible instead of starting stale text.
Tests
test_goal_drafts.py,test_goal_drafts_lost_answer.py,test_goal_drafts_start_fence.py): a write on a stale base is a 409 that writes nothing; a re-sent identical save or Clear answers the stored record; a tombstone refuses an older-base write; capacity pruning keeps the record just written (fails if the prune may evict it); a Start naming an older version over other text is refused; one message bound for the store and both loop authorizers; invalid and unparseable bodies erase nothing.goalDrafts.test.ts: one pending edit per slot with its base; a confirmed save drops it and an edit typed meanwhile moves to the answer's version; a conflict or failure keeps it; writes per slot go out one at a time; the pre-sync draft is read and deleted per slot; requests end at the 5 s bound.AutoNudgePopover.<name>):goalSync(read-only check, Start disabled with Saving… through the debounce and the save, then runs the confirmed text, opening never writes, Updated, one-shot legacy upload, failed save or read keeps the edit with Retry, close flush then reopen),goalConflictActions(both actions, no Retry, Use newer goal writes nothing, a 409 never changes the editor),goalLostAnswer(a committed save whose answer was lost confirms on Retry or reopen),goalStartFence,goalClearandgoalClearDeadline(tombstone base, Retry, remount waits read-only, stalled DELETE ends at 5 s; Retry re-sends a timed-out or dropped DELETE, before or after the server deleted, and an unanswered re-send keeps the notice).i18n:check, docs lint, the feature-map test and the static gates passed, host-only failures aside.Manual verification
Synthetic-data screenshots below.
Screenshots / video
Related Issues
Part of #9052 (review follow-up)
Checklist
Contribution License Agreement
Contributions are accepted under the repository's Apache 2.0 license.