Skip to content

feat: open worker sessions within crew members - #10165

Closed
Zedmor wants to merge 1 commit into
mainfrom
feat/member-inline-sessions
Closed

Zedmor wants to merge 1 commit into
mainfrom
feat/member-inline-sessions

Conversation

@Zedmor

@Zedmor Zedmor commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Opening a crew member's worker session takes the user away from Crew Members and into Sessions.

Why it matters

Users need to follow a conductor's work and return to its conversation without leaving the member roster.

What changed (motivation → approach → change)

Worker sessions appear in an expandable Sessions list beneath their crew member. Selecting a session in the roster or Crew summary opens its conversation on the same page. A member breadcrumb returns to the member's standing DM. The conversation offers Load earlier messages without leaving Crew Members, including workers previously visited in Sessions.

Files, Artifacts, Terminal and Side Chat follow the selected conversation. Drafts and panel tabs remain separate for each session. A worker opens only when the member thread and a current slots snapshot confirm its ownership. Closed or unrelated session links show an unavailable message.

Action Before After
Open a member's worker 🟥 Navigate to Sessions 🟩 Open inside Crew Members
Return to the member 🟥 Navigate back to Crew Members 🟩 Select the member breadcrumb

🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged

Tests

Regression coverage checks nested session grouping, disclosure behavior, direct links, ownership validation, closed sessions, unread state, Files and Terminal project selection, Side Chat isolation, and mobile Back navigation.

  • 172 focused frontend tests passed, covering MembersPage, Side Chat, filters, ChatPane draft recovery, and bounded/earlier history.
  • TypeScript/Vite build, ESLint, i18n checks, rendered i18n comparison, bundle size/cycles, Python lint/type checks, and documentation checks passed.
  • Chromium verification passed in desktop light/dark themes and at 390px/320px; a 120-message worker verifies the initial 50-message read and inline earlier-history load.
  • Electron suite: 1,849 passed, 1 skipped. Full website suite is still running; its result will be updated here.
  • Local full backend suite could not complete on this host: NotImplementedError: atomic no-replace rename is unavailable during fixture setup. Interrupted after 2,147 passed / 24 skipped / 151 setup errors. Reproduced the same error on clean origin/main (707b8aef2) with test_member_memory_api.py::test_internal_chat_middleware_refuses_member_before_slot_creation. No backend source is changed.

Manual verification

Checked the isolated branch in Chromium on desktop in light and dark themes, and at 390px and 320px. Verified session switching, collapse/expand, draft restoration, and mobile Back navigation with no horizontal overflow.

Screenshots / video

Requested screenshot from the running Crew Members page:

Conductor sessions displayed and opened within Crew Members

Isolated branch in the light theme:

Worker conversation in Crew Members, light theme

Mobile roster and conversation

Expandable worker sessions in the mobile roster

Worker conversation on mobile

interaction.webm

Related Issues

no linked issue: requested directly while trying the Crew Members page.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Zedmor
Zedmor requested review from a team and iamwhatever September 11, 2026 18:34
@Zedmor

Zedmor commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Display attributed worker sessions beneath each crew member and open them, including earlier messages, inside Crew Members. Preserve per-conversation drafts, panels, and mobile Back navigation.

Not a goal: Change worker creation, conductor behavior, permissions, task boards, or the standalone Sessions page.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Worker view tears down on every reconnect: display continuation, not just initial mount, is gated on a current slots snapshot member DMs don't require.

Watch

confirmedSlot = memberConfirmed && (!urlSession || slotsLoaded) means a WS reconnect — which the page's own prior comment says "drops slotsLoaded but keeps the pre-disconnect slots" — blanks an open worker transcript to the "opening thread" spinner and remounts it (scroll position lost) when the fresh frame lands, while the member DM path deliberately keeps rendering through the same window. The feature's core use is watching a long-running worker, exactly the situation that spans gateway restarts and sleep/wake reconnects. The ownership guard only needs a current snapshot to admit a URL; a binding already confirmed this visit could be held through the gap and re-verified when the frame arrives, without weakening the untrusted-URL boundary.
Clears when: an already-confirmed worker binding is held while slotsLoaded is false (torn down only if the fresh frame omits or reattributes the slot), or a manual reconnect check shows the open worker transcript does not visibly unmount.

[DESIGN-REVIEWED] 84a3ee2

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The summary row's jump to the full Sessions page is replaced, not supplemented — confirm the requester wanted no remaining route to a worker's full chat view (Changes/Pins stay withheld on /members).

Not justified as shipped

  • Item 8 — undeclared: workers get the Steer/Queue split (busyMode={urlSession ? 'split' : 'steer-only'}) while the description never mentions send behavior; derived from the deleted comment's own rationale ("The main chat and split view keep the split button").
  • Item 9 — undeclared: the edit-member pencil is hidden while a worker is displayed ({!urlSession && <Btn …member-edit-name-button>}); the description never mentions it.

What this change ships

Inventory (10 items) — 8 justified

Intent: let a user follow a member's worker sessions and return to its DM without leaving Crew Members — an ADDITION.

  1. Expandable Sessions list with live worker rows beneath each roster member — justified
  2. Worker opens in place at /members?member&sid; summary row no longer navigates to /chat?sid= — justified
  3. Member breadcrumb in the header returns to the standing DM — justified
  4. Embedded workers load earlier messages inline (reuses warmSlotCache/loadOlderMessages/EarlierMessagesBar, all pre-existing) — justified
  5. Files, Artifacts, Terminal and Side Chat follow the selected conversation; drafts/tabs stay per session — justified
  6. Worker deep links mount only after member-thread confirm plus a created_by slot match; otherwise an unavailable message — justified
  7. Only the displayed conversation is marked read — justified
  8. Workers offer Steer/Queue while the member DM stays steer-only — undeclared, rides along; derived from the retained steer-only rationale
  9. Edit-member pencil hidden while a worker is displayed — undeclared, harm-free rider
  10. Mobile: opening a worker pushes a detail entry; session switches replace it, Back returns to the roster — justified

[FIRST-PRINCIPLES-REVIEWED] 84a3ee2

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — 🔴 changes requested (blocking)

GPT 5.6 found at least one blocking issue that must be resolved before merging 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b. Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- website/src/pages/members/MembersPage.tsx:2088 -- Worker view adds a third action to the mobile header

{urlSession && ( … <Btn
320px worker view -> urlSession && !beside renders roster Back, member breadcrumb, and panel toggle together -> the header exceeds the two-action cap and compresses the session title.
Anchor: max-two-buttons-per-row
Fix: Move the member breadcrumb to a separate row below the header.

[BLOCK-MERGE] 84a3ee2
[GPT-REVIEWED] 84a3ee2

Adjudication (Opus 4.8) — is blocking on each finding proportionate?

F1 anchors to max-two-buttons-per-row in website/AUTOSDE.yaml:301-302, which carries blocking: true. The finding names a diff-added worker view (urlSession breadcrumb Btn at MembersPage.tsx:2088-2098) sitting in the header alongside the roster Back button (member-back, 2046) and the panel toggle (member-panel-toggle, 2128-2140) when !beside. The rule's flag is authoritative and outranks weighing.

Harm rung: N/A — anchored to a blocking AUTOSDE rule.
Conditions confirmed: blocking: true at website/AUTOSDE.yaml:302; three sibling action controls in the header at MembersPage.tsx:2046, 2088, 2128, the breadcrumb being diff-added by the worker-session feature and thus growing the row (rule's grandfather clause, AUTOSDE.yaml:329-332, does not apply).
Real fix cost: moot — the rule's flag outranks weighing.

[ADJUDICATION] 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b total=1 uphold=1 downgrade=0
UPHOLD F1 website/src/pages/members/MembersPage.tsx:2088 reason=autosde-blocking-rule
[GPT-ADJUDICATED] 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🔴 BLOCK

UX-level review of 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: BLOCK

Cannot evaluate: missing screenshots of the inline "Load earlier messages" bar and the "Session not found" state in embedded worker conversations.

Evidence gaps

  • The inline earlier-history control (inlineHistory → EarlierMessagesBar in ChatPane.tsx), a stated main-path feature ("offers Load earlier messages without leaving Crew Members"), appears in none of the four screenshots — both worker shots show 2-message sessions. Close with a still of the 120-message worker the Tests section says was verified, ideally including its failed/retry notice.
  • The member-session-unavailable state (pages.chatPage.session_not_found replacing the center column) appears in no screenshot. Close with a still of a closed/unrelated sid link.

Watch

  • Duplicate lists: the new roster Sessions list and the Crew summary's "Sessions it's driving" now show the identical seven rows with identical badges side by side on desktop (shot-02); the blind reader: "they look like two views of one list." Every desktop visit, mild but persistent confusion — consider collapsing or differentiating the panel list when the roster list is visible.
  • The ← radar member breadcrumb (member-session-back) — the PR's named return path — was never recognized as clickable: the blind reader described it as header text ("radar's picture, 'radar / Triage: seven fresh candidates'") in all three shots showing it. The roster row still returns, so this is friction, not failure; give the breadcrumb a visible button affordance.

[UX-REVIEWED] 84a3ee2

@CrysisDeu CrysisDeu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to aim for chatting with a AI crew member without needing to know what the session it's driving

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b — this comment is updated in place on each push.

Review details

No findings.

The one candidate is the sessionUnavailable branch on MembersPage.tsx:2216 rendering the session_not_found string in a muted role="status" div instead of ErrorNotice. The blocking rule errors-use-error-notice turns on only for "the outcome of something that FAILED" and explicitly excludes "empty states … or status text about something that has not failed," deciding "by where the VALUE comes from." Here the value is not sourced from a rejected request, exception, or query error: sessionUnavailable = !!urlSession && memberConfirmed && slotsLoaded && !selectedSession fires precisely when the member-thread POST succeeded and a real slots frame arrived but no worker matches the deep-linked sid — a not-found/empty condition, not a failed operation. The page already routes its genuine failures (activeCollision, activeThreadFailed) through ErrorNotice, so the author's distinct treatment of this deep-link miss as status is a defensible reading of the rule's carve-out. ChatPage's sidError classifying the same string as an error is a per-surface author decision, not proof the value here is a failure. (c) cannot be re-derived as a definite rule violation above the confidence bar; dropped.

[OPUS-REVIEWED] 84a3ee2

Verdict parsed from the review's SHA-scoped output markers for commit 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 84a3ee27bb208b2e986a2dc1d3e00ad0736bc04b: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Sep 11, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Not approving for now: the branch has merge conflicts with main; please rebase and we'll take another look.

@dwu96 dwu96 added needs-pr-triage PR scanner: awaiting automated triage and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 16, 2026
Show each member's worker sessions beneath its roster entry and open
them in the same page. Keep conversation drafts and panel tools scoped
to the selected session, with verified ownership for direct links.
@bolichen97
bolichen97 force-pushed the feat/member-inline-sessions branch from b9e1315 to 84a3ee2 Compare September 19, 2026 05:37
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 19, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main cff7de5416 by a maintainer to resolve merge conflicts. Old head b9e1315ab7, new head 84a3ee27bb.

Conflicts resolved (only these files were hand-merged):

  • docs/feature-map/README.md — combined the worker-session navigation documentation with main’s Wake sources and member schedule creation documentation/API entries.
  • website/src/components/ChatPane.tsx — retained main’s virtualized transcript and session title control, integrating the PR’s inline earlier-history loading, error/retry handling, and focus return through the current scroller ref.
  • website/src/pages/members/MembersPage.tsx — retained main’s visibility/focus gating, cross-window read relay, and viewed-thread cleanup while binding them and the read timestamp to the actually displayed, confirmed chat slot.

Same single commit, same author, same message. Only the conflicting files required manual edits; other changes are Git’s automatic replay onto main. The original eight-file PR scope is unchanged, with no added or omitted files.

Validation: TypeScript typecheck passed; all 167 tests passed across MembersPage, MembersPage.sideChat, and ChatPane.hydrateBound. Diff whitespace and conflict-marker checks passed. No full test suite was run.

Prior approvals may be dismissed by the push and need to be re-given after CI re-runs.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 19, 2026
@NicholasRBowers NicholasRBowers added the needs-pr-triage PR scanner: awaiting automated triage label Sep 23, 2026
@chenmingwei23 chenmingwei23 added drive-to-green PR claimed by drive-to-green pipeline and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 23, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable -- I'll push fixes directly to this branch as a co-author.

Assessment: Frontend-only feature (worker sessions inline in Crew Members). Three concrete, mechanical items: (1) GPT block -- mobile header has three actions in one row, move the member breadcrumb to its own row (max-two-buttons-per-row); (2) UX block -- missing screenshots of the inline "Load earlier messages" bar and the "Session not found" state, add stills of those; (3) Coverage Gate -- one file in the frontend baseline (SidePanel.tsx) now clears 80% and must be removed from the baseline so it keeps shrinking. Plus a rebase for the current merge conflict.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

Copy link
Copy Markdown
Contributor

Triage note (open-PR overlap scan against origin/main a97659d)

Classification: OVERLAPPING. Needs a rebase. Not a duplicate, and main does not supersede it.

  • Still not on main. On main, MembersPage.tsx still sends a crewmate's sessions to the Sessions page: openSessionOnChatPage → navigate(`/chat?sid=…`). Main has no MemberSessions.tsx and no &sid= worker view under /members. Its ChatPane also has no inlineHistory: earlier messages still go through onOpenFull. Everything this PR adds is still missing.
  • Stale. The PR is 2,291 commits behind main. git merge-tree shows conflicts in MembersPage.tsx, MembersPage.test.tsx, ChatPane.tsx, crew-mode.md and feature-map/README.md. feat(members): crewmate panel ia with switcher and profile card #16317 (merged) rebuilt the Crew page: a crewmate switcher plus a profile card. The "sessions it is driving" list now lives in that card's Sessions tab (CrewProfilePanel.tsx), not under each roster entry. This PR adds MemberSessions beneath each roster entry, so it needs a re-design against the new layout, not just a mechanical rebase.
  • Overlap with other open PRs. Please talk these through before you rebase:
  • Open product question. @CrysisDeu's CHANGES_REQUESTED review ("chatting with a AI crew member without needing to know what the session it's driving") questions the premise of the PR. Please settle it with the maintainer before rebasing. The GPT blocking finding (three header actions at 320px), the UX evidence gaps and the Design concern (a worker view unmounts when slotsLoaded drops on reconnect) are also still open on head 84a3ee27bb.
  • No breaking API or config change and no P0 bug found in the diff.

Recommendation: REBASE + CONTINUE-DEVELOPMENT once the product direction is agreed.

@Zedmor
Zedmor enabled auto-merge (squash) October 31, 2026 20:22
@Zedmor Zedmor closed this Oct 31, 2026
auto-merge was automatically disabled October 31, 2026 20:25

Pull request was closed

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 31, 2026
@mbriones98 mbriones98 removed the drive-to-green PR claimed by drive-to-green pipeline label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants