Skip to content

fix(dashboard): mask agent free-text fields in the members roster (#8781) - #10200

Closed
CrysisDeu wants to merge 1 commit into
mainfrom
fix/members-mask-agent-free-text-8781
Closed

CrysisDeu wants to merge 1 commit into
mainfrom
fix/members-mask-agent-free-text-8781

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

GET /api/members (src/kiro_crew/dashboard/handlers/members.py::api_members) ships the agent-record free-text fields — kiro_agent, workspace, memory_store, model, description, triggers — verbatim, and its only gate on name is _AGENT_NAME_RE, which an alphanumeric credential-shaped string (an AWS access-key-id shape) passes. These are the same agent- and package-writable fields with no load-time shape guard that the config endpoint masks since #8717 (PR #8775) and that agents.py::_roster_mask covers on the roster. A credential- or exfiltration-shaped value stored in any of them therefore reached the members payload unmasked — the third serialization surface of the #8717 class.

Why it matters

Any agent (via a config.json write) or third-party package (the agent sync copies description straight off a discovered agent spec) controls these strings. A secret that lands in one of them is serialized into the members response and rendered in the browser — the exact leak class two sibling endpoints already refuse.

What changed (motivation → approach → change)

Symptom: unmasked free text on GET /api/members → root cause: the row builder's explicit allowlist gates which fields ship but applies no redaction to their values → change: apply #8775's exact policy, confined to members.py:

  • Every _AGENT_UNTRUSTED_TEXT_FIELDS member the row ships (kiro_agent, workspace, memory_store, model, description, triggers) goes through _mask_agent_free_text (function-local import from handlers.core — handlers/__init__ imports members before core, so a module-level import risks a cycle; agents.py uses the same form). A value the redactors would alter ships as the fixed _SENSITIVE_MASK sentinel wholesale; benign values are byte-identical.
  • A credential-shaped name DROPS the row (removal, not masking): the name is the row identity — it feeds slug_for_name, the binding["member"] == row["name"] check and the DM thread route — so a masked name would be unaddressable. Same removal policy fix(dashboard): mask agent free-text fields in the config endpoint response (#8717) #8775 applies to a credential-shaped agent key.
  • memory_owner is masked too. It is a member-name reference off the memory-store record (MemoryStoreConfig.owner_member), free text that, like name, can be credential-shaped and still pass the grammar. The frontend (MembersPage.memberMemoryDisplay) reads it in exactly two ways: a truthiness test (row.memory_owner && ..., !row.memory_owner) and an equality test against row.name. Masking is safe under both. Absence stays absent: the handler normalizes the loader's falsy/no-owner cases ("", and the JSON null the loader passes through as None) to "" before masking, so a V1 store with no owner still ships "" and renders as legacy, never as the truthy sentinel. A suspicious owner ships as the sentinel, which is truthy and can never equal a surviving row's redactor-clean name, so the frontend resolves it to ownership_mismatch — the same fail-closed reading the raw suspicious value would have produced, without the raw text reaching the browser.
  • slug, avatar (_safe_avatar-validated), source (normalized to a closed vocabulary), starred (coerced bool), memory_version (int) are untouched.

Pre-merge review: an Opus-pinned local review lane blocked on description/triggers being left raw in the first cut; both are masked in this diff and the parity-gate test below is the mutation proof. Maintainer review (bolichen97) caught that the first memory_owner cut masked None into the sentinel; this head normalizes absence first and adds the owner_member=None regression.

Overlap note: open PR #8465 also adds redaction to members.py (broader change across both roster serializers, currently conflicting and needs-author-decision). This PR is deliberately narrow — it closes #8781 only and does not touch agents.py; whichever lands second has a small mechanical rebase in api_members.

Follow-ups (out of scope here, from #8781's advisory items):

Tests

test/test_members_dm_thread.py::TestRosterFreeTextMasking:

  • test_payload_preconditions_pin_the_redactor — pins that the fixtures verifiably trip/pass _redact_external, and that _AGENT_NAME_RE genuinely admits the credential-shaped name (the premise of the drop rule).
  • test_credential_shaped_values_ship_as_the_sentinel — all six masked fields come back as _SENSITIVE_MASK and the raw values are absent from the serialized body (the network boundary), not merely from the parsed rows.
  • test_benign_values_are_byte_identical — a benign sibling row is untouched.
  • test_credential_shaped_name_drops_the_row — the credential-shaped-but-grammar-valid name is absent from the roster; the benign row survives.
  • test_shape_guarded_and_coerced_fields_are_untouched — avatar/source/starred never go through the mask.
  • test_credential_shaped_memory_owner_ships_as_the_sentinel — a credential-shaped owner_member ships as the sentinel and is absent from the body; a benign owner passes through byte-identical.
  • test_absent_memory_owner_is_not_masked (parametrized over None and "") — no owner ships as "", never as the sentinel, so the frontend's legacy branch still fires for an ownerless V1 store.
  • test_every_untrusted_text_field_in_the_row_is_guarded — parity gate: every _AGENT_UNTRUSTED_TEXT_FIELDS member the row ships is masked, normalized, or explicitly exempted, so the next free-text field added to the row fails here instead of shipping raw.

Manual verification

N/A — unit coverage sufficient: the endpoint is exercised end-to-end through the aiohttp test client against the serialized JSON body, which is exactly the surface the issue reports.

Related Issues

Closes #8781. Refs #8717, #8775, #8472, #8465.

Pattern harvest

Rule candidate: review-prompt
Pattern: an explicit field allowlist at a serialization boundary gates which fields ship but not their values — every free-text member of an untrusted record class needs the class's masking helper, enforced by a parity test binding the class enumeration to the endpoint's rows. When the helper masks non-strings, normalize "absent" to the type's empty value first so a missing field is not turned into a truthy sentinel.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and buluoray September 11, 2026 20:58
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: Close the third serialization surface of the #8717 untrusted-free-text class: every agent-record free-text field GET /api/members ships is masked with the config endpoint's exact policy, and a credential-shaped row name is dropped rather than masked.
Not a goal: touching agents.py or the config endpoint, hoisting the mask helpers into a shared module, widening the type ratchet, or masking memory-store-record fields (memory_owner) — all recorded as follow-ups in the PR body.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Projection mask hand-copies eventlog's _CONFIG_FIELDS with no binding test — the next projected free-text field ships raw despite the row parity gate.

Watch

  • _ROSTER_PROJECTION_FREE_TEXT_FIELDS = ("kiro_agent", "workspace", "memory_store", "model") in members.py duplicates the free-text subset of _CONFIG_FIELDS (src/kiro_crew/eventlog/members_projections.py:20) by hand. A field added to _CONFIG_FIELDS flows into the projected roster copy, the masking loop skips it (not in the tuple), the frontend "prefers it over the row field-by-field" (the diff's own words), and untrusted text reaches the browser again. Neither test catches it: test_every_untrusted_text_field_in_the_row_is_guarded skips fields not in row, and test_projected_roster_copy_ships_as_the_sentinel hardcodes the same four names. The PR's stated design is that a parity gate makes the next field fail loudly — the projection copy, the surface this diff itself identifies as the second leak path, has no such gate.
    Clears when: members.py derives the tuple from _CONFIG_FIELDS (minus the shape-guarded exemptions), or a test binds the two enumerations so a _CONFIG_FIELDS addition fails red.

Suggestions

[DESIGN-REVIEWED] 14e0bf7

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 14e0bf7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the undeclared projections-roster masking rider: its premises hold (MembersPage.tsx:400 prefers the snapshot; the scrub is in-place), but the description never mentions it.

Not justified as shipped

  • Item 4 — undeclared: the projection roster snapshot masking (_ROSTER_PROJECTION_FREE_TEXT_FIELDS + the values.roster hunk + test_projected_roster_copy_ships_as_the_sentinel) appears in neither the description's change list nor its tests list. Premises verified in-repo (frontend prefers the snapshot field-by-field; _redact_projection_value scrubs in-place, leaving surrounding text), so it carries no premise risk — inventory tag only.

What this change ships

Inventory (5 items) — 4 justified

Intent: stop agent-/package-writable free text on GET /api/members from reaching the browser unmasked (closes #8781) — a FIX.

  1. Six roster free-text fields ship the fixed sentinel when credential/exfil-shaped; benign values byte-identical — justified
  2. A credential-shaped member name now drops its row from the roster entirely — justified
  3. memory_owner masked, with absent owner normalized to "" so it still reads legacy — justified
  4. The projection roster snapshot (the copy the page renders first) masked the same way — undeclared (see above)
  5. Parity-gate test: the next free-text field added to the row fails a test instead of shipping raw — justified

[FIRST-PRINCIPLES-REVIEWED] 14e0bf7

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d — this comment is updated in place on each push.

Review details

The new roster mask covers only the HTTP copy of the projected roster view; the WS emitter of the same view still ships it under a weaker redaction chain.

FINDING — src/kiro_crew/dashboard/handlers/members.py:485 — the in-diff masked_roster[field_name] = _mask_agent_free_text(...) guards only the block this handler serializes, while eventlog/service.py's _on_change and redacted_snapshot publish the same PROJ_ROSTER view (RosterProjection.view returns the whole config snapshot, so every member/config/member/message append re-emits kiro_agent/workspace/memory_store/model) through _redact_projection_value only — which runs redact_exfiltration_urls + redact_credentials but not _redact_external's _URL_SECRET_PARAM_RE layer, the one that catches a short opaque value in a conventionally-named param (?api_key=abc123); that frame arrives at a seq ≥ the roster baseline, memberProjectionStore.apply/seed keep the higher/first seq, and MembersPage.tsx:400 prefers roster.workspace ?? m.workspace, so the value the HTTP row just replaced with _SENSITIVE_MASK renders verbatim on the same card — and the reconcile append inside _project_rows fires that broadcast during the very request that masks it → Fix: apply the field mask where the roster view is produced (_overlay_roster, or a roster-aware arm of _redact_projection_value) so all three egress paths share one masking point; the remedy lands in eventlog/service.py/members_projections.py, which this PR does not touch, so it cannot gate this merge.

[OPUS-REVIEWED] 14e0bf7

Verdict parsed from the review's SHA-scoped output markers for commit 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 14e0bf7b401d9185392f7ef2b8ce4ba28b6cc74d: <one-sentence reason>

@CrysisDeu
CrysisDeu force-pushed the fix/members-mask-agent-free-text-8781 branch from 114d222 to 457646e Compare September 11, 2026 21:33
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 11, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/members-mask-agent-free-text-8781 branch from 457646e to b17c368 Compare September 11, 2026 22:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 11, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author
span=cd9678020c04

self-added: no

  • memory_owner ships raw while every sibling free-text field is masked — fixed in b17c368.

memory_owner now goes through _mask_agent_free_text like its siblings. Masking is comparison-safe for the one consumer that tests it: MembersPage.tsx only compares row.memory_owner against row.name, and a surviving row's name is redactor-clean, so a masked owner compares unequal exactly as the raw suspicious value would — the ownership check stays fail-closed. Covered by test_credential_shaped_memory_owner_ships_as_the_sentinel (credential-shaped owner ships as the sentinel and is absent from the body; a benign owner is byte-identical).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 11, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer review (agent-assisted), pinned to b17c368. The core masking is sound and the isolated-worktree tests pass (26 targeted; 84 for the full members DM test file), but please address two small issues before merge. (1) api_members reads owner_member without normalizing falsy values. The loader permits null; _mask_agent_free_text(None) returns a truthy sentinel. MembersPage.memberMemoryDisplay therefore changes a V1 row from legacy to ownership_mismatch even though there was no owner. Preserve absence separately from suspicious text—for example normalize the existing falsy/no-owner cases to an empty string before masking—and add a regression for owner_member=None. Keep actual credential-shaped owners masked. (2) The body explicitly says memory_owner is untouched and lists masking it as future work, but this head masks it and tests that behavior. Update the description to own this hunk and explain the frontend comparison semantics. I verified the backend output and frontend truthiness checks at the pinned head. No approval until these are resolved.

@CrysisDeu
CrysisDeu force-pushed the fix/members-mask-agent-free-text-8781 branch from b17c368 to 5e68395 Compare September 13, 2026 05:31
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 13, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Thanks for the review — both points addressed at 5e68395 (rebased onto current main, still one commit).

(1) owner_member falsy normalization — fixed. api_members now normalizes the loader's no-owner cases to "" before masking:

owner = getattr(record, "owner_member", "") or ""

so a JSON null (which the loader passes through as None) no longer reaches _mask_agent_free_text and cannot become the truthy sentinel. A V1 store with no owner ships memory_owner: "" and MembersPage.memberMemoryDisplay keeps resolving it to legacy. Truthy suspicious owners still mask (existing test_credential_shaped_memory_owner_ships_as_the_sentinel unchanged). Regression added: test_absent_memory_owner_is_not_masked, parametrized over None and "", asserting the row ships "" and not _SENSITIVE_MASK.

(2) PR description now owns the memory_owner hunk — fixed. Removed the stale "future work" bullet and added a "What changed" bullet that documents the masking and the frontend comparison semantics: the frontend reads memory_owner only via a truthiness test (row.memory_owner && ... / !row.memory_owner) and an equality test against row.name; "" stays the falsy/legacy branch, and the sentinel is truthy and can never equal a surviving row's redactor-clean name, so a masked owner resolves to ownership_mismatch — the same fail-closed reading the raw suspicious value produced, without the raw text reaching the browser. The Tests section lists both owner tests.

Re-requesting your review.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 13, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Not approving for now: bolichen97 has an outstanding maintainer CHANGES_REQUESTED on this head, and as a redaction/masking change on the members roster it needs that review cleared rather than a second opinion stacked on top.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 17, 2026
@bolichen97
bolichen97 force-pushed the fix/members-mask-agent-free-text-8781 branch from 5e68395 to 66d82a9 Compare September 19, 2026 05:32
@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main cff7de5416 by a maintainer to resolve merge conflicts. Old head 5e68395709, new head 66d82a9035.

Conflicts resolved (only these files were hand-merged, nothing else changed manually):

  • test/test_members_dm_thread.py -- Kept main’s private-thread conflict-cause regression test and the PR’s roster free-text masking fixtures/tests, combining both independent end-of-file additions unchanged.

Same single commit, same author, same message. No manual edits outside the conflict hunk; other main changes were inherited by the rebase. The original three-file PR scope and diff statistics are unchanged (321 insertions, 10 deletions).

Validation: changed Python files compile; git diff --check passes; no conflict markers; targeted test file: 97 passed.

Any prior approval was dismissed by the push and needs to be re-given after CI re-runs.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 19, 2026
@dwu96 dwu96 added needs-pr-triage PR scanner: awaiting automated triage and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 23, 2026
)

GET /api/members shipped the agent-record free-text fields verbatim, and
its only gate on `name` was the agent-name grammar, which an alphanumeric
credential-shaped string passes. These are the same agent- and
package-writable fields the config endpoint masks since #8717 (PR #8775),
so a credential- or exfiltration-shaped value reached the members payload
unmasked -- the third serialization surface of that class.

Apply the same policy, confined to members.py:

- Every `_AGENT_UNTRUSTED_TEXT_FIELDS` member the row ships (`kiro_agent`,
  `workspace`, `memory_store`, `model`, `description`, `triggers`) goes
  through `_mask_agent_free_text` (function-local import from
  handlers.core, mirroring agents.py's cycle-avoiding form): a value the
  redactors would alter ships as the fixed sentinel wholesale; benign
  values are byte-identical.
- A credential-shaped `name` DROPS the row instead of masking it: the name
  is the row identity (slug derivation, binding match, DM thread route),
  so a masked name would be unaddressable -- same removal policy #8775
  applies to a credential-shaped agent key.
- `memory_owner` (a member-name reference off the memory-store record) is
  masked too. Absence is normalized to "" BEFORE masking: the loader passes
  a JSON null through as None and the mask treats every non-string as
  suspicious, so an ownerless V1 store would otherwise ship the truthy
  sentinel and read as an ownership mismatch on the frontend. The frontend
  only tests the field for truthiness and equality with the row's name, so
  "" stays the legacy branch and a masked owner resolves to
  ownership_mismatch exactly as the raw suspicious value would.
- `slug`, `avatar` (shape-validated), `source` (normalized), `starred`
  (coerced bool) and `memory_version` (int) are untouched.

Tests pin the redactor preconditions and cover sentinel masking, benign
passthrough, name-row removal, the untouched shape-guarded fields, a
credential-shaped owner masking, an absent owner (None / "") staying "",
and a parity gate asserting no `_AGENT_UNTRUSTED_TEXT_FIELDS` member the
row ships ever comes back raw.

Closes #8781
@bolichen97
bolichen97 force-pushed the fix/members-mask-agent-free-text-8781 branch from 66d82a9 to 14e0bf7 Compare September 23, 2026 23:32
@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main fddab6f8 on the author's behalf (maintainer rebase, commits and authorship preserved; still 1 commit).

Conflicts resolved in:

  • test/test_members_dm_thread.py — both sides appended at end-of-file; kept main's new test_reopen_bound_private_thread_preserves_active_turn and this PR's TestRosterFreeTextMasking class after it.

Semantic fixes (main moved under the PR):

  • main (feat(members): per-member append-only event log under the fenced crew-log root #12020) now attaches a projections block to every GET /api/members row whose values.roster carries a SECOND copy of kiro_agent/workspace/memory_store/model (the member/config snapshot), only in-place scrubbed via _redact_projection_value — and MembersPage prefers roster.<field> ?? row.<field>, so the row-level sentinel alone no longer reached the browser (the exfil URL host survived the scrub and test_credential_shaped_values_ship_as_the_sentinel failed on the body). api_members now applies the same _mask_agent_free_text wholesale-sentinel rule to those four roster-snapshot fields (on the raw value, before the scrub — a scrubbed string no longer trips the redactor). New _ROSTER_PROJECTION_FREE_TEXT_FIELDS + regression test_projected_roster_copy_ships_as_the_sentinel. The WS projection push path is untouched (out of this PR's scope; worth a follow-up).
  • main added member_id to _AGENT_UNTRUSTED_TEXT_FIELDS; the parity gate stuffed it with the credential value, which member_slug/validate_slug reject and drop the row (IndexError). It is not shipped in the row (only its validate_slug-gated slug is), so the fixture leaves it at default and it is explicitly exempted with the reason.

Verified locally: pytest over 18 test files importing/exercising handlers.members + test_config_agent_fields_redaction.py → 883 passed, 1 failed (test_auto_improvement_members::test_assignments_build_real_context_from_only_their_private_store, pre-existing/environmental — identical failure with main's members.py, basetemp under a managed dir). compileall clean; black --check clean on touched files.

Shared files with sibling PRs being rebased in the same wave: none.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Sep 23, 2026
@NicholasRBowers NicholasRBowers added needs-pr-triage PR scanner: awaiting automated triage drive-to-green PR claimed by drive-to-green pipeline and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 27, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author.

Assessment: The only real red is the Comment History Gate — one added comment line in src/kiro_crew/dashboard/handlers/members.py:482 says "a scrubbed string no longer trips the redactor", and the gate forbids history narration in comments. That single failure cascades: Fast Gate red → Await Fast Gate red → the rest of CI skipped → Coverage Gate red, and it is both of the 2 blocking PR Readiness items (failed=[CI, Fast Gate] — no review lane is among them; Design, First Principles, UX, GPT 5.6 and Opus 5 all pass). Fix plan: reword that comment to present tense, rebase onto current main to clear the merge conflict label, and re-run. No behavioral change.

Two things I am explicitly not doing. The masking logic and the roster-projection hunk stay exactly as they are — that design is @bolichen97's rebase work and the author's, not mine to redirect. And @bolichen97's CHANGES_REQUESTED is pinned to b17c3682, several heads back; both requested items (the owner_member falsy normalization to "" before masking with its owner_member=None regression, and the description owning the memory_owner hunk) are already present at 14e0bf7b. I will ask for a re-review once CI is green rather than treat that review as cleared.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you, @CrysisDeu, for catching and fixing this! You correctly identified that GET /api/members was shipping the agent-record free-text fields (kiro_agent, workspace, memory_store, model, description, triggers) unmasked — the same leak class two sibling endpoints already refuse.

Main has since closed this same gap, a bit more broadly, in #13156 (commit 6c38f03, "fix(dashboard): mask the record strings GET /api/members ships"). That change routes every one of those fields — plus memory_owner and display_name — through the shared _roster_mask chokepoint, and refuses a credential-shaped name at creation. Your PR pointed at exactly the same bug.

Since the fix is now on main, I am closing this as superseded. Really appreciate the sharp find and the thorough write-up. 🙏

@iamwhatever iamwhatever closed this Oct 4, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 4, 2026
@mbriones98 mbriones98 removed the drive-to-green PR claimed by drive-to-green pipeline label Oct 14, 2026
@bolichen97
bolichen97 deleted the fix/members-mask-agent-free-text-8781 branch November 6, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET /api/members ships agent-record free text verbatim — third surface of #8717's class

6 participants