Repository navigation
fix(config): report stale session control opt-outs - #10674
Conversation
|
Intent: Let Doctor identify a stored session-control value that may reflect a superseded default without changing operator policy. |
1e7094c to
460552e
Compare
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of All checks are done. The mechanism is the repo's documented cause-level answer to materialized-default drift, the default flip is corroborated in-tree (CHANGELOG.md:86, same release as the two timeout rows already registered), report-only matches the registry's own rule for a value that doubles as a supported opt-out (sections.py:1299), and I found no unfixed sibling default changes from that release ( First-Principles-Verdict: PASS Verify What this change shipsInventory (4 items) — 4 justifiedIntent: tell an operator whose pre-flip install materialized
Evidence checked: default flip corroborated at CHANGELOG.md:86 beside the #8949/#8891 rows; [FIRST-PRINCIPLES-REVIEWED] 356b818 |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS A correctly-judged report-only registry append: the drift is real (#8375 verified), and an explicit [DESIGN-REVIEWED] 356b818 |
Teach Doctor to flag stored false session-control values that may reflect the former default while preserving false as a supported explicit security withdrawal.
460552e to
356b818
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: registers agent.session_control as a superseded default (False -> True in #8375) so Doctor names a stored False that silently keeps every peer-session tool disabled; the entry is deliberately report-only and pinned out of the adopting set, with a test asserting the stored value and the on-disk config are left untouched, so an operator's explicit withdrawal is never overridden. CodeQL is not applicable on this fork PR (default-setup emits no check-run); SAST coverage is Semgrep only, latest run success with 0 annotations.
Teach Doctor to flag stored false session-control values that may reflect the former default while preserving false as a supported explicit security withdrawal. Co-authored-by: LuisBrel <193017400+LuisBrel@users.noreply.github.com>
Problem / Motivation
A stored
agent.session_control: falsevalue can reflect the former default and disable peer-session tools, while Doctor currently gives no clue that the default changed.Why it matters
Users need a diagnostic path for missing session tools without weakening the supported global security withdrawal.
What changed
agent.session_controlto superseded-default diagnosticsfalsevalue is never rewrittenNo linked issue: this documents a locally reproduced configuration drift path without an existing public issue.
Tests
Pattern harvest
Rule candidate: regression test
Pattern: a superseded security-sensitive default needs diagnostics without auto-adoption when the former value remains a supported opt-out.