Repository navigation
Conversation
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
480ce58 to
6261c52
Compare
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing every screenshot — the image and recording lists are empty, yet the PR ships a capture harness (scenes 01–14) built to produce exactly these frames. Evidence gaps
Suggestions
[UX-REVIEWED] 8878d94 |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsFINDING -- website/scripts/capture-folder-read-failure.mjs:138 -- undeclared |
Design Review (Fable 5, fork) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK Cannot evaluate: missing screenshots/recording of the reshaped failure notices, the morphing Refresh control, and the rail-kept-mounted states. BlockersRequired rendered evidence of this revision is absent. Suggestions
[DESIGN-REVIEWED] 8878d94 |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS
Not justified as shipped
What this change shipsInventory (10 items) — 8 justifiedIntent: FIX — name why a folder/tree read failed instead of generic copy, and stop a transient tree failure from unmounting the file rail. (More than 10 differences; capped at 10 — dropped:
[FIRST-PRINCIPLES-REVIEWED] 8878d94 |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed |
6261c52 to
2cb1c5a
Compare
2cb1c5a to
d8b1693
Compare
d8b1693 to
445d3e9
Compare
445d3e9 to
6f430f2
Compare
6b8c62c to
90e7d2a
Compare
Keys the folder panel notices on the cause so a refusal reads differently from a timeout, and adds a recoverable tree state so the file rail stays mounted with a retryable notice instead of unmounting.
90e7d2a to
8878d94
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
Mechanical once #10834 lands and this rebases onto it: PR Hygiene, the four-file conflict ( What I need from you: land or close #10834, then re-request triage. When you've addressed this, the pipeline will re-assess on its next cycle. |
|
Consolidation suggestion: this PR overlaps open PR #7068 @rnoack1, this PR and your PR #7068 change the same surfaces for the same goal: name why a folder or tree read failed, and keep the rail mounted when a tree failure is recoverable. Roughly half of the lines added here also appear verbatim in the PR #7068 diff. Neither thread links the other. In both: Only here:
Better in PR #7068:
Not portable: the FilesHomePanel redesign. Suggestion: make PR #7068 the host and port three things into it:
If you would rather keep the split track, PR #10834 has to land first, and this PR then needs a new Refresh for the non-recoverable arm. Either way, a line here saying which track you are driving would tell reviewers which PR to read. From a full open-PR audit against origin/main c66f95b (2026-09-25); findings were checked by independent reviewers reading the code. Reply here if this is wrong. |
|
Closing as SUPERSEDED by merged PR #7068 (squash @rnoack1, the 2026-09-25 consolidation note on this PR proposed making #7068 the host and porting three items from this branch into it. #7068 has since merged, and all three items are on
Not carried over: the This branch is also 2,600+ commits behind main, conflicts with it, and still imports a module path from the unmerged #10834. A rebase would reduce to an empty diff plus the harness. If I missed a behaviour, reopen this PR and name it here. A rebased diff of just that piece would be easy to review. Open-PR audit against origin/main a97659d. Evidence was checked by reading the diffs and the main tree. |
Problem / Motivation
The folder panel collapsed every read failure into one of two generic notices. A search that timed out, a folder the user has no access to, and a root that no longer exists all rendered as "Unable to list folder" — and a refusal showed no Retry, so it was distinguishable from a transient outage only by the absence of a button.
Separately, a failure to read the project tree unmounted the file rail entirely. The panel disappeared rather than reporting that it could not load, so a recoverable failure looked identical to "this project has no files".
Why it matters
A refusal and an outage need opposite responses, and a notice that names neither leaves the user retrying something that cannot succeed. Inferring the difference from whether a button is present is not a design a user can be expected to read.
The unmounting rail is worse than a wrong message: a transient tree read failure removed a whole navigation surface, with nothing on screen to say it would come back.
What changed (motivation → approach → change)
TreeStategains arecoverablemember, distinguishing a tree read that failed transiently from a project that genuinely has no directory. Onrecoverablethe rail stays mounted and shows a retryable notice instead of unmounting.useTreeAvailabledelegates touseTreeStaterather than re-spelling the rule, so the mount policy has one definition.The
TreeStatechange and the folder panel ship together because they are one concern: the panel reads the same union the rail defines, so separating them would split a discriminated union from its consumer.Tests
FolderPanel.deadline.test.tsxandFolderPanel.search.test.tsxcover each cause notice on both arms, that a refusal offers no Retry, and that the visible Refresh label appears exactly while a retryable failure is plausible and not otherwise.FolderPanel.tree.test.tsxcovers the root tree-error notice.FileBrowserRail.test.tsxandFilesHomePanel.test.tsxcover the rail staying mounted on a recoverable tree failure, and thatuseTreeAvailablefollows the same rule.Manual verification
Green with the prerequisite applied locally:
tsc -b,eslint --max-warnings 0, the i18n gate suite, and 115 tests across the six suites above.Note for CI: until #10834 merges, this branch does not typecheck on
main, because the module it imports does not exist there yet. That is expected for this unit and is not a defect in the diff.