Repository navigation
Conversation
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
Design Review (Fable 5, fork) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK WorkspacePicker has no production consumer — this PR invests retry UX, 12 locale strings, and a two-PR dependency stack in unreachable code. BlockersFailure UX built on a component nothing mounts. [DESIGN-REVIEWED] 2df39fa |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS New failure notices and Retry live in a component nothing mounts — no user can reach them, and nobody has ever seen them rendered. Watch
[UX-REVIEWED] 2df39fa |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Fable 5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The whole fix lands on a component nothing mounts — the author's own zero-consumer count is right, so shipping nothing here costs nobody anything. Not justified as shipped
What this change shipsInventory (8 items) — 5 justifiedIntent: a FIX — when the workspace picker's folder listing fails, name the cause and offer a retry instead of a silent empty state.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 2df39fa |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsI've verified the state thoroughly. The isolated review commit Both candidates hinge entirely on the contract of code I cannot open:
Neither can be grounded to (a)/(b)/(c) from code I actually opened. No Step 2 finding is groundable either — every branch of the visible logic is conditioned on values from the unopened hook. Both die under falsification. No findings. [OPUS-REVIEWED] a3f9490 |
Routes the workspace picker listing through the shared bounded hook so a refusal and a timeout read differently instead of collapsing into one generic listing error.
a3f9490 to
2df39fa
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes: neither prerequisite provides ./useBrowseDirs, so this still won't build after PR #10834 and PR #10842 merge
The description says this unit gets useBrowseDirs from the second prerequisite and that the typecheck failure goes away once both land. Neither prerequisite adds that module at its current head:
website/src/components/WorkspacePicker.tsx:8hasimport { useBrowseDirs } from './useBrowseDirs', and:37uses it:const { listError, browse, retry, noteInputEdited } = useBrowseDirs(open, ...). The PR deletes the old inlinebrowsecallback, so nothing else in the file does that job.- PR #10842 (head e2fb6f3) adds
website/src/components/RetryControl.tsx. It has nouseBrowseDirsfile and no reference to one. Its description says it was narrowed ("NouseQuerymigration", and "This unit does not touch the listing failure notice"). - PR #10834 (head 22b5c95) adds
website/src/lib/searchErrorCause.ts. It has nouseBrowseDirseither. - origin/main has none of the three modules. In the mirror we audited,
git log --all -S useBrowseDirsfinds only this PR's commit, 2df39fa.
What breaks: website/tsconfig.app.json sets "include": ["src"], and build is tsc -p tsconfig.app.json && ... vite build. So WorkspacePicker.tsx gets type-checked even though nothing mounts it. tsc then fails with TS2307 "Cannot find module './useBrowseDirs'", and vite never runs. The red Frontend Lint & Type Check on this head will stay red after both prerequisites merge. WorkspacePickerCoverage.test.tsx imports the real component and has no vi.mock for the hook, so that suite can't resolve either. It also relies on the hook's contract: api.browseDirs gets called with expect.any(AbortSignal), and retry().then(ok => ...) at :146.
Who is affected: no users, because no production component mounts WorkspacePicker. The cost falls on the frontend build and the package build, and on reviewers who assume this becomes mergeable once the stack lands. The local green run in the description must have used a useBrowseDirs that we could not find on any pushed branch.
Smallest fix: add website/src/components/useBrowseDirs.ts to this PR, or push the branch that has it and list that branch as the prerequisite. While you're updating the description, it also credits RetryControl to PR #10834, but PR #10842 is the one that adds it. If a maintainer decides to delete WorkspacePicker instead, as the Design Review and First Principles blocks suggest, none of this matters.
From a full open-PR audit against origin/main c66f95b (2026-09-25); findings were checked by independent reviewers reading the code. Reply here if this is wrong.
|
🤖 Kiro Crew [operator: dodgeblaster#b5f0d847]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
When you've decided the disposition (and landed the prerequisites if keeping it), the pipeline will re-assess on its next cycle. |
|
Triage: SUPERSEDED by merged PR #7068. Closing. I checked this against origin/main This unit was split out of the larger file-search/folder-listing timeout change. That change has since landed as PR #7068 (squash
Two things in this diff are not on main, and neither is a reason to keep it open:
If you still want the shared-hook refactor, please open it as a fresh PR on top of current main. |
Problem / Motivation
WorkspacePickeris the twin of the project picker: same directory-listing read, same hand-rolled fetch state, same single generic "Unable to list folder" for every failure. A refusal, a timeout and a missing root were indistinguishable, and there was no way to retry.Why it matters
The two pickers are visibly the same control, so divergent failure behaviour between them is a bug in its own right — the same wedged gateway would produce a named cause and a Retry in one and a bare generic line in the other. Keeping them on one shared hook is what stops that divergence recurring the next time either is touched.
What changed (motivation → approach → change)
useBrowseDirshook, so it is bounded and has one error shape and one retry entry point.retrylabel.refetchon a key that never succeeded clears the error, which would otherwise unmount the notice mid-read.Tests
WorkspacePickerCoverage.test.tsxcovers the cause-keyed notices, that a refusal offers no Retry, and the cleared-rows behaviour on a failed drill.Manual verification
Green with both prerequisites applied locally:
tsc -b,eslint --max-warnings 0, the i18n gate suite, and 37 tests in the suite above.Note for CI: until the prerequisites merge, this branch does not typecheck on
main, because the modules it imports do not exist there yet. That is expected for this unit and is not a defect in the diff.One thing a reviewer should decide before merging this
WorkspacePickerappears to have no production consumer. Searching the tree for references turns up only a prose mention in a comment inMicSourceMenu.tsxand its own test file — no component mounts it. The same search forProjectPickerreturns five non-test consumers, so the query does find them where they exist.If that is right, this unit changes a component no user can currently reach, and deleting it may be the better disposition than reviewing it. I have not deleted anything here, because that is a scope call for a maintainer rather than something to fold into a failure-UX change.
Pattern harvest
Rule candidate: eslint
Pattern: a rejection from an
api.*call discarded by a handler that neithersurfaces nor stores the cause, so the caller renders its empty state as though the
read had succeeded. The instance this PR fixes is
website/src/components/WorkspacePicker.tsx:35on mainline — a body-less.catch(() => {})closingapi.browseDirs(path).then(...), which leaves the listclaiming no subdirectories for a directory that was never read.
The retirable rule is narrow and syntactic: flag a
.catchon anapi.*promisewhose handler binds no rejection parameter, or binds one and never reads it. A
handler that assigns the cause to state or rethrows is not caught. This belongs in
lint rather than a review prompt because the defect is invisible at the call site by
construction — the code reads as though failure were handled.
This is the instance #10842's harvest named as remaining; that PR fixed the
recentProjectssibling inProjectPickerand left this one to the unit that ownsthe surface.