Repository navigation
fix(i18n): sync dev-fleet manifest description with app.json - #10940
Conversation
Sync the Dev Fleet English catalog with the app manifest. Regenerate the pseudolocale so the manifest-sync gate passes. Fixes #10938
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The eleven translated catalogs still carry the pre-#10742 Dev Fleet text, so only English readers see the sandbox-escape disclosure this sync adds. WatchTranslations stranded at the old string. Suggestions
[DESIGN-REVIEWED] cbbc204 |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The sandbox-escape warning lands in English only, and the CI guard that let this drift reach Not justified as shipped
What this change shipsInventory (3 items) — 1 justifiedIntent: unwedge the red
[FIRST-PRINCIPLES-REVIEWED] cbbc204 |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS A new sandbox-escape caveat sits at the end of a description that truncates to one line beside the Enable button. Watch
Suggestions
[UX-REVIEWED] cbbc204 |
|
Independent downstream verification from PR #10744: the full 50-command local profile on 65b8aaa0b2922ac679f8aa8559a5842adfb9a617 (base 57eaecf) has exactly one failed command: i18n manifest-sync for apps.devFleet.manifest.description. All website and built-in app inputs are byte-identical to that base. I checked out cbbc204 separately, confirmed check-app-manifest-sync.mjs itself is unchanged, and ran it: OK, 24 built-in manifests / 244 strings match. We will consume this fix after its normal merge rather than duplicate the catalog edit in the overload stack. This confirms the manifest-sync repair only, not this PR’s full readiness or approval. |
…dev#10940) Sync the Dev Fleet English catalog with the app manifest. Regenerate the pseudolocale so the manifest-sync gate passes. Fixes kirodotdev#10938
Problem / Motivation
Every pull request inherits a red
Frontend Lint & Type Checkbecause[manifest-sync]reports thatapps.devFleet.manifest.descriptiondrifted from the Dev Fleetapp.jsonmanifest.Why it matters
This restores the hard-zero i18n gate on
main, so unrelated pull requests can pass the frontend lint job again.What changed (motivation → approach → change)
The Apps page card reads the same Dev Fleet description that the manifest already ships.
website/src/i18n/locales/en.jsoncopies the manifest description byte-for-byte, andwebsite/src/i18n/locales/en-XA.jsonis regenerated from it.Tests
I18N_BASE_REF=origin/main npm run i18n:check— all 19 checks passed;[manifest-sync]reports 24 manifests and 244 strings in sync.npm run lintnpm run typechecknpm run buildManual verification
The single pod attempt failed closed before browser verification because the CLI could not prove ownership of port 7860 and withheld the pod token. Teardown verification reported the pod
down.Screenshots / video
Why no screenshot: one-line catalog string sync: the card now renders the description app.json already ships; no layout change
Related Issues
Fixes #10938
Pattern harvest
Not generalizable: the existing
[manifest-sync]hard-zero gate already detects this exact drift;mainonly needs the generated catalog catch-up.Checklist