Skip to content

fix(i18n): sync dev-fleet manifest description with app.json - #10940

Merged
bolichen97 merged 1 commit into
mainfrom
fix/dev-fleet-manifest-description-sync
Sep 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/dev-fleet-manifest-description-sync

Conversation

@pepmach

@pepmach pepmach commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Every pull request inherits a red Frontend Lint & Type Check because [manifest-sync] reports that apps.devFleet.manifest.description drifted from the Dev Fleet app.json manifest.

Why it matters

This restores the hard-zero i18n gate on main, so unrelated pull requests can pass the frontend lint job again.

What changed (motivation → approach → change)

The Apps page card reads the same Dev Fleet description that the manifest already ships. website/src/i18n/locales/en.json copies the manifest description byte-for-byte, and website/src/i18n/locales/en-XA.json is regenerated from it.

Tests

  • I18N_BASE_REF=origin/main npm run i18n:check — all 19 checks passed; [manifest-sync] reports 24 manifests and 244 strings in sync.
  • npm run lint
  • npm run typecheck
  • npm run build

Manual verification

The single pod attempt failed closed before browser verification because the CLI could not prove ownership of port 7860 and withheld the pod token. Teardown verification reported the pod down.

Screenshots / video

Why no screenshot: one-line catalog string sync: the card now renders the description app.json already ships; no layout change

Related Issues

Fixes #10938

Pattern harvest

Not generalizable: the existing [manifest-sync] hard-zero gate already detects this exact drift; main only needs the generated catalog catch-up.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests are not needed for this generated catalog sync
  • Self-review completed; code follows project style guidelines
  • Documentation is not applicable
  • No secrets, credentials, or internal references in the diff

Sync the Dev Fleet English catalog with the app manifest.
Regenerate the pseudolocale so the manifest-sync gate passes.

Fixes #10938
@pepmach
pepmach requested review from a team and iamwhatever September 15, 2026 01:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed cbbc2040c380edc2e445847346ef2df42efa0732 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cbbc204

Verdict parsed from the review's SHA-scoped output markers for commit cbbc2040c380edc2e445847346ef2df42efa0732.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cbbc2040c380edc2e445847346ef2df42efa0732: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of cbbc2040c380edc2e445847346ef2df42efa0732 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cbbc204

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cbbc2040c380edc2e445847346ef2df42efa0732: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of cbbc2040c380edc2e445847346ef2df42efa0732 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The eleven translated catalogs still carry the pre-#10742 Dev Fleet text, so only English readers see the sandbox-escape disclosure this sync adds.

Watch

Translations stranded at the old string.
The diff touches only en.json and en-XA.json, but the sentence added upstream is a safety disclosure — "code from a worktree an agent can write runs outside the agent's sandbox, as you". fr.json's apps.devFleet.manifest.description still ends at "…déjà fusionné.", and catalogParity.test.ts is key-based so nothing goes red. A non-English operator therefore reads a Dev Fleet card that never tells them enabling it lets agent sessions run worktree code outside the sandbox as them. website/docs/i18n-catalog.md:279 makes this step 4 of the same procedure, not a follow-up.
Clears when: the eleven <tag>.json devFleet descriptions carry the new sentence, or the PR states why the disclosure may ship English-only.

Suggestions

[DESIGN-REVIEWED] cbbc204

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of cbbc2040c380edc2e445847346ef2df42efa0732 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The sandbox-escape warning lands in English only, and the CI guard that let this drift reach main is left in place for all 24 manifests.

Not justified as shipped

  • Item 1 — symptom-level: "Not generalizable: the existing [manifest-sync] hard-zero gate already detects this exact drift" is false for the PR that causes it. check-app-manifest-sync.mjs:46 reads src/kiro_crew/apps/builtins, but it only runs in frontend-lint, which ci.yml:1961 skips on only_backend != 'true'; no pytest equivalent exists. So a backend-only app.json edit is caught by nothing and lands red on main — 24 built-in manifests can repeat it.
    Subtraction: drop frontend-lint's only_backend skip (ci.yml:1961), the guard hiding CI's only outside-website/ gate — deferred, not this PR.
    Clears when: that skip is gone, so a backend-only app.json edit fails [manifest-sync] on its own pull request instead of on main.
  • Item 3 — undeclared: "all 19 checks passed" reads as complete, but step 4 of the documented order (website/docs/i18n-catalog.md:279, "Translate into the other eleven catalogs") is skipped, and no gate detects it — [changed-values]/[changed-passthrough] diff each locale against itself, so an English-only edit is invisible. fr.json:1849 still ends "déjà fusionné."
    Clears when: the eleven catalogs carry the new sentence, or the manifest sentence is reverted.

What this change ships

Inventory (3 items) — 1 justified

Intent: unwedge the red Frontend Lint & Type Check on main by making the Dev Fleet catalog description match the manifest again. FIX.

  1. The English Dev Fleet card now warns that enabling the app lets agent sessions run worktree code outside the agent's sandbox, as you — symptom-level: catalog catch-up, cause left in CI
  2. The dev-only pseudolocale rendering of that card grew the same sentence — justified
  3. That warning shows in English only; eleven translated cards still render the pre-warning description — undeclared

[FIRST-PRINCIPLES-REVIEWED] cbbc204

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of cbbc2040c380edc2e445847346ef2df42efa0732 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

A new sandbox-escape caveat sits at the end of a description that truncates to one line beside the Enable button.

Watch

  • Decision-critical consequence is unreadable where the decision is made. The appended sentence — "Enabling it also lets AGENT sessions start and stop pods … runs outside the agent's sandbox, as you." — is sentence 5 of the description, and AppListRow.tsx:67 renders that description truncated to one line directly beside the Enable button at AppListRow.tsx:91-97 (line-clamp-2 in FeaturedSpotlight.tsx:413). Enabling a builtin has no consent step (useAppActions.ts:77), so a user grants agent-driven pod control having read only "A control panel for working on Kiro Crew itself. Lists every…". Moderate frequency × high impact (unannounced privilege grant) × every enable-from-grid. Fix: move the sentence into highlights in dev_fleet/app.json — bullets render unclamped at AppDetailPage.tsx:1569 and already hold this app's caveats (highlight_6, highlight_7).
  • "AGENT sessions" reads as a product name, not emphasis. One sentence spells the same actor three ways — AGENT sessions, an agent, the agent's sandbox; the catalog uses mid-sentence caps only for negations elsewhere (en.json:2780, 3016). A newcomer cannot tell whether "AGENT" is a distinct named mode. Low impact, permanent. Fix: lowercase to "agent sessions".

Suggestions

  • Rewrite the caveat as its own plain-language highlight: "Enabling it lets agent sessions start and stop pods, so code from a worktree the agent can edit runs with your permissions, outside its sandbox."
  • The PR's <!-- no-visual-delta --> justification ("no layout change") is inaccurate: appDescription() returns the catalog value for builtins (appManifest.ts:443-445), so this PR is what puts the new sentence on the Apps detail page — worth a still of AppDetailPage next time.

[UX-REVIEWED] cbbc204

@bolichen97

Copy link
Copy Markdown
Contributor

Independent downstream verification from PR #10744: the full 50-command local profile on 65b8aaa0b2922ac679f8aa8559a5842adfb9a617 (base 57eaecf) has exactly one failed command: i18n manifest-sync for apps.devFleet.manifest.description. All website and built-in app inputs are byte-identical to that base. I checked out cbbc204 separately, confirmed check-app-manifest-sync.mjs itself is unchanged, and ran it: OK, 24 built-in manifests / 244 strings match. We will consume this fix after its normal merge rather than duplicate the catalog edit in the overload stack. This confirms the manifest-sync repair only, not this PR’s full readiness or approval.

@bolichen97
bolichen97 merged commit cdb1613 into main Sep 15, 2026
74 of 79 checks passed
@bolichen97
bolichen97 deleted the fix/dev-fleet-manifest-description-sync branch September 15, 2026 05:36
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Sep 15, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…dev#10940)

Sync the Dev Fleet English catalog with the app manifest.
Regenerate the pseudolocale so the manifest-sync gate passes.

Fixes kirodotdev#10938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manifest-sync gate red on main: dev-fleet description drifted from app.json

2 participants