Skip to content

feat(website): warn on a redacted save and gate an overwrite in AutoNudgePopover - #11027

Closed
rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:split/autonudge-popover-redaction-ui
Closed

rnoack1 wants to merge 1 commit into
kirodotdev:mainfrom
rnoack1:split/autonudge-popover-redaction-ui

Conversation

@rnoack1

@rnoack1 rnoack1 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

When a nudge goal is saved, the popover can overwrite a goal the server has since
changed, and it gives no sign when the text it is about to send has been redacted on
the way out. A user editing a goal that another client already updated loses that
update silently, and a redacted message reads as if nothing happened.

This is one unit of a larger change (#7996) split into reviewable pieces.

Why it matters

The overwrite is irreversible from the user's side: the goal they did not write
replaces the one they did, with no record of what was lost. Redaction is the same
problem in reverse — the save appears to succeed while the content that reached the
store is not the content the user typed, so they have no reason to re-check it.

What changed

  • AutoNudgePopover.tsx grows an amber redaction notice, an overwrite-confirm gate
    bound to the goal it was served for, and handling for a 409 carrying a stale
    baseline fingerprint. A confirm dialog is raised on either trigger, so a user is
    asked before an unsent edit is discarded.
  • autoNudgeLoop.ts, types/index.ts and monitoring/automation.ts carry the few
    type and field additions the component needs. These are declared here rather than
    imported, so this unit compiles against main alone.
  • The 13 locale files add the notice and dialog strings. This is mechanical
    translation data and rides together because the i18n gate checks locale parity.

Merge order: the backend that serves message_fingerprint and the redaction flag
ships in #10967 and #10973. Merged before those, this unit renders correctly but the
new arms stay dormant, since the fields it reads are simply absent. It does not
break existing behaviour in that state.

Tests

AutoNudgePopover.test.tsx — 66 tests pass, covering the redaction notice, the
overwrite-confirm gate on both triggers, the 409 fingerprint path and the existing
goal-persistence and countdown behaviour.

Typecheck is clean for every file this unit touches: the 9 files tsc -b reports
are pre-existing base-side errors in src/stories/* and two components with missing
dependencies, and the intersection with this unit's 18 changed files is empty. Both
i18n gates pass.

Two test blocks are held back to keep this unit under the review size cap, and open
as a follow-on against this same file once it lands: AutoNudgePopover numeric seeding while open and the keep-stored arm reports what actually happened. They
are deferred, not dropped.

Screenshots

Every new user-visible state in this unit, captured in the popover at 420px.

Amber notice explains a masked goal and the retype rule

Overwrite confirm armed on a redacted goal: question plus the three stacked answers

The same armed confirm in the light theme

Moved-goal variant: question, scrollable newer-stored-goal preview, three answers

The confirm re-arms and announces that the stored goal changed again

Remaining states: dismiss warnings, post-save notices, paused-loop labels, 409 reload (8 frames)

Discard warning below the textarea after a refused Escape

Discard warning under the X after a refused close

Post-save notice: the save was masked, ignored fields named

Post-save notice: ignored-fields-only variant

Post-save notice: the stored goal was kept

Post-save notice: kept-stored-goal-only variant

Keep-stored label variant on a paused loop, which also starts the loop

A 409 whose reload of the newer goal failed, reported in plain copy

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 15, 2026
@dwu96

dwu96 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@rnoack1
rnoack1 marked this pull request as ready for review September 15, 2026 12:00
@rnoack1
rnoack1 requested review from a team and iamwhatever September 15, 2026 12:00
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — 🔴 changes requested (blocking)

Reviewed 6c1ed0ce2b57ea015694dd731213b87f5b042646 via the fork AI-review pipeline; updated in place on each push.

2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

BLOCKING -- website/src/components/AutoNudgePopover.tsx:332 -- A tokenless live frame disables stale-write protection

const baseline = armed || loop.message_fingerprint || fingerprintAtOpen; if (baseline) patch.expect_fingerprint = baseline
Tokenless live frame -> edited PATCH omits its baseline -> a concurrent goal update is overwritten.
Anchor: residual/crash-data-loss-corruption
Fix: Fetch and latch the slot fingerprint before permitting a message PATCH without a baseline.

BLOCKING -- website/src/components/AutoNudgePopover.tsx:395 -- Numeric edits made during saving are discarded

if (latest.current.message !== message) {
Numeric edit during the in-flight PATCH -> message remains unchanged -> popover closes and discards the newer number.
Anchor: residual/crash-data-loss-corruption
Fix: Keep the popover open when either numeric dirty flag remains set.

[BLOCK-MERGE] 6c1ed0c
[GPT-REVIEWED] 6c1ed0c

Adjudication (Opus 5) — is blocking on each finding proportionate?

F1 — HIGH (silent, irreversible overwrite of another writer's goal text).
Conditions confirmed: the live autonudge_state frame is nine hand-named keys with no goal_token/message_fingerprint (src/kiro_crew/slack/gateway.py:8034-8044), emitted on every cycle (src/kiro_crew/autonudge.py:7106) and every update (:3354); it replaces the record wholesale (website/src/store/chatSlice.ts:5182, website/src/hooks/useWebSocket.ts:2653-2659), REST reseeding runs only on connect/reconnect (website/src/hooks/useWebSocket.ts:604-607); with fingerprintAtOpen latched from that tokenless record the PATCH omits expect_fingerprint, and the store fence only fires when the field is present (src/kiro_crew/autonudge.py:3034-3037). No recovery: the overwrite mints a new token (:3051) and the prior text is gone.

F2 — LOW (a re-typeable number lost, stored state uncorrupted).
Conditions confirmed: loop present (PATCH branch, patch hunk @@ -215,12 +319,83 @@); numeric inputs stay editable during the in-flight save — they carry only disabled={writeDisabled}, which is a prop independent of saving (website/src/components/AutoNudgePopover.tsx:61,75,542,555); the keystroke must land inside one HTTP round trip while the goal text stays untouched, and the goal must be neither redacted nor moved. Recovery: no draft covers a numeric field while a loop exists (:191, :202), but the new reseed effect restores the authoritative server value on reopen, so the user sees the true stored number and re-enters theirs.

[ADJUDICATION] 6c1ed0ce2b57ea015694dd731213b87f5b042646 total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] 6c1ed0ce2b57ea015694dd731213b87f5b042646

[ADJUDICATION-FENCED] 6c1ed0ce2b57ea015694dd731213b87f5b042646 fenced=2 flagged=1
UPHOLD-FENCED F1 website/src/components/AutoNudgePopover.tsx:332 -- A tokenless record is the ordinary steady state, not an extreme one: the gateway broadcasts a goal_token-free frame on every fire and every update and it replaces the store record wholesale, so the open-edge latch is empty on any popover opened after the first cycle and the fence the PR exists to arm is omitted from the PATCH entirely.
FLAG F2 website/src/components/AutoNudgePopover.tsx:395 -- Reaching it needs a numeric keystroke inside a single HTTP round trip after the user has deliberately moved focus off Save, with the goal text untouched and neither the redacted nor the moved arm engaged; what is lost is one re-typeable integer, the stored config still holds exactly what was submitted, and the reopened popover shows that authoritative value.
[GPT-ADJUDICATED-FENCED] 6c1ed0ce2b57ea015694dd731213b87f5b042646

🏷️ Fenced finding(s) machine-flagged as likely edge case

The security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override recorded by a repository writer, who must independently verify a rationale before recording it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop. (This lane's comment deliberately carries no override command.)

  • F2 website/src/components/AutoNudgePopover.tsx:395 — Reaching it needs a numeric keystroke inside a single HTTP round trip after the user has deliberately moved focus off Save, with the goal text untouched and neither the redacted nor the moved arm engaged; what is lost is one re-typeable integer, the stored config still holds exactly what was submitted, and the reopened popover shows that authoritative value.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🔴 BLOCK

UX-level review of 6c1ed0ce2b57ea015694dd731213b87f5b042646 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: BLOCK

cannot evaluate: missing screenshots of the "(save other settings)" keep-stored button labels and the redacted moved-goal preview line.

Evidence gaps

  • keep_original_goal / keep_original_goal_start — "Keep stored goal (save other settings)" and "…and start loop (save other settings)" appear in no attachment (02/03/04/05/12 all show the goal-only labels); close with a screenshot of the gate armed after editing both the goal and a numeric field. The description's "Every new user-visible state … captured" claim doesn't hold for these.
  • moved_goal_preview_redacted — "Sensitive parts of that newer goal are masked here." is shown in no attachment (04/05 show the preview only on an unredacted loop); close with a screenshot of the moved-goal confirm on a redacted loop.

Watch

  • Goal-only gate (attachment-02): "Go back to editing" and "Keep stored goal" both leave the stored goal and the typed text exactly as they are — the only difference (one PATCHes, one writes nothing) is invisible in the labels, so users guess every time the gate arms; friction, persistent. Smallest fix: let the goal-only keep arm say what it does beyond dismissing, or drop it to the ghost style when it saves nothing.
  • confirm_overwrite_plain_question says "The stored goal can't be shown" directly under a textarea that is showing it (masked) — reads as false. Fix: "can't be shown unmasked or recovered".
  • Attachment-05: the "stored goal changed again" notice is indented, not left-aligned with the question below it despite self-stretch — visible misalignment inside one message block.

[UX-REVIEWED] 6c1ed0c

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — 🟡 CONCERNS

Design-level review of 6c1ed0ce2b57ea015694dd731213b87f5b042646 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Redaction inferred from a [REDACTED: substring mislabels goals that legitimately contain that literal — text the UI itself says saves verbatim — arming false overwrite confirms.

Watch

  • isRedacted (AutoNudgePopover.tsx) is ORed with message_redacted permanently, not used as a fallback. The notice says "any [REDACTED: …] left in the box is saved as literal text"; a goal saved that way then shows the redaction warning and the "can't be shown or recovered" confirm on every future edit — a false claim about a goal that is fully shown — and feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973's authoritative flag never overrides it because the substring arm stays live.
    Clears when: the substring heuristic runs only when message_redacted is absent from the wire, or is removed once feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973 lands.
  • Phantom description: "types/index.ts … carr[ies] the few type and field additions," but the patch contains no types/index.ts hunk (and touches 21 files, not the stated 18). If that edit exists locally, the pushed revision may not compile the way the description's typecheck claim was measured.
    Clears when: the missing file is committed or the description drops the claim.

Suggestions

[DESIGN-REVIEWED] 6c1ed0c

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — 🟡 CONCERNS

Premise-level review of 6c1ed0ce2b57ea015694dd731213b87f5b042646 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The description says the new arms "stay dormant" before #10967, but the diff itself activates all three on base — and ships an undeclared backend change.

Not justified as shipped

  • Item 4 — undeclared: every save on this surface now sends a sparse PATCH, and the base assertion pinning the full body (SessionAutomationPopover.test.tsx:712-714) was rewritten; the "What changed" section never mentions it. The new shape is cause-level (an echoed untouched field clobbers a concurrent change), so declaration, not deletion, is what's missing.
    Clears when: the author declares the sparse-PATCH save behaviour in the description and confirms it is intended for every save, not only the gated ones.
  • Item 8 — undeclared: the description says "the backend that serves message_fingerprint and the redaction flag ships in feat(autonudge): scrub loop text on every egress so a credential cannot reach a reader #10967 and feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973" and "the new arms stay dormant, since the fields it reads are simply absent" — yet this diff edits src/kiro_crew/dashboard/handlers/autonudge.py to forward expect_fingerprint, falls back to base's served goal_token, and derives redaction from the [REDACTED: text, so the 409 fence, the notice and the confirm gate are all live the day this merges. (Verified on base: the store fence at src/kiro_crew/autonudge.py:3034 and goal_token on the _serialize wire already exist; the handler was the only caller of authorize_and_update_nudge not passing the baseline — 0 unfixed siblings.)
    Clears when: the author confirms the immediate on-base activation is intended and the backend hunk is declared in the description.
  • Item 6 — undeclared: untouched numeric inputs now follow live loop updates while the popover is open; the description mentions only its deferred tests.
  • Item 9 — rides along: the clear-goal confirm and the overwrite gate made mutually exclusive, with the erase button losing its danger colour while the gate is armed.

What this change ships

Inventory (10 items) — 6 justified

Intent: stop the goal popover from silently overwriting a goal changed elsewhere and from hiding that a saved goal was redacted — a FIX (wiring the store's existing CAS fence to the browser path, plus guard UI).

  1. An amber notice appears when the shown goal is a redacted projection — justified
  2. Saving over a redacted or concurrently-changed goal now asks first, with keep-editing / keep-stored / overwrite arms — justified
  3. A stale save is refused with a 409, the newer goal reloads, and the conflict is explained — justified
  4. Save now sends only the fields the user edited — undeclared; rewrote the base full-body wire pin
  5. Closing with unsent edits (Escape, X, outside click, trigger) refuses once and warns — justified
  6. Untouched numeric inputs follow live updates while the popover is open — undeclared
  7. A save can leave the popover open with a notice (masked result, kept goal, mid-save keystroke) — justified
  8. The dashboard PATCH handler now forwards expect_fingerprint, activating the store's 409 fence — undeclared; description assigns the backend to feat(autonudge): scrub loop text on every egress so a credential cannot reach a reader #10967/feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973
  9. The two destructive confirms are now mutually exclusive on screen — rides along
  10. All 13 locales gain the notice and dialog strings — justified

[FIRST-PRINCIPLES-REVIEWED] 6c1ed0c

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 6c1ed0ce2b57ea015694dd731213b87f5b042646 via the fork AI-review pipeline; updated in place on each push.

Review details

Nothing here blocks the merge, but the stale-baseline fence this PR wires up is inert on the browser's own write path.

FINDING — website/src/components/AutoNudgePopover.tsx:236 — the open-edge latch setFingerprintAtOpen(loop?.message_fingerprint ?? '') has no goal_token fallback, and slack/gateway.py's autonudge_state loop_payload carries nine hand-named keys without goal_token, so once any live frame replaces the record (sseAutomation assigns wholesale, ChatPage prefers liveAutomation) baseline is falsy, expect_fingerprint is never sent, and the fence the new expect_fingerprint=body.get("expect_fingerprint") enables is skipped → Fix: add goal_token to the autonudge_state loop_payload in src/kiro_crew/slack/gateway.py (an untouched file) so normalizeAutomationRecord's existing loop.message_fingerprint ?? loop.goal_token bridge resolves on the live path — or make sseAutomation merge the incoming record over the stored one instead of replacing it.

FINDING — website/src/components/AutoNudgePopover.tsx:1092 — const confirmBlocked = saving || !message.trim() guards only autonudge-confirm-overwrite, while autonudge-decline-overwrite carries no disabled and save() has no in-flight exit (if (writeDisabled) return only) and clears confirmOverwrite after the await, so a decline click inside the request window fires a second PATCH and renders "The stored goal was kept" after the overwrite already landed → Fix: add if (saving) return at the top of save().

[OPUS-REVIEWED] 6c1ed0c

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 16, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from ad57b51 to 7d4d3ac Compare September 16, 2026 22:00
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 16, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from 7d4d3ac to 8ce1a87 Compare September 16, 2026 23:31
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 16, 2026
@rnoack1 rnoack1 changed the title Warn on a redacted save and gate an overwrite in AutoNudgePopover feat(website): warn on a redacted save and gate an overwrite in AutoNudgePopover Sep 17, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from 8ce1a87 to 5e2400b Compare September 17, 2026 00:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 17, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch 2 times, most recently from 62ac6bb to 72eb1f5 Compare September 17, 2026 09:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from 72eb1f5 to 4ee39f0 Compare September 17, 2026 10:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from 4ee39f0 to 3d57bda Compare September 19, 2026 12:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 19, 2026
@rnoack1
rnoack1 force-pushed the split/autonudge-popover-redaction-ui branch from 3d57bda to 76b2814 Compare September 24, 2026 01:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 24, 2026
Adds the redaction notice, overwrite-confirm gate and 409 fingerprint handling.
Locale strings ride together for i18n parity.
@dwu96

dwu96 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days with failing CI. I assessed the blockers and most are mechanical, but the ones that gate readiness need your input:

  • UX BLOCK is an evidence gap only you can close. The verdict is cannot evaluate, and the two missing frames belong in your numbered description gallery: (a) the gate armed after editing both the goal and a numeric field, showing the keep_original_goal / keep_original_goal_start labels "Keep stored goal (save other settings)" and "…and start loop (save other settings)" — attachments 02/03/04/05/12 all show the goal-only labels; (b) the moved-goal confirm on a redacted loop, showing "Sensitive parts of that newer goal are masked here." — 04/05 show that preview only on an unredacted loop.
  • Merge-order premise contradicts the diff. The description says the new arms "stay dormant" before feat(autonudge): scrub loop text on every egress so a credential cannot reach a reader #10967/feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973 "since the fields it reads are simply absent", but the src/kiro_crew/dashboard/handlers/autonudge.py hunk forwards expect_fingerprint and falls back to base's already-served goal_token, and redaction is derived from the [REDACTED: text — so the 409 fence, the amber notice and the confirm gate are all live the day this merges. Is that immediate on-base activation intended (in which case the backend hunk wants declaring), or should the hunk move to feat(autonudge): scrub loop text on every egress so a credential cannot reach a reader #10967?
  • Sparse PATCH is undeclared. Every save on this surface now sends only the fields the user edited, and the base assertion pinning the full body (SessionAutomationPopover.test.tsx:712-714) was rewritten. Please confirm that is intended for every save rather than only the gated ones, and declare it in "What changed".
  • isRedacted heuristic: two remedies, your call. It is permanently ORed with message_redacted rather than used as a fallback, so a goal that legitimately contains the literal [REDACTED: — text this UI says is saved verbatim — shows the redaction warning and the "can't be shown or recovered" confirm on every future edit, and feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973's authoritative flag never overrides it. Either gate the substring arm on message_redacted being absent from the wire, or drop it once feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973 lands; which depends on your stack sequencing.
  • Description/diff mismatch. "types/index.ts … carr[ies] the few type and field additions" — there is no types/index.ts hunk in the pushed revision, and it touches 21 files, not the stated 18. If that edit exists locally and wasn't pushed, the clean-typecheck claim was measured against a different tree than CI is building.

For reference, these blockers looked mechanical and are not what I'm asking you for — they can be cleared once the above is settled:

  • Rebase onto current main (the PR is CONFLICTING and not auto-rebaseable).
  • Frontend Tests (3) — settingsRegistry.test.ts anti-stale guard, which prints its own remedy (npm run gen:settings).
  • Frontend Tests (2) — ChatPanel.railRegistry.test.tsx, where chat.double-click-to-edit-your-messages has no page tag. Neither that test nor the registry is touched by this PR, so it reads as base drift a rebase should clear.
  • The two GPT 5.6 blocking findings on AutoNudgePopover.tsx:332 (tokenless live frame sends no baseline) and :395 (numeric edit during an in-flight PATCH is discarded).

When you've addressed the decisions above, the pipeline will re-assess on its next cycle. Add pr-no-autofix if you'd prefer no automated involvement at all.

Copy link
Copy Markdown
Contributor

PR triage (2026-10-05): OVERLAPPING, needs REBASE plus a merge-order discussion

I compared head 6c1ed0ce2b against the merge base f6d8b7f8c and against current origin/main ef61a9aaf6, which is 1335 commits ahead. The PR does not merge cleanly: git merge-tree reports conflicts in AutoNudgePopover.tsx, 13 locale files and SessionAutomationPopover.test.tsx.

What is already on main and what is not

  • feat(autonudge): refuse a stale-baseline update and detect a resubmitted projection #10973 (merged PR) already ships the store fence: autonudge_service/mutations.py:571 compares expect_fingerprint against goal_token, and autonudge_authz.py:794-801 maps a mismatch to a 409. That covers only part of this PR.
  • dashboard/handlers/autonudge.py on main still does not forward expect_fingerprint in api_autonudge_update (around line 1082). This PR's three-line hunk is still the only thing that wires the browser path to the fence.
  • Main has no message_fingerprint, message_redacted, overwrite gate or redaction notice in website/src. The frontend goal of this PR is still undelivered.

Overlap

Breaking change / P0: none found. The new PATCH field is optional, and the sparse PATCH relies on the existing omitted-means-unchanged behaviour. The open GPT and Opus findings stand, and I am not repeating them here: a tokenless autonudge_state frame (main's slack/gateway.py still sends no goal_token) and a re-entrant save(). Neither one regresses main, because main has no fence on this path at all.

Recommendation: rebase onto main, correct the merge-order paragraph, settle the order with #10967 and #16352, then continue development. Do not close this PR.

@buluoray

Copy link
Copy Markdown
Contributor

Taking this over in #19592 since it has been idle; you are credited as co-author on the commits. Thanks for the groundwork.

@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you @rnoack1 for this work on the auto-nudge popover.

Closing this as superseded by #19592 (c6d413839), merged on main. Its body says "Supersedes #11027" and credits you as co-author.

What landed: the overwrite gate (the stale-goal 409 is now reachable from the goal popover).
What did not land: the warning on a redacted save. AutoNudgePopover.tsx on main (74a249d48) has no isRedacted / [REDACTED: handling.

Your branch is kept. That warning would make a good small follow-up PR, if you want to open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge needs-author-decision PR blocked on author input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants