Repository navigation
Conversation
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/components/AutoNudgePopover.tsx:332 -- A tokenless live frame disables stale-write protection
BLOCKING -- website/src/components/AutoNudgePopover.tsx:395 -- Numeric edits made during saving are discarded
[BLOCK-MERGE] 6c1ed0c Adjudication (Opus 5) — is blocking on each finding proportionate?F1 — HIGH (silent, irreversible overwrite of another writer's goal text). F2 — LOW (a re-typeable number lost, stored state uncorrupted). 🏷️ Fenced finding(s) machine-flagged as likely edge caseThe security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override recorded by a repository writer, who must independently verify a rationale before recording it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop. (This lane's comment deliberately carries no override command.)
|
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing screenshots of the "(save other settings)" keep-stored button labels and the redacted moved-goal preview line. Evidence gaps
Watch
[UX-REVIEWED] 6c1ed0c |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Redaction inferred from a Watch
Suggestions
[DESIGN-REVIEWED] 6c1ed0c |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The description says the new arms "stay dormant" before #10967, but the diff itself activates all three on base — and ships an undeclared backend change. Not justified as shipped
What this change shipsInventory (10 items) — 6 justifiedIntent: stop the goal popover from silently overwriting a goal changed elsewhere and from hiding that a saved goal was redacted — a FIX (wiring the store's existing CAS fence to the browser path, plus guard UI).
[FIRST-PRINCIPLES-REVIEWED] 6c1ed0c |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNothing here blocks the merge, but the stale-baseline fence this PR wires up is inert on the browser's own write path. FINDING — website/src/components/AutoNudgePopover.tsx:236 — the open-edge latch FINDING — website/src/components/AutoNudgePopover.tsx:1092 — [OPUS-REVIEWED] 6c1ed0c |
ad57b51 to
7d4d3ac
Compare
7d4d3ac to
8ce1a87
Compare
8ce1a87 to
5e2400b
Compare
62ac6bb to
72eb1f5
Compare
72eb1f5 to
4ee39f0
Compare
4ee39f0 to
3d57bda
Compare
3d57bda to
76b2814
Compare
Adds the redaction notice, overwrite-confirm gate and 409 fingerprint handling. Locale strings ride together for i18n parity.
|
🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days with failing CI. I assessed the blockers and most are mechanical, but the ones that gate readiness need your input:
For reference, these blockers looked mechanical and are not what I'm asking you for — they can be cleared once the above is settled:
When you've addressed the decisions above, the pipeline will re-assess on its next cycle. Add |
|
PR triage (2026-10-05): OVERLAPPING, needs REBASE plus a merge-order discussion I compared head What is already on main and what is not
Overlap
Breaking change / P0: none found. The new PATCH field is optional, and the sparse PATCH relies on the existing omitted-means-unchanged behaviour. The open GPT and Opus findings stand, and I am not repeating them here: a tokenless Recommendation: rebase onto main, correct the merge-order paragraph, settle the order with #10967 and #16352, then continue development. Do not close this PR. |
|
Taking this over in #19592 since it has been idle; you are credited as co-author on the commits. Thanks for the groundwork. |
|
Thank you @rnoack1 for this work on the auto-nudge popover. Closing this as superseded by #19592 ( What landed: the overwrite gate (the stale-goal 409 is now reachable from the goal popover). Your branch is kept. That warning would make a good small follow-up PR, if you want to open one. |
Problem / Motivation
When a nudge goal is saved, the popover can overwrite a goal the server has since
changed, and it gives no sign when the text it is about to send has been redacted on
the way out. A user editing a goal that another client already updated loses that
update silently, and a redacted message reads as if nothing happened.
This is one unit of a larger change (#7996) split into reviewable pieces.
Why it matters
The overwrite is irreversible from the user's side: the goal they did not write
replaces the one they did, with no record of what was lost. Redaction is the same
problem in reverse — the save appears to succeed while the content that reached the
store is not the content the user typed, so they have no reason to re-check it.
What changed
AutoNudgePopover.tsxgrows an amber redaction notice, an overwrite-confirm gatebound to the goal it was served for, and handling for a 409 carrying a stale
baseline fingerprint. A confirm dialog is raised on either trigger, so a user is
asked before an unsent edit is discarded.
autoNudgeLoop.ts,types/index.tsandmonitoring/automation.tscarry the fewtype and field additions the component needs. These are declared here rather than
imported, so this unit compiles against
mainalone.translation data and rides together because the i18n gate checks locale parity.
Merge order: the backend that serves
message_fingerprintand the redaction flagships in #10967 and #10973. Merged before those, this unit renders correctly but the
new arms stay dormant, since the fields it reads are simply absent. It does not
break existing behaviour in that state.
Tests
AutoNudgePopover.test.tsx— 66 tests pass, covering the redaction notice, theoverwrite-confirm gate on both triggers, the 409 fingerprint path and the existing
goal-persistence and countdown behaviour.
Typecheck is clean for every file this unit touches: the 9 files
tsc -breportsare pre-existing base-side errors in
src/stories/*and two components with missingdependencies, and the intersection with this unit's 18 changed files is empty. Both
i18n gates pass.
Two test blocks are held back to keep this unit under the review size cap, and open
as a follow-on against this same file once it lands:
AutoNudgePopover numeric seeding while openandthe keep-stored arm reports what actually happened. Theyare deferred, not dropped.
Screenshots
Every new user-visible state in this unit, captured in the popover at 420px.
Remaining states: dismiss warnings, post-save notices, paused-loop labels, 409 reload (8 frames)