Repository navigation
fix(lint): drop four unused eslint-disable directives - #11129
helenastafford wants to merge 1 commit into
Conversation
Frontend Lint & Type Check fails on main: `eslint . --max-warnings 0` reports four "Unused eslint-disable directive" warnings (two no-console in electron/, one no-useless-escape and one no-console in scripts/), reproduced on pristine origin/main. Recent changes removed the code the directives guarded without removing the directives; the zero-warning gate turns that into a red main for every PR. Mechanical fix: `eslint . --fix` (reportUnusedDisableDirectives), nothing else touched. Verified `eslint . --max-warnings 0` passes after.
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] 0dac457 |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Diagnosis is wrong: the guarded WatchThe description claims "recent changes removed the code those directives guarded," but each removed directive sits directly above a still-present Suggestions
[DESIGN-REVIEWED] 0dac457 |
First Principles Review (Fable 5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK No gate lints these files: CI runs Not justified as shipped
What this change shipsInventory (3 items) — 0 justifiedIntent: get main's frontend lint gate green again by deleting four unused eslint-disable comments — a FIX.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 0dac457 |
|
Closing as unnecessary — the First Principles finding is correct. The premise was a misdiagnosis on my side: I reproduced the "red main" with Withdrawing rather than reworking: the directives are live documentation for a future coverage widening, and deleting them (plus the beheaded rationale comment this diff left behind) makes things worse, not better. |
Summary
Main is red on "CI / Frontend Lint & Type Check":
eslint . --max-warnings 0reports four Unused eslint-disable directive warnings (electron/permission-handler.js:194,electron/window-lifecycle.js:1535,scripts/i18n-plural-codemod.mjs:97,scripts/precompress.mjs:148) — reproduced on pristine origin/main. Recent changes removed the code those directives guarded without removing the directives, and the zero-warning gate turns that into a red main for every open PR.Fix
Mechanical:
eslint . --fix(viareportUnusedDisableDirectives), removing exactly the four stale directives. Verifiedeslint . --max-warnings 0passes after; no behavior change possible (comments only).Pattern harvest
Rule candidate: none needed at the code level —
reportUnusedDisableDirectivesalready catches the class; what failed is the process gap (third individually-green-merges-collide breakage on this repo in four days: #10248's fence entry, #10301's test contract, now this). A merge queue retesting each PR against post-merge main catches all three.First observed on PR #9969's CI; reproduced on pristine main.