Repository navigation
Conversation
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing stills of the Stay/Close Window confirmation (both copy variants) and the macOS Window menu's new Close Window ⌘W entry. Evidence gaps
Watch
Suggestions
[UX-REVIEWED] ff47b09 |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS This intentionally reverses the pinned #4608/#9555 Cmd+W-closes-session decision, and the PR itself says it must not merge without maintainer sign-off. Watch
Suggestions
[DESIGN-REVIEWED] ff47b09 |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Fable 5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The macOS Cmd+W/⌥⇧W swap reverses the recorded #4608 decision with no accepted RFC — the description itself asks a maintainer to decide it. Not justified as shipped
What this change shipsInventory (9 items) — 4 justifiedIntent: let macOS users close the focused dashboard window with Cmd+W (#11393) — a FIX, carrying two CI-unwedge riders.
Blockersproduct-shape change without accepted RFC — the default meaning of Cmd+W on macOS. The diff deletes the pin "macOS keeps the stock Window menu (Minimize, Zoom, Front — no Close entry, so Cmd+W reaches the renderer)" and rewrites the test citing #4608; the description says "Maintainer decision requested: this intentionally reverses the macOS Cmd+W-closes-session decision recorded in #4608/#9555 … Please confirm … before merge". The base RFC list (all 50 entries read) names no RFC covering desktop shortcuts or window close, so the proposal has no recorded decision; the requested decision also covers the new clean-window confirmation (item 3). [FIRST-PRINCIPLES-REVIEWED] ff47b09 |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsThe candidate list found no candidates. My independent examination confirms the substantive changes are sound:
No grounded, reachable defect surfaced in the changed lines to add under Step 2. No findings. [OPUS-REVIEWED] ff47b09 |
77898c7 to
e1ddef2
Compare
|
fixed
|
|
fixed
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
fixed
|
|
Native runtime evidence for the macOS Window menu and close behavior at The actual Electron 43.2.0 Nine native checks pass, including Stay preserving three browser pages and their input values plus an attached CDP owner, explicit consent releasing owners before destroying pages, main-window hide-to-tray, and a real native dialog cancelling to Stay. This is executable functional evidence; no new menu screenshot is claimed. |
e1ddef2 to
64b2411
Compare
|
fixed
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
rebutted
|
|
needs-a-decision
|
|
needs-a-decision
|
|
rebutted
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
needs-a-decision
|
|
UX evidence gap — native confirmation variants at Maintainers: please decide whether the supplied executable native text evidence is acceptable without new dialog screenshots. Both detail variants, Stay/default/cancel, explicit close, and actual native dialog cancellation were exercised. The PR also records preservation with a busy renderer and a 20-second unload handler. These results verify behavior; they do not claim a visual inspection. No additional screenshots are being supplied. |
|
UX evidence gap — native Window menu at Maintainers: please decide whether the actual Electron Menu role/label/accelerator transcript and native performClose: execution are acceptable evidence for the added Close Window Cmd+W command alongside Minimize, Zoom and Bring All to Front. No new menu image is provided. The existing shortcut-reference image remains, and the visual menu requirement is explicitly unresolved rather than self-waived. |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive with a merge conflict against
To be clear about what I am not saying: nothing here looks wrong. CI is otherwise green, Opus found no blocking findings, and your dispositions already ask maintainers these exact questions. The PR is waiting on an answer, not on work. Once the shortcut decision is recorded — or those two source PRs land and this branch rebases — the pipeline will re-assess on its next cycle. Add |
|
PR triage (2026-10-05), checked against
|
|
Thank you @didhd for the thorough work, especially the unsaved-input protection and the real Electron reproduction. We are closing this PR because Cmd+W on macOS is now intentionally the close-session shortcut (from #9555), and this change would reverse that without a design decision; the bundled backend fixes have also already landed on main. The window-close problem stays tracked in #11393. A small follow-up that adds a Close Window item on Cmd+Shift+W to the macOS Window menu, matching the Ctrl+Shift+W choice on Windows/Linux, would be very welcome. |
Problem / Motivation
On macOS, Cmd+W does not close the focused dashboard window as requested in #11393. The Window menu deliberately leaves the chord to the renderer for session close; it has no native Close command.
CI also inherited Fargate protocol failures (#11417) and ledger test fixtures that no longer satisfy the schema on
main(#11439/#11443). These backend failures also prevent Coverage Gate from completing.Why it matters
The standard macOS window-close shortcut should follow the close button even while the dashboard is loading or its shortcuts are disabled. Closing a secondary window must not silently discard unsaved editor or embedded-browser input.
What changed (motivation → approach → change)
Add Electron's native Close role on Cmd+W to the macOS Window menu in
website/electron/app-menu.js, preserving Minimize, Zoom, and Bring All to Front. The main dashboard follows its existing hide-to-tray handler, including native fullscreen exit; its gateway and sessions remain alive.In
website/electron/window-lifecycle.js, show a native Stay / Close Window confirmation before closing every secondary dashboard window, including a clean or unresponsive dashboard. The detail warns about possible unsaved changes and explains what Stay preserves. It mentions browser pages only when they are open. Stay is both the default and cancel action and preserves every page, control owner, and running browser command channel. Explicit consent releases owners before destroying their pages.Obtain consent before any renderer-close call. Such a call destroys accepting browser pages before a later veto; a dashboard unload handler can also time out and be destroyed before it vetoes. A real Electron 43.2.0 regression reproduced this with a 20-second unload handler: the window disappeared after about one second without a dialog. Remove the dashboard unload probe and its listeners. The trade-off is a confirmation even for clean secondary windows. Main-window hiding and app quit keep their existing paths.
Coalesce pending close requests and temporarily refuse creation of new browser pages until the decision completes. Retain the dashboard WebContents reference through teardown, and guard browser-panel, theme, maximize, and fullscreen callbacks when its view has lost that reference.
Advertise Option+Shift+W for macOS session close in
website/src/lib/shortcutRegistry.tsand stop matching Cmd+W in the renderer. Inwebsite/src/hooks/useKeyboardShortcuts.ts, apply the browser-reserved hint only to primary-modifier chords. Windows/Linux retain Ctrl+W for sessions and Ctrl+Shift+W for windows.Cover menu ownership, shortcut matching, confirmation, cancellation, teardown ordering, and renderer lifetime in the Electron tests and
website/src/test/shortcutRegistry.test.ts. Update the desktop README and dashboard specification.Include the minimal compatibility repair from fix(cloud): bring the Fargate engine up to the widened LaunchEngine protocol #11422 by
pepmach(ab31b00b):src/kiro_crew/cloud/fargate_engine.pyaccepts the existinglogin_targetprotocol keyword and supplies the handle'serrorfield. Default sign-in remains immediate; unsupported named identities return a refusal. Updatetest/test_fargate_launch_engine.pyanddocs/system-specs/modules/cloud.md. Fargate is currently unregistered in the shipped provider registry.Align ledger test writers with the existing schema using fix(ledger): make the test writers satisfy the entry registry #11445 by
chenmingwei23(b03365a4):test/test_ledger_kinds.py,test/test_ledger_retention.py, andtest/test_remove_slot_for_history_key.pysupply required fields and plant deliberately malformed reader input after a valid append. Intest/test_ledger_types.py, use the validcrew/reporttype withsrc="crew:qa". Production ledger validation is unchanged.Maintainer decision requested: this intentionally reverses the macOS Cmd+W-closes-session decision recorded in #4608/#9555. #11393 explicitly asks for native window close, but does not itself establish a maintainer-approved replacement session shortcut. Please confirm Cmd+W for the focused window and Option+Shift+W for macOS session close before merge, including the per-platform difference, discoverability, existing custom Cmd+W bindings, and confirmation on clean secondary windows. The title describes a change rather than claiming macOS previously behaved this way.
Tests
ff47b098finished successfully: backend lint/types, all four Python 3.12 shards, all eight Windows shards, all four frontend shards, Electron, E2E, bundle-size, and Coverage Gate passed. Backend coverage is 92.06% and frontend coverage is 93.38%; both project and per-file gates passed. Desktop builds also passed on macOS, Linux, and Windows. The previous frontend shard 3 worker termination did not recur. UX/First Principles decisions and required maintainer review remain outstanding.0c87efad1and before the compatibility repair. After the repair, 93 Fargate/cloud-launch tests passed, including both failed nodes and unsupported/default identity cases.04727ebe0fand the preceding PR head: missing required opened/turn/tool fields and a malformed crew type. 964 ledger/core/emitter/reference tests passed after the fixture repairs. The unrelated live-ledger stress test hits this macOS host's 256-file limit on clean base too; it passes on base and this branch with the pytest subprocess limit set to 4,096. No assertions were skipped.mypy --platform linux(1,614 source files) passed. Changed Python files pass Black. The unusedjsonimport is fixed by inherited upstream fix(dashboard): drop the unused json import left by #9840 #11415.performClose:action, and a real native dialog abort resolving to Stay. Assertions check both dialog descriptions. No gateway requests were made. A separate 22-second observation confirms the slow-unload regression preserves the window and draft on Stay, with zero unload calls.mainresolves the previous Bundle Size Gate failure.ff47b098and found no Critical/High blockers. The custom Cmd+W-binding migration remains a product-decision advisory. The earlier unverified slow-unload concern was reproduced and repaired as described above.Manual verification
An isolated macOS Electron harness loads the production menu and
createWindowLifecyclefactory. It sends the nativeperformClose:action used by the menu role and verifies the resulting window, renderer, form-value, control-owner, and channel state. Dialog responses are controlled for the Stay/Close cases; a separate real native dialog validates BaseWindow compatibility and the cancel result. The existing fullscreen-exit tests cover hide-to-tray behavior.Runtime menu output, read from the actual Electron
Menu:Runtime results:
Slow-unload regression, using a real visible secondary dashboard whose
beforeunloadhandler would run for 20 seconds before vetoing:Screenshots / video
Native menu verification is supplied as the executable runtime transcript above; no additional screenshots are supplied. Existing macOS shortcut-reference evidence:
Close session is advertised as Option+Shift+W
Related Issues
Addresses #11393. Changes the macOS shortcut decision associated with #4608/#9555, subject to the maintainer confirmation requested above.
Pattern harvest
Rule candidate: review-prompt
Pattern: A WebContents close can destroy accepting or unresponsive renderers before an unload veto arrives. Obtain explicit window-wide discard consent before teardown and retain stable WebContents references through destruction.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Fixes #11393