Skip to content

docs(rfc): agent self-tagging status in-progress -> partial after #7779 - #11409

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
jeeshofone:docs/rfc-agent-self-tagging-partial
Sep 17, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
jeeshofone:docs/rfc-agent-self-tagging-partial

Conversation

@jeeshofone

Copy link
Copy Markdown
Contributor

Problem / Motivation

docs/request-for-change/rfc-agent-self-tagging.md is on main (#11175, merged 7ae579396) with status: in-progress and an index row that says "Nothing on main; implementation is open PR #7779". #7779 merged as 780e75e2d thirteen minutes earlier, so both statements are false on the base branch the review lanes read.

Why it matters

The First Principles lane reads the RFC status from the base commit as the record of a product-shape decision. A row that says nothing is on main, for a directive that is on main, sends the next reader to an open PR that no longer exists and mis-states which phases remain.

What changed (motivation -> approach -> change)

Status moves in-progress -> partial, the index's term for some phases on main and the rest open. The README row now names what shipped in #7779 (the chat_tag directive in mcp_tools/control.py, applied in dashboard/session_directive_apply.py; the protected grants store dashboard/chat_tag_grants.py under the tag-grants leaf; the [BOARD] context line in context.py; the per-tag agent policy on the tag PATCH; the strict-boolean status validation) and what is open on #7774 (the tag-manager control for the per-tag policy, provenance-required minting from open question 3, and the v2 scope). audited-at is the merge commit 780e75e2d, last-audited is today, the Current-state section says it describes the pre-#7779 state, and the "why this RFC" paragraph no longer calls the document in-progress.

This is the update #11175 would have carried had it not merged four minutes before the push that made it; the commit is the same diff rebased onto main.

Tests

N/A. Documentation only. scripts/docs_lint.py, scripts/check_comment_history.py and scripts/check_brand_name.py pass on the branch.

Manual verification

Each module the row names was checked on origin/main at 780e75e2d: chat_tag_grants.py exists, chat_tag appears in mcp_tools/control.py, [BOARD] appears in context.py. The .github/ diff against main is empty.

Related Issues

Part of #7774. Follows #7779 and #11175.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@jeeshofone
jeeshofone requested review from a team and pepmach September 17, 2026 00:21
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 1e777de7a95269ad7e10ce1eb9de6fb8864045d8 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify 780e75e2d is #7779's actual merge commit — every audited artifact the row names already checks out on main.

[DESIGN-REVIEWED] 1e777de

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 1e777de7a95269ad7e10ce1eb9de6fb8864045d8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1e777de

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review (fork) — ✅ no blocking findings

Reviewed 1e777de7a95269ad7e10ce1eb9de6fb8864045d8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1e777de

@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from 6ccedc1 to db508ad Compare September 17, 2026 00:45
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from db508ad to 0063174 Compare September 17, 2026 06:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@jeeshofone

Copy link
Copy Markdown
Contributor Author

Windows shard 3 on 006317464 failed in test_dashboard_chat.py::TestRunChatRefusalFallback::test_pick_during_swap_set_model_await_is_not_reverted with a lock bound to a different event loop. The failure is in the shared slot_switch_session_lock cache, unrelated to this PR's doc-only changes. Filed as #11477. Pushed the same tree to re-run CI.

@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from 0063174 to 0858896 Compare September 17, 2026 07:08
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from 0858896 to 20b2c84 Compare September 17, 2026 08:02
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@jeeshofone

Copy link
Copy Markdown
Contributor Author

Windows shard 4 on 20b2c849b is the #8806 shard-killer (one event_loop finalizer error, 635 collateral Event loop is closed failures). Both review lanes pass. This is the fourth distinct main-side flake on this two-file docs change across three heads (#11265 twice, #11477, #10964, now #8806), so I am leaving this head in place rather than pushing again; a maintainer rerun of the shard or a merge over the known flake both work.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 17, 2026
@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from 20b2c84 to 6c41796 Compare September 17, 2026 15:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@jeeshofone
jeeshofone force-pushed the docs/rfc-agent-self-tagging-partial branch from 6c41796 to 1e777de Compare September 17, 2026 17:45
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@iamwhatever
iamwhatever merged commit f1747dc into kirodotdev:main Sep 17, 2026
90 checks passed
@jeeshofone
jeeshofone deleted the docs/rfc-agent-self-tagging-partial branch September 17, 2026 21:26
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 17, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants