Skip to content

refactor(irq): rename epoch_scoped to resets_on and NMI to IMMEDIATE - #11460

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/observation-resets-on
Sep 18, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/observation-resets-on

Conversation

@chenmingwei23

Copy link
Copy Markdown
Contributor

Problem / Motivation

Two names in the monitor kernel described how it stores things, not what a probe
is reporting. Observation.epoch_scoped was a boolean, and Severity.NMI
borrowed a CPU term. docs/system-specs/modules/monitor-architecture.md layer 3
asked for resets_on and IMMEDIATE instead, and the code had not caught up, so
the spec described a type that did not exist.

Why it matters

Anyone writing a probe reads these names to decide what to pass. epoch_scoped
does not say what an epoch is or why it would scope anything, so choosing between
True and False has to be learned from the kernel's internals. NMI means
nothing unless you know interrupt hardware.

The spec asking for one thing while the code shipped another also made the doc
unsafe to follow: a reader doing what it said would write resets_on= and get a
TypeError. The app-kit reference that third-party app authors copy from carried
the old severity in a worked example, so the misdirection reached outside this
repository.

What changed (motivation → approach → change)

The two names now say what the field decides.

Before After
what clears an entry epoch_scoped: bool = True resets_on: ResetsOn = ResetsOn.REVISION
a comment, which outlives a force-push epoch_scoped=False resets_on=ResetsOn.NEVER
waiting observes nothing further Severity.NMI Severity.IMMEDIATE
the key written to disk "=ready", "~comment:<id>" "=ready", "~comment:<id>" (unchanged)

resets_on is an enum, not a boolean under a nicer name. The field answers what
clears this
, and a boolean can only answer yes or no. Read as a flag,
resets_on=False would have to mean "does not reset on -- nothing", which is the
opposite of what NEVER says.

The last row is what makes this a rename rather than a migration. The kernel never
wrote either name to disk. It writes one of two sentinel characters,
_EPOCH_SENTINEL "=" and _STICKY_SENTINEL "~", in front of the probe's own
key, and _dedupe_key is the single place that reads the field. Severity is never
serialized at all. Both sentinels keep their values here, so every state document
already on disk still means what it meant, and no armed watch re-reports an
anomaly it has already delivered.

brief stays ahead of resets_on in the signature, which is not the order the
spec sketched. Both fields have defaults, so moving resets_on forward buys
nothing, and it would silently redirect every existing three-positional call
rather than fail at it.

The prose moved in the same commit: the interrupt-concept table in
src/kiro_crew/irq.py, the wake-reason list in src/kiro_crew/probes/gh_pr.py,
four specs, and the app-kit example. Five test names carried the retired field
name and were renamed, and the four spec citations of those names were updated
with them. The spec section that asked for the rename now describes the type that
exists.

Tests

No behavior changed, so no new test. The existing pins were rewritten onto the new
names and re-run:

  • test_irq.py -- the two sentinel key spaces, the epoch wipe, the prune
    asymmetry, the partial fire, and the bypass path, now
    test_immediate_bypasses_the_coalescing_window.
  • test_irq_port_baseline.py -- the ported baseline, including that an IMMEDIATE
    observation skips the coalescing window but still keeps its dedupe mask.
  • test_babysit_pr_watch.py -- the conflict path end to end, and that a
    pre-sentinel key still migrates into the epoch space.

14 targeted node ids pass. isort, black, flake8 and mypy are clean on all five
changed Python files.

Manual verification

Loaded the changed module and read the values back, because a rename either lands
everywhere or breaks at import. Severity is WAKE, TERMINAL, IMMEDIATE;
ResetsOn is REVISION, NEVER; Observation's fields are
key, severity, brief, resets_on. A default observation still keys as =k and a
NEVER one as ~k, which is how a persisted alerted map is keyed today.

Also checked for the old names outside the repository, since an installed copy and
a repository copy are two different artifacts. The one hit is a stale
pre-refactor snapshot of pr_watch.py sitting in an installed crons directory,
referenced by no registered cron job; the driver on main is a 53-line adapter
that names neither old name, so the copy-then-arm recipe cannot carry either name
into a user's tree.

Related Issues

no linked issue: the ask is recorded in
docs/system-specs/modules/monitor-architecture.md layer 3 and in
docs/request-for-change/rfc-consolidated-monitor.md, which tracks this work by
PR rather than by issue (tracking-issues: []).

Related, and in flight on the same file:
#11455 (feat(monitoring): retire a watch whose verdict stopped moving) also edits
docs/system-specs/modules/monitor-architecture.md. The two do not overlap -- that
PR's hunks are at lines 327, 491 and 526 plus a layer-5 table cell, and this one
owns 235-268 (layer 3's Observation section) plus name-only fixes at 126 and 307.
Whichever merges second takes a trivial rebase. Neither depends on the other:
this PR renames the irq.Observation / irq.Severity names and touches nothing
under src/kiro_crew/monitoring/, which is where that one works.

Pattern harvest

Rule candidate: review-prompt

Pattern: a retired name's prose sweep run with a case-sensitive, word-boundary
grep reports clean while three spellings survive it -- a capitalized adjective at
the start of a comment (Epoch-scoped keys are bounded...), an
identifier-internal fragment (test_an_nmi_bypasses..., which \bnmi\b cannot
match because _ is a word character), and a test name that only a spec cites.
All three were present here and each was found only after the first sweep read
clean. Sweeping a retired name needs a case-insensitive substring pass, plus a
check that every test name cited in prose still resolves to a def in the tree.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@chenmingwei23
chenmingwei23 requested review from a team and hoang-phan98 September 17, 2026 05:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 17, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Intent: Make the monitor kernel's Observation type carry the names that describe the condition a probe reports, which is what docs/system-specs/modules/monitor-architecture.md layer 3 asked for: epoch_scoped: bool becomes resets_on: ResetsOn (REVISION / NEVER), and Severity.NMI becomes Severity.IMMEDIATE. The spec section that asked for it now describes the type that exists.

Not a goal: any behaviour change; any change to the persisted on-disk encoding (_EPOCH_SENTINEL "=" and _STICKY_SENTINEL "~" keep their values, so every state document already written still means what it meant); any change under src/kiro_crew/monitoring/; reordering Observation's positional parameters; renaming the two sentinel constants themselves, whose names track Tick.epoch and the kernel's storage spaces rather than the field a probe sets.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of f92fb3d71774c357260230d3200e40bb26d16dbe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Third-party probes built from the old app-kit example break on Severity.NMI with no deprecation alias — confirm that surface has no external consumers yet.

[DESIGN-REVIEWED] f92fb3d

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of f92fb3d71774c357260230d3200e40bb26d16dbe and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f92fb3d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f92fb3d71774c357260230d3200e40bb26d16dbe: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed f92fb3d71774c357260230d3200e40bb26d16dbe — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f92fb3d

Verdict parsed from the review's SHA-scoped output markers for commit f92fb3d71774c357260230d3200e40bb26d16dbe.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f92fb3d71774c357260230d3200e40bb26d16dbe: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of f92fb3d71774c357260230d3200e40bb26d16dbe — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

One thing to verify: the claim that no installed, registered cron script still constructs Observation(epoch_scoped=...) — the rename ships no deprecation alias, so a stale copy fails at its next tick.

What this change ships

Inventory (6 items) — 6 justified

Intent: make the interrupt kernel's probe-facing names match what the owning spec already recorded (resets_on, IMMEDIATE), so a reader following the spec no longer hits a TypeError — a FIX (spec/code mismatch), asked for by docs/system-specs/modules/monitor-architecture.md layer 3 on the base commit.

  1. Probe authors now write resets_on=ResetsOn.REVISION/NEVER; epoch_scoped= is gone, no alias — justified
  2. Severity.NMI is now Severity.IMMEDIATE; old name gone — justified
  3. New importable ResetsOn enum in irq.__all__ (2 constructing consumers in probes/gh_pr.py, read once in _dedupe_key) — justified
  4. On-disk sentinel keys unchanged, so armed watches do not re-alert after upgrade — justified
  5. Spec section rewritten from "asks for" to "describes", recording the declared brief-before-resets_on order deviation with a fundamental reason (silent redirection of three-positional calls) — justified
  6. Five docs (app-kit worked example, three specs, one RFC context table) and five test names moved onto the new vocabulary — justified

[FIRST-PRINCIPLES-REVIEWED] f92fb3d

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

CI note, not a review item: the three red Backend Tests (Windows) shards on this head are base-owned and already tracked. Recording the classification so nobody re-derives it.

Two distinct signatures, neither in a file this PR touches (this diff is src/kiro_crew/irq.py, src/kiro_crew/probes/gh_pr.py, three test_irq*/test_babysit_pr_watch files, and five docs):

Positive control: the same shard set 3/4/6 is red on unrelated PR #11457 right now, and 1/3/6/8 on #11450.

Neither remedy is available from this branch. A rerun replays the merge ref pinned when the run was created, and these are deterministic validation and assertion failures rather than timeouts, so it fails identically. A rebase has nothing to rebase onto: origin/main is still exactly this branch's base, zero commits ahead. Once #11443 and #11416 land, a rebase picks them up and is the correct medicine.

All five review lanes are green on this head with no items raised: Design PASS, First Principles PASS, UX, GPT 5.6 and Opus 4.8 all success, and zero unresolved threads. No new issue filed, since both signatures already have one.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 17, 2026
@chenmingwei23
chenmingwei23 force-pushed the refactor/observation-resets-on branch from c652e42 to 3f992db Compare September 17, 2026 05:55
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

self-added: no
mechanism: none added; the finding is rebutted as unreachable and no compatibility shim is introduced

  • span=1fc882943d35 -- Public rename breaks deployed probe scripts -- rebutted, not a defect

Outcome: rebutted as NOT A DEFECT, on reachability rather than on cost. A security-class finding cannot converge by deferral or by accepting a real defect as too expensive, so this is argued on whether the trigger exists at all.

The finding needs an external probe that references the retired names and is loaded by the cron runtime. There is no such loader. irq.Probe (irq.py:288) has exactly one subclass, PrWatchProbe (probes/gh_pr.py:303), which a package factory registers internally (probes/init.py:41) and which this same commit rewrites. The cron driver pr_watch.py on main is a 53-line adapter importing only run and PrWatchProbe; it names neither retired symbol, so the documented copy-then-arm recipe cannot carry one into a user tree.

The second half of the finding -- "becomes sticky, suppressing new-revision alerts" -- needs persisted state carrying the old shape. No severity value has ever been serialized. The on-disk encoding is _EPOCH_SENTINEL "=" and _STICKY_SENTINEL "~" (irq.py:134-135), both unchanged here, and _dedupe_key still maps REVISION onto the epoch sentinel. _migrate_key already adopts pre-sentinel keys. Verified against live state documents: an alerted map is keyed "=ready" and "~comment:<id>", never by a field name.

One artifact could have made this reachable and does not: a stale 592-line pre-refactor pr_watch.py sits in an installed crons directory carrying both old names. It is referenced by none of the 13 registered cron script paths, and it is already broken against main's layout independently of this change. The artifact exists; nothing loads it.

The prescribed remedy is the load-bearing reason not to comply. Retaining NMI as an alias is the mechanism withdrawn on this project in #10945: an alias resolved after the gate that decides is a bypass, and making it usable unattended requires auto-approval, which takes the deny list and the audit trail with it. That withdrawal followed six heads and five consecutive security-class findings on a rename that DID have a persisted-name consumer. This rename has none, which is what separates the two cases -- so the fix would import a proven-wrong mechanism to guard a trigger that cannot fire.

Nothing was added to the diff for this finding. A maintainer override follows on this same SHA.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

self-added: no
mechanism: none added; the branch direction stays as written and no validation hook is introduced

  • span=ae75ea4a3275 -- branch _dedupe_key on is ResetsOn.NEVER, or add a __post_init__ isinstance check -- rebutted as unreachable, and the reading is accepted as correct

The reading is right and worth recording. epoch_scoped was the fourth positional parameter and resets_on now occupies that same slot, so a legacy four-positional call Observation("k", Severity.WAKE, "brief", True) would put a bare bool where the enum belongs. _dedupe_key tests is ResetsOn.REVISION, which a bool fails, so it would land in the STICKY space -- the exact inverse of what the old True meant. Keyword callers and Severity.NMI callers fail loudly; this one would not fail at all. Silent wrong-bucket is the worse class, and this lane named the only silent path in the change.

Rebutted on reachability, not on cost. The caller does not exist: irq.Probe (irq.py:288) has one subclass, PrWatchProbe (probes/gh_pr.py:303), registered internally (probes/init.py:41) and rewritten in this same commit with keyword arguments. Every construct site in the diff passes resets_on=ResetsOn.NEVER by keyword or relies on the default. No external probe loader exists, so no four-positional legacy call can arrive.

Declining the validation hook specifically, rather than the reasoning behind it. A __post_init__ that normalizes a bare bool would silently accept the retired calling convention, which is the same post-gate compatibility surface #10945 withdrew for the alias half of this class. Making the wrong shape work quietly is what that withdrawal was about. If a future change introduces a real external probe loader, the honest form is a loud refusal at construction, not a normalization -- and that belongs with the loader that creates the exposure.

The branch direction is left as is ResetsOn.REVISION. Flipping it to is ResetsOn.NEVER would only change which wrong answer an impossible caller receives, so it buys nothing today and would read as a guard against a caller the type system already excludes.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 3f992db: Not a defect, no reachable trigger. irq.Probe has one subclass, PrWatchProbe (probes/gh_pr.py:303), internal and rewritten in this commit; no external probe loader exists. No severity is serialized: disk uses _EPOCH_SENTINEL/_STICKY_SENTINEL (irq.py:134-135) and _dedupe_key still maps REVISION to the epoch sentinel. The one orphan file with the old names is in none of the 13 registered cron paths. The alias prescribed is the post-gate bypass withdrawn in #10945.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@chenmingwei23 marked the gpt AI finding as false positive, not applicable, or explicitly accepted for 3f992dbe5c8516a14971732f5f908ac194f8d36f.

Not a defect, no reachable trigger. irq.Probe has one subclass, PrWatchProbe (probes/gh_pr.py:303), internal and rewritten in this commit; no external probe loader exists. No severity is serialized: disk uses _EPOCH_SENTINEL/_STICKY_SENTINEL (irq.py:134-135) and _dedupe_key still maps REVISION to the epoch sentinel. The one orphan file with the old names is in none of the 13 registered cron paths. The alias prescribed is the post-gate bypass withdrawn in #10945.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@chenmingwei23
chenmingwei23 force-pushed the refactor/observation-resets-on branch from 3f992db to 82e54f5 Compare September 17, 2026 09:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 17, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 17, 2026
chenmingwei23 added a commit that referenced this pull request Sep 17, 2026
The POSIX Backend Tests job splits the full suite into 4 count-balanced
shards (no .test_durations file is committed, so pytest-split falls back
to an even-by-count split) under a 50-minute job cap. The slowest shard
rides the wall: on #11460 shard 1 ran 50.2 min and was cancelled at 99%
with every test passing and zero failures, while shards 2/3/4 ran
36.3/47.1/43.2 min -- three of four within 7 min of the cap. A cancelled
shard reds Coverage Gate and PR Readiness on every full-suite PR.

The ~33-min fixed collection+coverage cost per shard does not divide, so
raising the cap alone would only defer the same hit; more shards is the
lever. This mirrors the Windows backend job, which already runs 8 shards
for the identical count-split reason. A committed .test_durations file was
declined in #8506 over its rewrite-every-refresh cost, so this follows the
shard-count path instead.

Refs #11526
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
NicholasRBowers pushed a commit that referenced this pull request Sep 17, 2026
…11528)

The POSIX Backend Tests job splits the full suite into 4 count-balanced
shards (no .test_durations file is committed, so pytest-split falls back
to an even-by-count split) under a 50-minute job cap. The slowest shard
rides the wall: on #11460 shard 1 ran 50.2 min and was cancelled at 99%
with every test passing and zero failures, while shards 2/3/4 ran
36.3/47.1/43.2 min -- three of four within 7 min of the cap. A cancelled
shard reds Coverage Gate and PR Readiness on every full-suite PR.

The ~33-min fixed collection+coverage cost per shard does not divide, so
raising the cap alone would only defer the same hit; more shards is the
lever. This mirrors the Windows backend job, which already runs 8 shards
for the identical count-split reason. A committed .test_durations file was
declined in #8506 over its rewrite-every-refresh cost, so this follows the
shard-count path instead.

Refs #11526
@chenmingwei23
chenmingwei23 force-pushed the refactor/observation-resets-on branch from 82e54f5 to 147a3bc Compare September 17, 2026 17:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
The kernel's Observation carried two names that described its implementation
rather than the condition a probe reports. `epoch_scoped: bool` said which
bookkeeping bucket an entry fell in; `resets_on` says what clears it. `NMI`
borrowed an interrupt term for what is really an urgency claim. Both names are
what `docs/system-specs/modules/monitor-architecture.md` layer 3 asked for.

`resets_on` is a two-member enum, `ResetsOn.REVISION` and `ResetsOn.NEVER`, not a
renamed boolean. The field answers what clears an observation, and a boolean can
only answer yes or no: read as a flag, `resets_on=False` would have to mean "does
not reset on -- nothing", which is the opposite of what NEVER means.

The persisted encoding is untouched, and that is the load-bearing part.
`_EPOCH_SENTINEL` ("=") and `_STICKY_SENTINEL` ("~") are the characters every
state document under the data home is keyed with, `_dedupe_key` still maps
REVISION onto the first and NEVER onto the second, and no severity value was ever
serialized. So no armed watch re-reports an anomaly it has already delivered.

`brief` keeps its position ahead of `resets_on`, unlike the signature the spec
first sketched. Both fields have defaults, so nothing is gained by moving
`resets_on` forward, and reordering would silently redirect every existing
three-positional call rather than fail at it.

Prose moved with the code: the module header's interrupt-concept table, the
probe's wake-reason list, four specs and the app-kit reference third parties copy
from. Five test names carried the retired field name and were renamed, and the
four spec citations of those names were updated with them.

Refs: docs/system-specs/modules/monitor-architecture.md (layer 3)
Refs: docs/request-for-change/rfc-consolidated-monitor.md
@chenmingwei23
chenmingwei23 force-pushed the refactor/observation-resets-on branch from 147a3bc to f92fb3d Compare September 17, 2026 22:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@bolichen97
bolichen97 merged commit 9e472f9 into main Sep 18, 2026
86 checks passed
@bolichen97
bolichen97 deleted the refactor/observation-resets-on branch September 18, 2026 00:29
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 18, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…irodotdev#11528)

The POSIX Backend Tests job splits the full suite into 4 count-balanced
shards (no .test_durations file is committed, so pytest-split falls back
to an even-by-count split) under a 50-minute job cap. The slowest shard
rides the wall: on kirodotdev#11460 shard 1 ran 50.2 min and was cancelled at 99%
with every test passing and zero failures, while shards 2/3/4 ran
36.3/47.1/43.2 min -- three of four within 7 min of the cap. A cancelled
shard reds Coverage Gate and PR Readiness on every full-suite PR.

The ~33-min fixed collection+coverage cost per shard does not divide, so
raising the cap alone would only defer the same hit; more shards is the
lever. This mirrors the Windows backend job, which already runs 8 shards
for the identical count-split reason. A committed .test_durations file was
declined in kirodotdev#8506 over its rewrite-every-refresh cost, so this follows the
shard-count path instead.

Refs kirodotdev#11526
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…irodotdev#11460)

The kernel's Observation carried two names that described its implementation
rather than the condition a probe reports. `epoch_scoped: bool` said which
bookkeeping bucket an entry fell in; `resets_on` says what clears it. `NMI`
borrowed an interrupt term for what is really an urgency claim. Both names are
what `docs/system-specs/modules/monitor-architecture.md` layer 3 asked for.

`resets_on` is a two-member enum, `ResetsOn.REVISION` and `ResetsOn.NEVER`, not a
renamed boolean. The field answers what clears an observation, and a boolean can
only answer yes or no: read as a flag, `resets_on=False` would have to mean "does
not reset on -- nothing", which is the opposite of what NEVER means.

The persisted encoding is untouched, and that is the load-bearing part.
`_EPOCH_SENTINEL` ("=") and `_STICKY_SENTINEL` ("~") are the characters every
state document under the data home is keyed with, `_dedupe_key` still maps
REVISION onto the first and NEVER onto the second, and no severity value was ever
serialized. So no armed watch re-reports an anomaly it has already delivered.

`brief` keeps its position ahead of `resets_on`, unlike the signature the spec
first sketched. Both fields have defaults, so nothing is gained by moving
`resets_on` forward, and reordering would silently redirect every existing
three-positional call rather than fail at it.

Prose moved with the code: the module header's interrupt-concept table, the
probe's wake-reason list, four specs and the app-kit reference third parties copy
from. Five test names carried the retired field name and were renamed, and the
four spec citations of those names were updated with them.

Refs: docs/system-specs/modules/monitor-architecture.md (layer 3)
Refs: docs/request-for-change/rfc-consolidated-monitor.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants