Repository navigation
fix(acp): name the seam, not the launcher, in spawn diagnostics - #11575
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the bare-interpreter reversal ( Suggestions
[DESIGN-REVIEWED] ab09e7a |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsFINDING -- src/kiro_crew/acp/client.py:464 -- relative overrides fail the |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings block; one advisory finding. FINDING — src/kiro_crew/acp/client.py:471 — [OPUS-REVIEWED] ab09e7a |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The "mislabeling" defect has no checkable provenance, and the collapse erases which installed copy launched — the very record the base pinned the suffix to keep. Not justified as shipped
What this change shipsInventory (6 items) — 3 justifiedIntent: make spawn/stderr log labels name the adapter rather than its entry-script path — a FIX by framing, cosmetic in effect.
Counts run: [FIRST-PRINCIPLES-REVIEWED] ab09e7a |
2250440 to
c608167
Compare
c608167 to
e46c027
Compare
e46c027 to
38a897e
Compare
An adapter installed as a Node package resolves to its own dist/index.js, so the spawn label read "claude-agent-acp via .../dist/index.js" -- the packaging, not the adapter. Suppressing the suffix on the basename alone also erased the one record of which build launched whenever CLAUDE_AGENT_ACP_BIN or CODEX_ACP_BIN pointed the seam at a shim or a vendored build. Restrict the suffix to the adapter package's own entry under its own scope, and keep the full path for any index.js that an override supplied or that is not that package's entry. The stderr label is the one the spawn resolved, so the shared kiro spawn and drain path is unchanged.
38a897e to
ab09e7a
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, SAST clean (the single Semgrep annotation on this head SHA is GitHub's own notice-level ubuntu-latest runner-image banner at path .github, not a finding), security checklist all-NO, AI reviewers green. Design-doc gate clean. Category: the spawn diagnostic label named a packaged dist/index.js rather than the seam; the fix suppresses the path only for the adapter's own package entry and keeps it for an operator override or any other script. Log-label only. CodeQL is not applicable on this fork PR (default-setup emits no check-run); SAST coverage is Semgrep only, latest run success with no real findings.
…dotdev#11575) An adapter installed as a Node package resolves to its own dist/index.js, so the spawn label read "claude-agent-acp via .../dist/index.js" -- the packaging, not the adapter. Suppressing the suffix on the basename alone also erased the one record of which build launched whenever CLAUDE_AGENT_ACP_BIN or CODEX_ACP_BIN pointed the seam at a shim or a vendored build. Restrict the suffix to the adapter package's own entry under its own scope, and keep the full path for any index.js that an override supplied or that is not that package's entry. The stderr label is the one the spawn resolved, so the shared kiro spawn and drain path is unchanged. Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com>
Problem / Motivation
Both vendored adapters resolve to
dist/index.jsthrough node, so the spawn label readclaude-agent-acp via .../dist/index.js-- the packaging, not the adapter -- and a bare interpreter added nothing useful. Suppressing that suffix on the basename alone also erased the one record of which build launched, whenever the override pointed the seam at a shim or a vendored build.Why it matters
Spawn diagnostics name the packaging instead of the adapter, so logs and stderr prefixes mislead anyone tracing which engine actually launched.
What changed (motivation → approach → change)
Observed symptom → root cause → change: the label collapsed any script named
index.jswithout asking whether it was the adapter package's own entry or one the operator's override supplied. Collapse the suffix only for that package entry under its own scope, and keep the full path for every otherindex.js; the stderr label remains the one the spawn already resolved, so the shared kiro path is untouched.Backwards compatibility
Compatible: only diagnostic label text changes; no accepted input, configuration, or API contract is rejected, renamed, or removed.
Tests
test/test_acp_spawn_label.py-- 14 passed, including rows that pin the kept path for an override-suppliedindex.jsand for a script that is not the adapter's packaged entry.Manual verification
N/A -- unit coverage sufficient: the label-resolution branches are exercised by the spawn-label tests above.
Related Issues
N/A -- no existing issue covers adapter mislabeling in spawn diagnostics.
Pattern harvest
Rule candidate: review-prompt
Pattern: a diagnostic label must name the actor, not the launcher binary the actor happens to run under.
Checklist
Contribution License Agreement
N/A -- template placeholder; no CLA wording is supplied.