Repository navigation
style(test): black-format test_chat_tags.py to clear the main ratchet drift - #11621
Conversation
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsThe diff is a pure formatting change — wrapping a test function signature across multiple lines, with no change to logic, parameters, or behaviour. The candidate list contains no candidates. Nothing survives Step 1, and Step 2 offers no grounded finding. No findings. [OPUS-REVIEWED] af825c9 |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] af825c9 |
f4b3726 to
d602c77
Compare
|
Shards 2 and 4 on |
… drift The Main Ratchet Audit flags test/test_chat_tags.py as a new black offender on main (kirodotdev#11616). The file is not in the black baseline, so the ratchet expects it formatted; this reformats it and changes no behaviour. Closes kirodotdev#11616
d602c77 to
af825c9
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: black-formats one argument list in test/test_chat_tags.py to clear the main formatting ratchet -- test-only file, zero runtime code touched, no assertion or behaviour change. CodeQL is not applicable on this fork PR (default-setup emits no check-run); SAST coverage is Semgrep only, latest run success with 0 findings (the single annotation is GitHub's own ubuntu-latest runner-image notice at .github:1, not a Semgrep finding).
… drift (kirodotdev#11621) The Main Ratchet Audit flags test/test_chat_tags.py as a new black offender on main (kirodotdev#11616). The file is not in the black baseline, so the ratchet expects it formatted; this reformats it and changes no behaviour. Closes kirodotdev#11616
Problem / Motivation
The Main Ratchet Audit reports
ratchet-gatesred on main at2627b0407(#11616):test/test_chat_tags.pyis a new black offender. The file is not in.github/black-baseline.txt, so the gate expects it formatted, and one signature added in #7779 runs to 106 columns.Why it matters
Every PR runs the gate against
merge(branch, main), so the red is inherited by unrelated PRs whose diff touches the file next, and the audit issue stays open until main is clean.What changed (motivation → approach → change)
black --target-version py310 test/test_chat_tags.pyfrom the repo root, nothing else. The only change is wrapping the parameter list oftest_status_patch_without_agent_keeps_the_recorded_policyonto its own lines; no test logic moves.Tests
No new tests: the change is formatting only.
test/test_chat_tags.pypasses (121 tests) after the reformat, andscripts/check_black_formatting.pypasses with this file in scope.Manual verification
N/A. The black gate script and the test module are the whole surface.
Screenshots / video
N/A. No UI change.
Related Issues
Closes #11616
Pattern harvest
Not generalizable: a single long signature landed unformatted in a non-baselined file.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement