Skip to content

style(test): black-format test_chat_tags.py to clear the main ratchet drift - #11621

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
jeeshofone:fix/black-test-chat-tags
Sep 18, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
jeeshofone:fix/black-test-chat-tags

Conversation

@jeeshofone

Copy link
Copy Markdown
Contributor

Problem / Motivation

The Main Ratchet Audit reports ratchet-gates red on main at 2627b0407 (#11616): test/test_chat_tags.py is a new black offender. The file is not in .github/black-baseline.txt, so the gate expects it formatted, and one signature added in #7779 runs to 106 columns.

Why it matters

Every PR runs the gate against merge(branch, main), so the red is inherited by unrelated PRs whose diff touches the file next, and the audit issue stays open until main is clean.

What changed (motivation → approach → change)

black --target-version py310 test/test_chat_tags.py from the repo root, nothing else. The only change is wrapping the parameter list of test_status_patch_without_agent_keeps_the_recorded_policy onto its own lines; no test logic moves.

Tests

No new tests: the change is formatting only. test/test_chat_tags.py passes (121 tests) after the reformat, and scripts/check_black_formatting.py passes with this file in scope.

Manual verification

N/A. The black gate script and the test module are the whole surface.

Screenshots / video

N/A. No UI change.

Related Issues

Closes #11616

Pattern harvest

Not generalizable: a single long signature landed unformatted in a non-baselined file.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@jeeshofone
jeeshofone requested review from a team and smeyffret September 17, 2026 23:22
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review (fork) — ✅ no blocking findings

Reviewed af825c930dfe771fb22770abf6984a47d15e3be7 via the fork AI-review pipeline; updated in place on each push.

Review details

The diff is a pure formatting change — wrapping a test function signature across multiple lines, with no change to logic, parameters, or behaviour. The candidate list contains no candidates. Nothing survives Step 1, and Step 2 offers no grounded finding.

No findings.

[OPUS-REVIEWED] af825c9

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed af825c930dfe771fb22770abf6984a47d15e3be7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] af825c9

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of af825c930dfe771fb22770abf6984a47d15e3be7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] af825c9

@jeeshofone

Copy link
Copy Markdown
Contributor Author

Shards 2 and 4 on f4b3726fe failed on test_pid_lifecycle.py::TestSyncKillProviderTree::test_reaped_leader_does_not_suppress_the_group_signal (#11489 flake family); occurrence recorded there. Re-ran by pushing the same tree as d602c77df.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 18, 2026
… drift

The Main Ratchet Audit flags test/test_chat_tags.py as a new black
offender on main (kirodotdev#11616). The file is not in the black baseline, so
the ratchet expects it formatted; this reformats it and changes no
behaviour.

Closes kirodotdev#11616
@jeeshofone
jeeshofone force-pushed the fix/black-test-chat-tags branch from d602c77 to af825c9 Compare September 18, 2026 08:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 18, 2026
@iamwhatever
iamwhatever enabled auto-merge (squash) September 18, 2026 09:06

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: black-formats one argument list in test/test_chat_tags.py to clear the main formatting ratchet -- test-only file, zero runtime code touched, no assertion or behaviour change. CodeQL is not applicable on this fork PR (default-setup emits no check-run); SAST coverage is Semgrep only, latest run success with 0 findings (the single annotation is GitHub's own ubuntu-latest runner-image notice at .github:1, not a Semgrep finding).

@iamwhatever
iamwhatever merged commit 7fc91d6 into kirodotdev:main Sep 18, 2026
82 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 18, 2026
@jeeshofone
jeeshofone deleted the fix/black-test-chat-tags branch September 18, 2026 09:16
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
… drift (kirodotdev#11621)

The Main Ratchet Audit flags test/test_chat_tags.py as a new black
offender on main (kirodotdev#11616). The file is not in the black baseline, so
the ratchet expects it formatted; this reformats it and changes no
behaviour.

Closes kirodotdev#11616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main ratchet drift detected

2 participants