Skip to content

fix(agent_sdk): classify ACP_BACKENDS_SELF_SERVED_ACP as off-card - #11632

Merged
bolichen97 merged 1 commit into
mainfrom
fix/classify-self-served-acp-set
Sep 18, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/classify-self-served-acp-set

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem

main has been red on test/test_backend_cards.py::test_every_capability_set_is_classified_by_the_card since 2026-09-17 17:28 PDT, so Backend Tests shard 2 fails on every PR:

AssertionError: these capability sets are not classified in agent_sdk/backend_cards.py: ['ACP_BACKENDS_SELF_SERVED_ACP']

Two PRs merged five seconds apart, and neither saw the other:

Reproduced on a clean checkout of origin/main (727503fdfb): 1 failed, 19 passed.

Fix

One entry in OFF_CARD_SETS, the bucket backend_cards.py documents for exactly this kind of set. The set's own docstring says it is driver-internal: it answers whether a harness's whole launch is a row of ACP_BACKEND_LAUNCH, which only the spawn path, the install probe and the driver seams ask. The session starts either way, and a wrong membership is a launch that fails — a defect, not a capability a reader would pick a harness for.

OFF_CARD_SETS entries render nothing, so no card changes.

Tests

  • test/test_backend_cards.py — 20 passed (was 19 passed / 1 failed on main). test_every_off_card_set_carries_its_reason covers the new entry's reason.
  • test/test_harness_parity.py, test/test_agent_sdk_backend_install.py — 151 passed.
  • Gates: black, flake8, black-baseline, comment-history, feature-map, docs_lint all pass.

Related Issues

no linked issue: a one-line fix for a red main, found while driving #11390; it unblocks every open PR's Backend Tests shard 2.

Two PRs merged five seconds apart and neither saw the other: #11428 added
the ACP_BACKENDS_SELF_SERVED_ACP set to backends.py, and #11431 added
test_every_capability_set_is_classified_by_the_card, which fails for any
ACP_BACKENDS_* set that reaches no bucket. main has been red on that test
since (Backend Tests shard 2 on every PR).

The set is driver-internal by its own docstring: it answers whether a
harness's whole launch is a row of ACP_BACKEND_LAUNCH, which only the spawn
path, the install probe and the driver seams ask. The session starts either
way, and a wrong membership is a launch that fails -- a defect, not a
capability a reader would pick a harness for. So it goes in OFF_CARD_SETS
with that reason, the bucket the module documents for exactly this case.

No card changes: OFF_CARD_SETS entries render nothing.
@iamwhatever
iamwhatever requested review from a team and buluoray September 18, 2026 01:16
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of dd274c52857271bf530dd8db19e738fc02d96f1e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] dd274c5

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of dd274c52857271bf530dd8db19e738fc02d96f1e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (1 item) — 1 justified

Intent: unwedge the red main completeness test by classifying ACP_BACKENDS_SELF_SERVED_ACP into the card's off-card bucket — a FIX.

  1. ACP_BACKENDS_SELF_SERVED_ACP is now recorded off-card, so the completeness test passes and no card renders differently — justified

The defect's provenance is readable on base: test_backend_cards.py:174 computes every ACP_BACKENDS_* name in backends.py minus the classified set, and base backend_cards.py names SELF_SERVED_ACP nowhere, so the assertion fails exactly as the description reproduces. The bucket choice is derived, not argued: the set's own docstring (backends.py:1752) says "a driver-internal membership, not a consumer-facing capability," which is the off-card bucket's stated test verbatim, and OFF_CARD_SETS is never read by card_for/card_payload, so the claim that no card changes holds by inspection. The entry uses the exact mechanism the module documents for this case; the reason string satisfies the ≥8-word pin in test_every_off_card_set_carries_its_reason. No pin is deleted, no default moves, no new surface ships.

[FIRST-PRINCIPLES-REVIEWED] dd274c5

@github-actions

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed dd274c52857271bf530dd8db19e738fc02d96f1e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] dd274c5

Verdict parsed from the review's SHA-scoped output markers for commit dd274c52857271bf530dd8db19e738fc02d96f1e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable dd274c52857271bf530dd8db19e738fc02d96f1e: <one-sentence reason>

@bolichen97
bolichen97 merged commit e054b09 into main Sep 18, 2026
77 of 83 checks passed
@bolichen97
bolichen97 deleted the fix/classify-self-served-acp-set branch September 18, 2026 02:18
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for dd274c52857271bf530dd8db19e738fc02d96f1e; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt dd274c52857271bf530dd8db19e738fc02d96f1e: <one-sentence reason>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants