Repository navigation
fix(agent_sdk): classify ACP_BACKENDS_SELF_SERVED_ACP as off-card - #11632
Conversation
Two PRs merged five seconds apart and neither saw the other: #11428 added the ACP_BACKENDS_SELF_SERVED_ACP set to backends.py, and #11431 added test_every_capability_set_is_classified_by_the_card, which fails for any ACP_BACKENDS_* set that reaches no bucket. main has been red on that test since (Backend Tests shard 2 on every PR). The set is driver-internal by its own docstring: it answers whether a harness's whole launch is a row of ACP_BACKEND_LAUNCH, which only the spawn path, the install probe and the driver seams ask. The session starts either way, and a wrong membership is a launch that fails -- a defect, not a capability a reader would pick a harness for. So it goes in OFF_CARD_SETS with that reason, the bucket the module documents for exactly this case. No card changes: OFF_CARD_SETS entries render nothing.
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] dd274c5 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (1 item) — 1 justifiedIntent: unwedge the red
The defect's provenance is readable on base: [FIRST-PRINCIPLES-REVIEWED] dd274c5 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review —
|
Problem
mainhas been red ontest/test_backend_cards.py::test_every_capability_set_is_classified_by_the_cardsince 2026-09-17 17:28 PDT, so Backend Tests shard 2 fails on every PR:Two PRs merged five seconds apart, and neither saw the other:
abb8ee47d7) addedACP_BACKENDS_SELF_SERVED_ACPtosrc/kiro_crew/agent_sdk/backends.py.227b72b233) added the test above, which fails for anyACP_BACKENDS_*set that reaches none of the card's four buckets.Reproduced on a clean checkout of
origin/main(727503fdfb): 1 failed, 19 passed.Fix
One entry in
OFF_CARD_SETS, the bucketbackend_cards.pydocuments for exactly this kind of set. The set's own docstring says it is driver-internal: it answers whether a harness's whole launch is a row ofACP_BACKEND_LAUNCH, which only the spawn path, the install probe and the driver seams ask. The session starts either way, and a wrong membership is a launch that fails — a defect, not a capability a reader would pick a harness for.OFF_CARD_SETSentries render nothing, so no card changes.Tests
test/test_backend_cards.py— 20 passed (was 19 passed / 1 failed onmain).test_every_off_card_set_carries_its_reasoncovers the new entry's reason.test/test_harness_parity.py,test/test_agent_sdk_backend_install.py— 151 passed.Related Issues
no linked issue: a one-line fix for a red
main, found while driving #11390; it unblocks every open PR's Backend Tests shard 2.