Repository navigation
fix(test): census the backend-test canary as a resolver consumer - #11889
Closed
helenastafford wants to merge 1 commit into
Closed
helenastafford wants to merge 1 commit into
helenastafford wants to merge 1 commit into
Conversation
PR kirodotdev#11699 made ci.yml's backend-test job read needs.changes.outputs.linux_runner_large (shard-1 CodeBuild canary, conditional on matrix.group) without adding the job to _EXPECTED_RESOLVER_CONSUMER_JOBS, so test_every_ci_yml_resolver_consumer_reads_the_resolver_not_a_literal fails on main tip and reds Backend Tests shard 2 for every open PR. Add the job with its exact conditional expression so the census locks the canary's byte-form the same way it locks the canonical reads.
iamwhatever
force-pushed
the
fix/ci-census-backend-test
branch
from
September 18, 2026 21:57
f14c2a9 to
f73f8b1
Compare
Contributor
|
Closing as a duplicate of #11876, which carries the same one-line census fix and is hosted on a same-repo branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Main's own CI is red.
test_every_ci_yml_resolver_consumer_reads_the_resolver_not_a_literalintest/test_ci_fleet_routing_expression_parity.pyfails on every run.ci.yml'sbackend-testjob readsneeds.changes.outputs.linux_runner_large(the shard-1 CodeBuild canary, conditional onmatrix.group), but the job is not in_EXPECTED_RESOLVER_CONSUMER_JOBS. The census sees a new resolver read and fails.Why it matters
Every open PR inherits the red through its merge ref. One backend shard fails for all of them, no matter what they change.
What changed (motivation → approach → change)
The census locks every resolver read to its exact expression text. The canary read is real and correct, so the fix lists it instead of loosening the test.
One entry is added to
_EXPECTED_RESOLVER_CONSUMER_JOBSintest/test_ci_fleet_routing_expression_parity.py:("ci.yml", "backend-test")with the canary's exact conditional expression. The byte-form of the canary read is locked the same way the canonical reads are. Silent drift in the conditional still trips the test.Backwards compatibility
Compatible: test-only change. No runtime code or workflow file is touched.
Tests
test/test_ci_fleet_routing_expression_parity.py— 3/3 pass with the fix. Without it, the census test fails on pristine main.Manual verification
N/A — unit coverage sufficient; the change is one entry in a test's expected set.
Related Issues
no linked issue: main breakage found by CI, no issue was filed.
Pattern harvest
Rule candidate: review-prompt — when a workflow-census test locks jobs by exact expression text, a PR that adds or changes a
runs-on:resolver read must update the census in the same commit.Pattern: a CI-routing change adds a new consumer of a censused output without updating the census's expected set.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)